Received-SPF: pass (google.com: domain of linux-kernel+bounces-134961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <58b0a77d-8bcf-4d76-82a0-15bfc1cc2e43@nxp.com>
Date: Mon, 8 Apr 2024 10:50:02 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks
 entries
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 shawnguo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 festevam@denx.de, festevam@gmail.com, alexander.stein@ew.tq-group.com,
 Frank.li@nxp.com, ming.qian@nxp.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, s.hauer@pengutronix.de,
 kernel@pengutronix.de, mchehab@kernel.org, hverkuil@xs4all.nl,
 linux-media@vger.kernel.org, imx@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240408030734.1191069-1-mirela.rabulea@nxp.com>
 <fd1d99fe-943f-4fcc-a736-9d97dba5a80e@linaro.org>
From: Mirela Rabulea <mirela.rabulea@nxp.com>
In-Reply-To: <fd1d99fe-943f-4fcc-a736-9d97dba5a80e@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NnpvM25FU3FMUFVBNG42dVJRV2IyMGRLNXpEZDlYY2YwSU5oaGY2WVI5VXda?=
 =?utf-8?B?ckN6dUh0cW0zSm9DbTZta3Q2SEwwbU9kUGdnNFphWU43aHlaNTRKRCs2UkVt?=
 =?utf-8?B?TGU5UHhKaTNjQld4SkQ0TXd6cFlBN25YeUlsREt2QmhVbEZoRnNEUFFUNmhP?=
 =?utf-8?B?dlJobzJKSW5OOG9aRXVVMENFbUFOSk8zRjF1cXRJMkxlc0RlYVhiOTZSbGth?=
 =?utf-8?B?T1p6cnUrbS9LRkNMa3ZrREkrTlhKU0ZBOTM3RDcrNVNJbTk2QVFTVHpvMTJZ?=
 =?utf-8?B?VVF2dnJlY2FVcStxZ2c2NExCckg2ZCs5N01PTTBpdzg4ZnpRWGZ0WWN2dXU5?=
 =?utf-8?B?T1l2bzRVWnkvQm44aHZidjdEOEFOcEw1YnNHWG9KcHNjT1BxbzNiYi9Sb1Z6?=
 =?utf-8?B?dDE2SzA1QTB4c3AvdUN3c0RHN0lxb0RuYm5MdlN6d0YvZm9DTEppL05YSGdB?=
 =?utf-8?B?WTRsc2JBd3RtVm5TVUdyeVpManpQZ3RGMC9kS1dFeC9RbEhPRjhiOStJYkxx?=
 =?utf-8?B?VURCMjVacUlkdDhaWGtqVVNvK0RzV0pRRjd2ckNHaVBGRWVQa2lqME8vZXVR?=
 =?utf-8?B?YWRuV2JFQmM5SDVGbGV5NW14VlJTckc5Ujh6UkdZbDQ3VFlpR3BEYUZxV3Fa?=
 =?utf-8?B?UUdqMUtCSDQwTWJJMTJtV0IxaUl0dUlZeDVZeUd4OEwxVHlCMDllVTJUNE5X?=
 =?utf-8?B?SDZINWJNRHIrbDJiV2JpZGllSFkzdmRLQVVpZUl4a3o0QkdwTHYzQXBGaGxG?=
 =?utf-8?B?bEtqY28xdFFOWFk4Y2s3amdkM2ljcUg2U0NsWFc5Y0thRGFORkNRVmVnM0tz?=
 =?utf-8?B?SUNrcXFNWk5lcG5HOThyZXpVeGJiVUNXb0NEdlRzdW1vZHphS2syMm9vTC9R?=
 =?utf-8?B?ZmU1SlFMd0pSUElBakxkMTZCaElmYm1RendKUzlHOTlBYlhSSHIvMm81VzB1?=
 =?utf-8?B?UkVVdEEzYU9hVm5NUktDRlBRMnBYVDVCWTFEUWNIRkZOQ1cwTmJGWEFSc3dY?=
 =?utf-8?B?Y3gwQ092ZEdzc3NWREhjTk0rMmF4amlZSkwzS2dGVnFIb250SFIvMTNaN2ph?=
 =?utf-8?B?NkVsd2xDdFh6RHRydDhIaHNhd2kxV1VoVktqZW1rWTc5cEFGRVM3MlBVelNJ?=
 =?utf-8?B?ckdzMVpnaXV3WkVGSFF6VG5JQUNUT3ViSTZ3RERKZUNBTTNIVnlSOGZFMFpr?=
 =?utf-8?B?emJKYjFGc2MySU52WjcrbE1oOTdLcHJCb0E4ZjlTR3QyWDRpV2dDdXJiY2pW?=
 =?utf-8?B?K2NnM3IyanZvUUdCdjJMbWRVQ2hvTFhza0trL2RwVVdSZXhuOEoySGEvR3Fm?=
 =?utf-8?B?b3JCMHFKNkNsSFpoSGw4OWRwdGZxZDZjeW9IY0JNd0wxTEZrdFRQdDVpL0gv?=
 =?utf-8?B?Wm1odEZDVTBGZk1TQ1hDbUNtSW8zVGRicG9XOXZNbjZqaGlTVFlwYXdhS1cv?=
 =?utf-8?B?ck5pbGZDNzkrZy83NWZHVVVaQnhXS2sxTVFoU3lpc2ljMHhYcGhnMGJaWkdt?=
 =?utf-8?B?RVRaMnAvTGw5SUU0UTlrWUdjelhLZFRRMlNLWWM5WnY5L0d5T3huQ0tHTkVx?=
 =?utf-8?B?bmJPYmRiV3RlZTcvS1Bzd0Zmc2lhUittdCt0L3VlbzNoQTM5NWdwbDJoRDNt?=
 =?utf-8?B?UWliQzlDVVJ6a2E2K2pUcjdoYUJ1VFc0dE9kM0hoclhzaWxpdGNWcHpDcVpF?=
 =?utf-8?B?elRYS1FXSUd3NXM5QzN4TXJjZnN2cm5SOGVOdm5GVTIrbkVjdUhhcXlRa0Yy?=
 =?utf-8?B?RDhBU3ltTmRydGtBbUlpTXNZS1FTWXpxcnJ5VEM1STcrdzNEeFYyak5ORjI3?=
 =?utf-8?B?UmNkdWsydEhMQjdqYWRDMUFMSm9LNGFEQ0IrbDlneHJOZW1rNVQ2aERTVW52?=
 =?utf-8?B?b2JFYTgxaW5WY1BZeHFUQ2VEdUpUUUJBTG4reUhjWmwreFE4T1g5Qk1RL0Rs?=
 =?utf-8?B?Q3pndTErSUFoUTdZRTJLaFBydWJhaFkzUUJPQnRnd1RYWThNUnhlWDBBaXJZ?=
 =?utf-8?B?VjdNcktHaFBjYkttcEJQMWJ0YlZseG5TU3ZhM3htQXcreGFWd25qWTBvalhO?=
 =?utf-8?B?amVwajRXL1BNUUVIVnphUUdCVUZPMGdVOWdBT0E1Q3gzUHU3MmFXN2UzeEYy?=
 =?utf-8?Q?QL+AyYbnsYFdRznaRPGMei4nI?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51229028-4323-46ed-c917-08dc57a0811b
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9231.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 07:50:05.3769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZVzEQ3tCT5WSv1B7I93D5sDUIjW+KqKbqz8td2NRGOl1AThDz2lozJdL6nOxOmVkMVyO9/+wXPRjuY2996Mh1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7644

Hi Krzysztof,

On 08.04.2024 09:38, Krzysztof Kozlowski wrote:
> Please correct subject. You already got comments on this.
> https://lore.kernel.org/linux-devicetree/2fb8c43c-c079-e04e-f727-3bc1dc29996e@linaro.org/

Sorry I missed that.

I will update the prefix to "media: dt-bindings: nxp,imx8-jpeg:". as you 
suggested in v2.
>> Changes since v3:
>> - Add items for clocks (per Krzysztof's feddback)
>> - Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
>> - Add "media:" to the subject
> Where? It was there before, so what did you change?

I started from v3 here: 
https://lore.kernel.org/linux-devicetree/20230912163810.1750488-1-festevam@gmail.com/

The subject was: "[PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks 
entries", I had just added "media:". Anyways, will update it again.

>> +  clocks:
>> +    description:
>> +      The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
>> +      and one clock for it's core engine (AXI, same source as for the wrapper)
> Description is now redundant, drop it.

Ok, I will do so in v5.

Thanks a lot for feedback,

Mirela