Received-SPF: pass (google.com: domain of linux-kernel+bounces-134980-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: shawnguo@kernel.org,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	festevam@denx.de,
	festevam@gmail.com,
	alexander.stein@ew.tq-group.com,
	Frank.li@nxp.com,
	ming.qian@nxp.com
Cc: conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	mchehab@kernel.org,
	hverkuil@xs4all.nl,
	linux-media@vger.kernel.org,
	imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 1/2] media: dt-bindings: nxp,imx8-jpeg:: Add clocks entries
Date: Mon,  8 Apr 2024 10:58:06 +0300
Message-Id: <20240408075806.1194297-1-mirela.rabulea@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CoKYB4qhhX38uxTzR4rSX6bKr7uWNSne1ALleAOimnom1nP4odoPse4VqXyk?=
 =?us-ascii?Q?b3I/zFRC4P1E4ujF193AtYkWTOJUjmXRgatOUmlcYEfrO6MYU25tqu1CdRMT?=
 =?us-ascii?Q?TQf9nR9AVVwMxz75JelfSkIwy/luKQrobng1PaX72uc7CL/IP49q5djU+/B1?=
 =?us-ascii?Q?kfaupaM/ytrYeFX/a35kTACgF5K1Oj/FrlyIPlkKCbiSZANVEHmW8lePiBQ2?=
 =?us-ascii?Q?Kx42BVI1IGvPpWZt/FY7qBsb043b84x8klkiWZrbX+eMHQE9D5FhJhlZiB8V?=
 =?us-ascii?Q?Zr+CE+IjBykMGTB4522YyhT5Wmor2yJ4MHQfIQI3wwhMOg4EigWupvYwS0uZ?=
 =?us-ascii?Q?Rumz3xEHp7Oy+o+0/0Nv3pluaQ7Ngu2dLHL7q67BycUtrTQCybQCLQVal2vn?=
 =?us-ascii?Q?QA3QdBGR5M+jLqf3OWF1x0emYRLLrOmodjw2EAfWj4z83I6RhcHeunYzkbcM?=
 =?us-ascii?Q?EuOuienNDMGNdSVaR5LSH8qef05q1O2j7qR3WAHWWFS9G6dYes4Cdk3iDb5W?=
 =?us-ascii?Q?N4LRiTSLVOlmiaC8vegMkoF3Y7+DTgYxHt7sNpRX8Xz8bM8zCmS+oIB0WMk2?=
 =?us-ascii?Q?+PyIs+I/K6q9rFVssxBzw5HIITwCYC1C/XZLDbMM6ra9mlSEDOHofzMZAC+U?=
 =?us-ascii?Q?3TkOHiuhgYmjJa/oyfJmW8YdDtb7VZMN7i0eA8fMHXBUnle32XmGsJFvWHNm?=
 =?us-ascii?Q?SfH+yG0EJiwE7bOQ8RXxnGI4RDZFvHa0A0ourkhuFTNQALITv3541BBv3RZc?=
 =?us-ascii?Q?/UyPOTn2Nh4jZGxTpUc+StcwznOClbsp5Cbi5XCU/fwULqqcYmOHJpDquewA?=
 =?us-ascii?Q?ajaMSd8GTcLv+Pn8lGe4I0Icvu8tbqasbZcmZUFoPS9rdbO/iAFcZ87IXBdy?=
 =?us-ascii?Q?jm9X0ttMseGQM/OdfIeC46vH2twm43/mDBg9rYFwBiul0vsQRF+zgLuor+7P?=
 =?us-ascii?Q?1LW8X9iPY90fo7Y9BkuPa1DyGDeLwPYRamFUTxkbD0+DojRJHgq68TuU48++?=
 =?us-ascii?Q?DF7O5BwD63rsads++JhlKBkfNyMnuicpqmPIUm1wUUujyrHriEAm7H4S2q+/?=
 =?us-ascii?Q?LGIGI0AK5LozVNBTBhZXa+MtBQpgD6OK515hiqyr6TUUZyLPmhQanIwbylHa?=
 =?us-ascii?Q?QYzWmat6vx61eQuhOMKWk6pWaekZdlX5yr36cEZMQjkcLeEjwkj01XvLcTf6?=
 =?us-ascii?Q?jgsnvBzZFA7HlVYVX9g974Cuhnynh7uUQA1MgkGZgvUwUnhQEnjDdU9/6C21?=
 =?us-ascii?Q?CPmHUwH0xb14bAhxp66+oIFDEIUO9GIBp6WzTQupqjoiwjHkw7uyjD4w2zIe?=
 =?us-ascii?Q?BNCyzUqSK4514q2ezL35UdPXDoQrsMvcSVnTaBZlYqY/hoFMa5D+oBTZgxhe?=
 =?us-ascii?Q?VIfrjSpp3Oeup8OQQKt/6lvXawVQofym5xzQCms3rM/b0T2lnOZXvNPLxTzZ?=
 =?us-ascii?Q?nLhceKII4lqZ2yS8YmPXpef+pxQjH2oEwqz5JECBsILrE5pYuzPy7p/2U3ol?=
 =?us-ascii?Q?BFBSXjy2Dpjm+n5vAXSu0FO0Wevxo26reEeq9FZNFjBnEkq07z0ihb2jSrJL?=
 =?us-ascii?Q?472k8XzieLcTwSa0VYyrk7DicD36W9SqddYX6q2o?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5846a223-265a-43c0-bc09-08dc57a1a671
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9231.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 07:58:17.5594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oTojo9ETMa7kcDjPQVEoUB/di7zfaHsFvaMnuA72VvQhkUKRJmtwRyXkB+kdAYZ2K66qzgsOFOTDW/gUajm40w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9359

From: Fabio Estevam <festevam@gmail.com>

The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.

This also fixes the following schema warning:

imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
Changes since v4:
- Remove redundant description and update subject prefix (per Krzysztof's feddback)

Changes since v3:
- Add items for clocks (per Krzysztof's feddback)
- Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
- Add "media:" to the subject
- Add Mirela's signed-off
- For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?

Changes since v2:
- Remove clock-names. (Mirela)

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml      | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..2be30c5fdc83 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -31,6 +31,11 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
+      - description: IP bus clock for register access (ipg)
+
   interrupts:
     description: |
       There are 4 slots available in the IP, which the driver may use
@@ -49,6 +54,7 @@ properties:
 required:
   - compatible
   - reg
+  - clocks
   - interrupts
   - power-domains
 
@@ -56,12 +62,15 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx8-lpcg.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/firmware/imx/rsrc.h>
 
     jpegdec: jpegdec@58400000 {
         compatible = "nxp,imx8qxp-jpgdec";
         reg = <0x58400000 0x00050000 >;
+        clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
@@ -76,6 +85,8 @@ examples:
     jpegenc: jpegenc@58450000 {
         compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
         reg = <0x58450000 0x00050000 >;
+        clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg__lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.25.1