Received-SPF: pass (google.com: domain of linux-kernel+bounces-134981-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9e6f1f52-db49-43bb-a0c2-b0ad12c28aa1@amd.com>
Date: Mon, 8 Apr 2024 09:58:34 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support
To: Rong Qianfeng <rongqianfeng@vivo.com>, Jianqun Xu
 <jay.xu@rock-chips.com>, sumit.semwal@linaro.org
Cc: pekka.paalanen@collabora.com, daniel.vetter@ffwll.ch,
 jason@jlekstrand.net, linux-media@vger.kernel.org,
 dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
 linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
References: <20211113062222.3743909-1-jay.xu@rock-chips.com>
 <1da5cdf0-ccb8-3740-cf96-794c4d5b2eb4@amd.com>
 <3175d41a-fc44-4741-91ac-005c8f21abb8@vivo.com>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <3175d41a-fc44-4741-91ac-005c8f21abb8@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WlVIZWZ4V2JEZlVGTE9uY29aVGxIMjl5YUFyRXBNT3V2YUQrQWRMWDRUT3or?=
 =?utf-8?B?NXBLYmx6V1V5Y2dwNFc3RE9Xa2ZBWGMrcW8wOWMwcU9lOWV6TE9uaDRkUmt2?=
 =?utf-8?B?ZzluczNRNmZtYysvcy9MOEkxcGJLaGpiTEZmWFQ5RWRVVlJMLzdubzNuRlBi?=
 =?utf-8?B?YVB5ald4WjFjTlZKaHBxRjgreUhxSUx4TXBlVXVhU1NjRUJJK3lCVTBLSFdr?=
 =?utf-8?B?ZTlScFhpQWtPaDVlZlNYeVhXVGZBUjU5Yk9MVGVISFkrK3BLSUFTenF0ZExy?=
 =?utf-8?B?NE16YnN6NEFPWUV3K1FCTVVZd3VIVnNpMUpoWVhTejc3MWlqbHNHS0s0dEY3?=
 =?utf-8?B?Rnhzb2dpMTNDVHFWOEhJd1Y0OG95VmE3QVg5cmVkdU9MMlhZVkpNM0tVbG1x?=
 =?utf-8?B?MDBpcXM1aW1JREZOSzRJZEhxV3BDSVNmdnJ4TEZVQ0MwVzFkWXA1SndEbS9E?=
 =?utf-8?B?ZzEvRkVPaEdZQ1BISnBadWVPU2xxcTFyMlhxUEhNZVRTai9wQkY1MWxsRUpT?=
 =?utf-8?B?MWxOR0pZaFNEbnJsdFhYMmsybDlxazdGK2luc04vaDlKQ1ZYWjhWdldiL1hB?=
 =?utf-8?B?Z2xJRlI0OUI4czV6UFMxSUdwTFhUbnVsaDR3dno3MU8rS1VBOEp4QUVsY1Nz?=
 =?utf-8?B?REJ6c1Fzd0Z6ZzJxdTNzcXlMWUNYTWpoZmVhWTJmcHk2cUp6b1hDdDFhR0Mv?=
 =?utf-8?B?WDFmdlkyc3JwQTZjODZxVmEySUxzLzNDYmdHWHN4Y3BXdVlmeTc2NGlyQWRs?=
 =?utf-8?B?aDVBaEhjUlFMUmRxa0U2QXB2NVZCdlNjbVZ5VlhGU3RrS0h6TjhzaHB3bWNk?=
 =?utf-8?B?TVErbVZQUGZROEV6Mk40MHk3Zi8xenJLSFJOSVBOaW9ONkZaS2d2cnROKzBj?=
 =?utf-8?B?MVBES1dpOUlJc082ck5qakIwRWtaTkN6K1pSSnFXN1B4SFdzS2J6SkdPZmxw?=
 =?utf-8?B?eTlxbW5GS1hsTyt5WWk1dGRVOGwzL0tTb0F5TnB0SU5CK01vaktLUHNta2hn?=
 =?utf-8?B?WFZTODFDZFE1cVMwMGtaKzBJYjVsUHJ5YU1laDlhbU5qRDhDbEtrVFNhcW9H?=
 =?utf-8?B?RFhrM3lOd0RMZkpkZ2FYNVR5bUZNU1N2d3NFVU84Nmhqb013Wjc0TVRlY2pv?=
 =?utf-8?B?VXJNaTM4M1BhcFhYV3lzVFo2WXdSdldQcjZ6Z1g2WGcwRU1YMGhkL0RJZUZn?=
 =?utf-8?B?dG1JT0lWMzEydkNDUjNzczFVU0RZTkJhRVBsRmkreU9sSTY4VndJSThFcjJ5?=
 =?utf-8?B?UEpCSFdtRnJObFVHdVFzekp3dXZaZEJvOXpOSEdvTkQ3RFR4VjI5YUc3QU12?=
 =?utf-8?B?cG9jTEF3eWdoYUQ2dnpxTis1RnNZQXRrK3IvVHZsbm4yWW9xVU5hWjYvK3dh?=
 =?utf-8?B?YmxZWVF3M3Q0ZnFXUU5RN0F2N3A3Um14ekl5SkI5MjZZUzg3UllsbnpFeE4z?=
 =?utf-8?B?bFpCc21WYzBJL3dGZXRNSFFhRHFiL3U5ODliVGt1TmhmL1ppU0VYc1RySEEy?=
 =?utf-8?B?NWhPS2tQeGJKWHdDNnVhbW9TM3RKazJUbFY4UzlzSXFzdXczelF3TFZKdWFQ?=
 =?utf-8?B?c0M4Ymk1L3NFNjkxZmRtR202U0lGMWZvNmUxQ0FjbUJrMjVSbDJFbmRDaEc2?=
 =?utf-8?B?bjZVektUMkJ4aFozUHJIMThycnBFQ29NdktES3oyejBYYTY1cDFuTlpsa2M3?=
 =?utf-8?B?dGhDNVg2T3g0ckhKYjBDSTRxKzcvL1BiM0ZRKzBvQXJpaU5NZ2FVaVJ4YWY4?=
 =?utf-8?B?aWtWb1haMkF3ZGFlTFFiSU1iekZQOENDUHVVN0k4NDF3NVE4Q0huRTZuUjVZ?=
 =?utf-8?B?REhMQjJHenFmYzFCY0VWeEl3L1RjdVhXcFBpbmJsL0toOUtzUFFDM1huVXdM?=
 =?utf-8?B?RGRaaW9tY3JKdFpTREhtSlJZc0hpQjFzSmx1bW9vU2VKbkxSQjB6cmJpSFZu?=
 =?utf-8?B?RkJPaE10M3ZjaFVTVnY3NTZ5OS9Qd2RJcWhyZDFLRWhTMUFyTld2ZFdKR2h1?=
 =?utf-8?B?U0k0WFlZZFQzajVVRGg2QzN5WHk5NEtOQis3ZkVNamtVT1pFM0g5MUVFUlpQ?=
 =?utf-8?B?TnJyUWZVNjBjdFRGU0J0d1Vncy8xV2xyUkVaM1FDQlVOU2FQdkYvcDJGWmdF?=
 =?utf-8?Q?3Yao3I+CBwlkIS22PSK64Qj7o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d45e26-6daa-46b5-d02a-08dc57a1b346
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 07:58:39.3462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LY9Pr9mjmc0UQFiFA6NAKx8aMRZTs5iZsbVtWTAWA2MwO0OGzMOor4A4l72wkGrO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6824

Am 07.04.24 um 09:50 schrieb Rong Qianfeng:
> [SNIP]
>> Am 13.11.21 um 07:22 schrieb Jianqun Xu:
>>> Add DMA_BUF_IOCTL_SYNC_PARTIAL support for user to sync dma-buf with
>>> offset and len.
>>
>> You have not given an use case for this so it is a bit hard to 
>> review. And from the existing use cases I don't see why this should 
>> be necessary.
>>
>> Even worse from the existing backend implementation I don't even see 
>> how drivers should be able to fulfill this semantics.
>>
>> Please explain further,
>> Christian.
> Here is a practical case:
> The user space can allocate a large chunk of dma-buf for 
> self-management, used as a shared memory pool.
> Small dma-buf can be allocated from this shared memory pool and 
> released back to it after use, thus improving the speed of dma-buf 
> allocation and release.
> Additionally, custom functionalities such as memory statistics and 
> boundary checking can be implemented in the user space.
> Of course, the above-mentioned functionalities require the 
> implementation of a partial cache sync interface.

Well that is obvious, but where is the code doing that?

You can't send out code without an actual user of it. That will 
obviously be rejected.

Regards,
Christian.

>
> Thanks
> Rong Qianfeng.