Received-SPF: pass (google.com: domain of linux-kernel+bounces-135027-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <00016dca-9e32-4cc1-8d0e-36eaf12dc466@intel.com>
Date: Mon, 8 Apr 2024 10:24:28 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: linux-next: build failure after merge of the sound-asoc tree
Content-Language: en-US
To: Stephen Rothwell <sfr@canb.auug.org.au>, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Linux Next
 Mailing List" <linux-next@vger.kernel.org>
References: <20240408141216.3eb1128c@canb.auug.org.au>
From: Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20240408141216.3eb1128c@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dytIdkw0WjBwd3gyRzJFQXdoQjZlTHVMd0dMaTZUb3Z5S0VXWGZIT3NKdEF3?=
 =?utf-8?B?YUkvcXZwbnNBdFJKK2t0cG5LcjRNOTlQRFIyRUxma1hpdkp0TWpCeGljS0pF?=
 =?utf-8?B?Q1V6T2VRSmpBVXkwS0hHeEZxT1QxRzNHYURxK1kvUHIrbXdXMkMwTDVwZUt2?=
 =?utf-8?B?ZkJHb25PcTdkUCtDQ3JRYzMwQ0JEUEI4RDFmUzF1TUZvKy9tTzF0aG1LeDlQ?=
 =?utf-8?B?R1FncVJFSm1DRGZ2bFRSaDQzOGY2VkxZMi9tT2twY2wwb1dzd2xYelZqQkhw?=
 =?utf-8?B?T1ZpeHlNcVVFbDhyTTNETHpWTkJyc2hRa0lIYlBoNG53YmNaSjNCL2VIYWhk?=
 =?utf-8?B?QXI4R29TYXdrcVo2MDhWNXZVM0owOHlQYzEvcTNzaXdwRHpJaXIxMDdlMGVx?=
 =?utf-8?B?a2F6SFJ6cWRHSWRVbERjMVA2eHk1dnYwMVJCTmprRjh6d1ZOUGVuUExEaTNt?=
 =?utf-8?B?dmowR3NRaVFUWEFXM1JZMFpsSDhHbHFYQVZaemNrb21WM3YxdUZpUUhxY3ZL?=
 =?utf-8?B?UzZEUkp1aUwyMm16clZ1MXhxZElybFBRZnVMeks5K0JBUnRWRis2b0o3a2d0?=
 =?utf-8?B?WTZoR2ozRUhiQkpkeGtITjBCUXlxR0JjTHZGTWkzeXBIMnNFVi9nZnU5eHcr?=
 =?utf-8?B?YVVaU01QNzFHWXRJVUtVb0xHRXVwOS9xcmM4YW5lblJWb1A5dDhWa0xwazZa?=
 =?utf-8?B?aXB2RmN6aEFmdzd1Vk5iVUtqZFQ4VjUzVFBzbDhKQWQycmVleXBoNzJETkJQ?=
 =?utf-8?B?Vm5VaExEYkdMRGpxMXlvWlZkVzk3LzRVbmd0N2xXUE40K21Ha3BlNGxrdDE5?=
 =?utf-8?B?c3k2SEpUeEkvMVBVaUw4d2NSZXVLZU9KTU5FRTZwUHF3T1JTd2lYOTA3Vm1j?=
 =?utf-8?B?THVpQ1NQV0owWnRranpBY3JwcTl0YW5BalFZMGVTTytsZjRJQktaU0lHZkov?=
 =?utf-8?B?R2FnM1g1N2pDWVY2M2lkTWFvcmtVQjVleGlOMzlobjlJa1VtcXRhNWNZUlN5?=
 =?utf-8?B?cEh5SE1va1NuYWJqSXRUZjdHeS9YK0U0SnZobTF5QXB6Z2ZpalcwbTlGRXBa?=
 =?utf-8?B?QlBTQ3JRNGVTOWlJVzh4OFFqUDdPcmpZZW03YkdiSzVGMUFFMjZVSFFZbmx3?=
 =?utf-8?B?K0lpUGZKNzhwRXRRcHVwalA5dkRWMjJ0cEthTW9XN0s5d3FQcGNFTXVIdWV2?=
 =?utf-8?B?d25ZeGhvUUlKMVllcWlUcVN1U1RnQlNJUG9iWEdEMHcwYTNBYzdBcExxOTNJ?=
 =?utf-8?B?dnluK1lKVE15NEVTbnlXQ2Nsc3U5RndOTi9hTERtTlAwdTZLUTlWQTRsbXAx?=
 =?utf-8?B?TE1oU3N1ZE0wbWRKYjl1SXhkcnk3VUplcGJGdnMrT1pJWWxSbzEyWlcwTEFR?=
 =?utf-8?B?NnpySXM3VzZ3Y20wS2NTTGZBUzEreFFpQUtOUmhRbUNJM2Z6RmlySmNLSU9E?=
 =?utf-8?B?THppeDg5bnpNRzdQNVVHNjZra1RhbEpmM2g3dHpiRFVzTjUxN3NEWTBJZUpl?=
 =?utf-8?B?Ri9VQi9FUjhDcWZmWVBabTh0R3VmeDJQNEUrSWk3WEcvWi84azEwc2JWc3Zy?=
 =?utf-8?B?MnpDUFRmaTV0MElKOU5uL05icjZxTzBhSVBmYjkrNzVZUlhtNFRzT3ZqcXlJ?=
 =?utf-8?B?dVgxcVZzZXBWbVBGOEhDejFyN0hDYllOSGtSMkNMQXdSK1ZjbFBjVlk2bllK?=
 =?utf-8?B?d252aHdWZ0VwbVdnUXlLcTNlWHVvSnBudksva2p0QXlsL1B3eDhOZGFtZ1pR?=
 =?utf-8?B?RXlHalg0YVZYMTF2WHUzK0VjTE1ubEo0VTVIOTk1SlNLVWpzWUJUQ2tTVEY0?=
 =?utf-8?B?ZFFVK3l1OTk1MUxGb2t0UXRuWUNqNGFIZC9sdFR1bUNueStTN2EyVnBaNzNy?=
 =?utf-8?B?S3JibHErMlIwQzJYdEZrWTY1bjdpRlUyZEVERFR5NHgvQmJ2K1VINjhJdXZB?=
 =?utf-8?B?YnFrNHhydXlxR2J5MFFwTFB0MGkxTVA5bjU1b09wZGdtM1VPbTd5MGJmQTRG?=
 =?utf-8?B?cFgxNTdHRGlPTnZ0VnBDc0ZhUEFjcEhWREtVQU9iRng3K2JPVU5oRHREUzZl?=
 =?utf-8?B?Uy9ZQXl5dko1aitaRGlMc3dDMGtFWTk1RWE1c0RaRVdQQS9obW5ONUtkMk1Z?=
 =?utf-8?B?dTR4cTJNZm9nNkZYejBybTM2RnZicjdjMDBXNTgybzl4MUs2eFc1WVRMM0hQ?=
 =?utf-8?B?ZFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 18e74fae-5704-40bd-d087-08dc57a551da
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 08:24:33.6537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RpS9SBsS56JottxcJJWa4YvwDojbz9SeAYJc25Kq7PX2yn+rev6U5BZnp9YYgj/0gn1rXR6sGQscs7goADVzf64NfvhMQXacaGrXbgFZeYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7839
X-OriginatorOrg: intel.com

On 2024-04-08 6:12 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from include/linux/bits.h:22,
>                   from include/linux/gfp_types.h:5,
>                   from include/linux/gfp.h:5,
>                   from include/linux/slab.h:16,
>                   from sound/soc/intel/avs/icl.c:9:
> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct avs_icl_memwnd2) == 65536"
>     78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>        |                                         ^~~~~~~~~~~~~~
> include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
>     77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
>        |                                  ^~~~~~~~~~~~~~~
> sound/soc/intel/avs/icl.c:73:1: note: in expansion of macro 'static_assert'
>     73 | static_assert(sizeof(struct avs_icl_memwnd2) == 65536);
>        | ^~~~~~~~~~~~~
> 
> Caused by commit
> 
>    c2b10acb62c1 ("ASoC: Intel: avs: Add assert_static to guarantee ABI sizes")
> 
> PAGE_SIZE is 64K for this build.
> 
> I have applied this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 8 Apr 2024 13:50:53 +1000
> Subject: [PATCH] ASoC: Intel: avs: stop building when PAGE_SIZE == 64K
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>   sound/soc/intel/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 4b9e498e3303..abe5cba82d50 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -211,7 +211,7 @@ config SND_SOC_INTEL_KEEMBAY
>   
>   config SND_SOC_INTEL_AVS
>   	tristate "Intel AVS driver"
> -	depends on X86 || COMPILE_TEST
> +	depends on X86
>   	depends on PCI
>   	depends on COMMON_CLK
>   	select SND_SOC_ACPI if ACPI

Hello Stephen,

Thank you for the report. I do not believe the patch above is the 
correct fix. Below is the context and the proposed fix [1] has just been 
sent to alsa-devel.

Recent series for the avs-driver added static_asserts() [2]. Since that 
moment, build problems occur when PAGE_SIZE != SZ_4K. Patch originally 
designed to fix problems with the window description [3], didn't address 
all the problems, unfortunately.


[1]: 
https://lore.kernel.org/alsa-devel/20240408081840.1319431-1-cezary.rojewski@intel.com/
[2]: 
https://lore.kernel.org/alsa-devel/20240405090929.1184068-13-cezary.rojewski@intel.com/
[3]: 
https://lore.kernel.org/alsa-devel/20240405090929.1184068-3-cezary.rojewski@intel.com/


Kind regards,
Czarek