Received-SPF: pass (google.com: domain of linux-kernel+bounces-135051-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 8 Apr 2024 10:35:52 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, Brendan Higgins <brendan.higgins@linux.dev>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, Joel Stanley <joel@jms.id.au>, 
	Andrew Jeffery <andrew@codeconstruct.com.au>, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, 
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/64] i2c: aspeed: reword according to newest
 specification
Message-ID: <wcnu6qxxztplzpqtqc4t3bf53v6buto6ch6b5l5xoytrxxdgjz@gwzlifzzfrvx>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org, 
	Brendan Higgins <brendan.higgins@linux.dev>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@codeconstruct.com.au>, 
	openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, 
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com>
 <20240322132619.6389-6-wsa+renesas@sang-engineering.com>
 <vb4hempklviz6w4gd3eimprplybm4ckefwz2gyy7cp2uww2anv@b4egbq4u4rrg>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fm2sehicf2gvt3hb"
Content-Disposition: inline
In-Reply-To: <vb4hempklviz6w4gd3eimprplybm4ckefwz2gyy7cp2uww2anv@b4egbq4u4rrg>


--fm2sehicf2gvt3hb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > -static int aspeed_i2c_master_xfer(struct i2c_adapter *adap,
> > +static int aspeed_i2c_xfer(struct i2c_adapter *adap,
> >  				  struct i2c_msg *msgs, int num)
>=20
> here the alignment goes a bi off.

Thanks, I missed this.

> >  #if IS_ENABLED(CONFIG_I2C_SLAVE)
> >  /* precondition: bus.lock has been acquired. */
> > -static void __aspeed_i2c_reg_slave(struct aspeed_i2c_bus *bus, u16 sla=
ve_addr)
> > +static void __aspeed_i2c_reg_target(struct aspeed_i2c_bus *bus, u16 sl=
ave_addr)
>=20
> We  have the word master/slave forgotten here and there, but as
> we are here, /slave_addr/target_addr/

I can do this now. My plan was to convert it when I convert the whole
CONFIG_I2C_SLAVE interface. But "since we are here" can be argued.

> >  static const struct i2c_algorithm aspeed_i2c_algo =3D {
> > -	.master_xfer	=3D aspeed_i2c_master_xfer,
> > +	.xfer	=3D aspeed_i2c_xfer,
>=20
> here the alignment goes a bit off.

I also wanted to fix this afterwards together with all the tab-indented
struct declarations in busses/. But maybe I better do the tab-removal
series beforehand? Would you accept such a thing?


--fm2sehicf2gvt3hb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYTrGgACgkQFA3kzBSg
KbaYiw/+IdfDf8ES2q59HpvmAbphgCrIhyycf7z24hxpdlMNa8KCH+NGusDVZ8x6
DpMDISrjfNpwL+rpE0shnhzmKDo04CYGRceF5E71B2Gk/1s1ujxNOGP+VP0nW/19
jb8zMDFeuEnkKqF2T2e3lCpTLsP41V4Fl+wWNPL+AkS7hCBCjYyvDemtknRJjqzZ
OkawH3O73gJ1m07M10Q0IOLfDBMh6qFw2URTIMEgvfErroscCYruNq7BXisWfCHo
85iiYyiWeWgTpdp6SPFL+apD519ZnS4i6F4XrsVV/Kk02U7izS7QxYi74y7NDA97
JAQVUSy0JkVmAvwcncQhc5xYc+XJcO3lXd4Gw3UJieVVfwUWm/oKJ+qXeoFUPVUT
2zOltFsyZX1y0tVS6+A81It3lVzAsihUy4Z0vmPa5IyB1yFxHZ6ljsOV+slH0otE
+RfzSHL+tA/GdojNayLC70qTKri+goIxImhP4XZn3dc/5RaX9rSfooeNGkK89SJx
s7aK447F0zoeH5GiK3V3aXGY7XLFHE6WSBGy/MQorHu01PF16jlh7Hagyk1BsIM8
c13TUVcc9pgSHW5gPBqay2f+SfTJCtapK2KO497kfPmP4S5o2JXRYRwFezZa8ODE
YI8mFy0scsJxEv5P0WlByOFGFRbFkcaD+gMejTz5bBCUUAUVa+s=
=iumt
-----END PGP SIGNATURE-----

--fm2sehicf2gvt3hb--