Received-SPF: pass (google.com: domain of linux-kernel+bounces-135077-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240408074219.3030256-1-arnd@kernel.org> <20240408074219.3030256-2-arnd@kernel.org>
In-Reply-To: <20240408074219.3030256-2-arnd@kernel.org>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 8 Apr 2024 10:47:15 +0200
Message-ID: <CANn89iJnBYSOU4QroWPNoo2eTt8R_2MtHJ+thWm-oz01O7TgKg@mail.gmail.com>
Subject: Re: [PATCH 2/2] ipv4/route: avoid unused-but-set-variable warning
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, David Ahern <dsahern@kernel.org>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>, 
	Kunwu Chan <chentao@kylinos.cn>, Zhengchao Shao <shaozhengchao@huawei.com>, 
	Sriram Yagnaraman <sriram.yagnaraman@est.tech>, Maxime Bizon <mbizon@freebox.fr>, 
	Joel Granados <joel.granados@gmail.com>, Kyle Zeng <zengyhkyle@gmail.com>, 
	Beniamino Galvani <b.galvani@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024 at 9:42=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The log_martians variable is only used in an #ifdef, causing a 'make W=3D=
1'
> warning with gcc:
>
> net/ipv4/route.c: In function 'ip_rt_send_redirect':
> net/ipv4/route.c:880:13: error: variable 'log_martians' set but not used =
[-Werror=3Dunused-but-set-variable]
>
> Change the #ifdef to an equivalent IS_ENABLED() to let the compiler
> see where the variable is used.
>
> Fixes: 30038fc61adf ("net: ip_rt_send_redirect() optimization")
> Reviewed-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

A Fixes: tag like this seems overkill, I doubt W=3D1 was the norm for
old kernels...

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.