Received-SPF: pass (google.com: domain of linux-kernel+bounces-135078-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>, "sivanich@hpe.com"
	<sivanich@hpe.com>, Thomas Gleixner <tglx@linutronix.de>, LKML
	<linux-kernel@vger.kernel.org>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel
	<joro@8bytes.org>
CC: "Liu, Yi L" <yi.l.liu@intel.com>, "steve.wahl@hpe.com"
	<steve.wahl@hpe.com>, "Anderson, Russ" <russ.anderson@hpe.com>, "Peter
 Zijlstra" <peterz@infradead.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>
Subject: RE: [PATCH 2/2] iommu/vt-d: Share DMAR fault IRQ to prevent vector
 exhaustion
Thread-Topic: [PATCH 2/2] iommu/vt-d: Share DMAR fault IRQ to prevent vector
 exhaustion
Thread-Index: AQHahiB7n7Y2ch8WjEeOJ91b45rj4rFeEdyg
Date: Mon, 8 Apr 2024 08:48:54 +0000
Message-ID: <BN9PR11MB527677A69A2004A951165CC38C002@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240403234548.989061-1-jacob.jun.pan@linux.intel.com>
 <20240403234548.989061-2-jacob.jun.pan@linux.intel.com>
In-Reply-To: <20240403234548.989061-2-jacob.jun.pan@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z78s5ZH3X2GzPIua3ZVyu6Hh2IGQ2N4ak3AV1fgvvH7aJXb0TaZWZj73BnVv?=
 =?us-ascii?Q?0eyRF/czm0hgV9GqR7v4zBQ49u/bcejQS4My3A9ad5fKJy7eL5RJY1DLAgrp?=
 =?us-ascii?Q?OkVwLErv4Khsg3VhwJYXyciAUgg5SPhCSmPUvJJ75Oaa5BWwZ4hAX4wNkLWy?=
 =?us-ascii?Q?+MmYvlsIVkEWkY91KOgku7ugCFjeMiSCJyLjaBOmcTnLntBbm8b4WsoZLg0a?=
 =?us-ascii?Q?9V12IV9B6HJ5h+EO4+5R/rVTzbDvB5U/WW1lTvB0kFQ5okFd6DZ8+9ObAviy?=
 =?us-ascii?Q?fJn2UT2QCMuPFhM6tptvYjuaD9D5h6avvZcm8DeZB4PGhPbxbOcvptSpfprc?=
 =?us-ascii?Q?mRkwt2N7i4OPMRhKf31hKELQJYaxoS8Upf7Sw56N5vMG7ivSFLpS9SJVQt7Z?=
 =?us-ascii?Q?Xsck8acqzc4PBI/Ctui/foGUvepVnxKlbotgKLtwlmfxDAZN4kqBSBtkeiGn?=
 =?us-ascii?Q?epI8qQB8wIQvUeh85VKNQaPoRwJYtEJgzqqyKdHOP/c/YJat21+ZI8tQEN0o?=
 =?us-ascii?Q?iZRl9gKzDo2vH8FRX/qJZzNLaDzNmPazptdne8Y+kqy/TB11utQzMRHe41Qn?=
 =?us-ascii?Q?bkJIIwwBz3nqlRQ6iNFnxetWIB5XM69lkFrN3CvMWPIR/cBe/U/miBV6+lb0?=
 =?us-ascii?Q?0hdJMncpeaRiq3nyvvPXinZIDR4HVHoYRkkmEu+paNFoSyPNJja4jsTdXh9L?=
 =?us-ascii?Q?vxVX8p/rbrg9jUGFGRvZlLOFMlz7EQuSmupKsABfi6Xv39T6XnySbFdWf1+P?=
 =?us-ascii?Q?3ia3Xvc51gN+K7QZ7Ro8fOQbO9TrzKjCHOL5gc+Li5+eEA1g7k9Ok6kLQizw?=
 =?us-ascii?Q?dwhzdfUbmVG8vgf6Pf5QsnC5uIdWDPkn58JMeJcOFhkDUyB+ViPB7hCS40Fo?=
 =?us-ascii?Q?Ge1Xs0LvM9fqKuEkI494rHyBEXXNzb4Gfl/ZMSt2mj5043AU3mS19eJb38N2?=
 =?us-ascii?Q?NgYVtumMzAmzxF3/pBLQ883uoICp+BLqPYe5cqYbY8f3+bQz94rgCoFi1PGp?=
 =?us-ascii?Q?7TEZ1CdbtWaCwuNoKaN2BaVJi5+VRvROdhrA022cVafXQKq33ejSxsSxddvy?=
 =?us-ascii?Q?rVhDRKeayIdgsJ74OvWZPJjrKukZ6osiRo6QM2CYnwcqUUJvwC5ZnNHXDIb0?=
 =?us-ascii?Q?3TywvTJ4LHvaHiII55LqS0c5aXhUV2Om575hKWC5AVFY2EzWp0l1WySClw7z?=
 =?us-ascii?Q?q0QqYjVeW2rnwTpU4uc4rNDUx3gAk5ge7VQ50Q7sxdgyB/Eun/nCb5E2hmMi?=
 =?us-ascii?Q?dygNvDXX69d5A10SwKf/q5ltx3udrHhDwcfojYosBpgHdzX7gnMNjNpDS0gs?=
 =?us-ascii?Q?CLHnegdFgCMqHc081VDJwC3k66fN/ndN7FeU9jfNuLV35ZtIzUGHPczPLzE/?=
 =?us-ascii?Q?awrne96Mpp5fWUKvUH+AjS/aaPXszHO6QtrkxubIuNeGft5n9EL0ZiERpi2V?=
 =?us-ascii?Q?cSTZphHuY1fSh0sw1/Q/ZdKYxsiZA+ccMLOMa+OlovlwwLkf9Op1wJfHYmXC?=
 =?us-ascii?Q?KJy91bRfVDY9E+OJGi2gfuNfw8oHW1dPuBQxKAGHf6pf+fGocqHVwKHGf/5d?=
 =?us-ascii?Q?1xs1E5o+G1hdaTSqxf4WRngTtDkpiyup2C6FD3bo?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22d5e5d4-b806-445a-5b92-08dc57a8b8ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2024 08:48:54.4483
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RbYjectOlV4XHA4XkHdolP61gRJi6gK2qeLulAOQVTKYoRrksuSqY3nyyb7GcA7Z/LpkgwxBl44VIkhBQ0i2Hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5781
X-OriginatorOrg: intel.com

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Thursday, April 4, 2024 7:46 AM
>=20
> DMAR fault interrupt is used for per-IOMMU unrecoverable fault reporting,
> it occurs only if there is a kernel programming error or serious hardware
> failure. In other words, they should never occur under normal circumstanc=
es.

this is not accurate. When a device is assigned to a malicious guest then
it's not unusual to observe faults.

in this context you probably meant that it's not a performance path hence
sharing the vector is acceptable.

>
> @@ -1182,7 +1182,6 @@ static void free_iommu(struct intel_iommu
> *iommu)
>  			iommu->pr_irq =3D 0;
>  		}
>  		free_irq(iommu->fault_irq, iommu);
> -		dmar_free_hwirq(iommu->fault_irq);

You still want to free the vector for the iommu which first gets the
vector allocated.

> @@ -1956,9 +1955,8 @@ void dmar_msi_mask(struct irq_data *data)
>  	raw_spin_unlock_irqrestore(&iommu->register_lock, flag);
>  }
>=20
> -void dmar_msi_write(int irq, struct msi_msg *msg)
> +static void dmar_msi_write_msg(struct intel_iommu *iommu, int irq, struc=
t
> msi_msg *msg)
>  {

what about iommu_msi_write_msg() to match the first parameter?

otherwise it leads to a slightly circled calltrace:
	dmar_msi_write_msg()
		dmar_msi_write()
			dmar_msi_write_msg()

> +
> +	/*
> +	 * Only the owner IOMMU of the shared IRQ has its fault event
> +	 * interrupt unmasked after request_irq(), the rest are explicitly
> +	 * unmasked.
> +	 */
> +	if (!(iommu->flags & VTD_FLAG_FAULT_IRQ_OWNER))
> +		dmar_fault_irq_unmask(iommu);
> +

em there is a problem in dmar_msi_mask() and dmar_msi_mask()
which only touches the owner IOMMU. With this shared vector
approach we should mask/unmask all IOMMU's together.=20