Received-SPF: pass (google.com: domain of linux-kernel+bounces-135079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240408074219.3030256-1-arnd@kernel.org>
In-Reply-To: <20240408074219.3030256-1-arnd@kernel.org>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 8 Apr 2024 10:48:54 +0200
Message-ID: <CANn89iJ8h+RTAnZv5EKFg6+fNU_AaH_cYOv=o2RJxtMuYWJiDQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] ipv6: fib: hide unused 'pn' variable
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, David Ahern <dsahern@kernel.org>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>, 
	Breno Leitao <leitao@debian.org>, Kui-Feng Lee <thinker.li@gmail.com>, 
	Kunwu Chan <chentao@kylinos.cn>, Kuniyuki Iwashima <kuniyu@amazon.com>, 
	Ville Nuorvala <vnuorval@tcs.hut.fi>, YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024 at 9:42=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_IPV6_SUBTREES is disabled, the only user is hidden, causing
> a 'make W=3D1' warning:
>
> net/ipv6/ip6_fib.c: In function 'fib6_add':
> net/ipv6/ip6_fib.c:1388:32: error: variable 'pn' set but not used [-Werro=
r=3Dunused-but-set-variable]
>
> Add another #ifdef around the variable declaration, matching the other
> uses in this file.
>
> Fixes: 66729e18df08 ("[IPV6] ROUTE: Make sure we have fn->leaf when addin=
g a node on subtree.")
> Link: https://lore.kernel.org/netdev/20240322131746.904943-1-arnd@kernel.=
org/
> Reviewed-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

It is unfortunate we add an #ifdef just to avoid a warning.

Reviewed-by: Eric Dumazet <edumazet@google.com>