Received-SPF: pass (google.com: domain of linux-kernel+bounces-135085-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a13678652cf7f06bb40d78182b02c1398ef06119.camel@gmail.com>
Subject: Re: [PATCH 1/4] dev_printk: add new dev_errp_probe() helper
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Jonathan Cameron <jic23@kernel.org>, 
 Lars-Peter Clausen <lars@metafoo.de>, Olivier Moysan
 <olivier.moysan@foss.st.com>, Jyoti Bhayana <jbhayana@google.com>, Andy
 Shevchenko <andriy.shevchenko@linux.intel.com>,  Chris Down
 <chris@chrisdown.name>, John Ogness <john.ogness@linutronix.de>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, 
 linux-iio@vger.kernel.org
Date: Mon, 08 Apr 2024 10:57:02 +0200
In-Reply-To: <42sw4ugekugyqzjylsci6tvw5zfxlwz6ypnetnau6dyqnrqfiq@5jde2w4etpfh>
References: <20240404-dev-add_dev_errp_probe-v1-0-d18e3eb7ec3f@analog.com>
	 <20240404-dev-add_dev_errp_probe-v1-1-d18e3eb7ec3f@analog.com>
	 <42sw4ugekugyqzjylsci6tvw5zfxlwz6ypnetnau6dyqnrqfiq@5jde2w4etpfh>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Sat, 2024-04-06 at 20:35 +0200, Andi Shyti wrote:
> Hi Nuno,
>=20
> ...
>=20
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned.=
 */
> > +#define dev_errp_probe(dev, ___err, fmt, ...)	({		\
> > +	ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__));	\
> > +})
>=20
> I have a whole series adding a set of error oriente printk's. But
> for the time being this looks OK.
>=20
> I just don't like the name, the 'p' is an important detail, but
> a bit hidden... how about dev_err_ptr_probe(...)?
>=20

Agreed, not a very good name indeed.

- Nuno S=C3=A1