Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1215246lqe; Mon, 8 Apr 2024 02:09:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4BVDyT8MwuZVOMDYHxMgnCI9XUGwnjma7igVZtH+axGOb2Bpyj7P4Wkb3111IRAF6IKOKfY85CO/OX3dZLqrfh77n5s7XoAXklf5FNw== X-Google-Smtp-Source: AGHT+IEB4JwWFveT8N5h8vEaPio0FVUWX9e6hK+h13xEQkdcJEazNngcy9YcMuFEu+1r/9hK7Bxu X-Received: by 2002:a05:6a00:22d1:b0:6ec:fdcc:3cce with SMTP id f17-20020a056a0022d100b006ecfdcc3ccemr8791927pfj.5.1712567364981; Mon, 08 Apr 2024 02:09:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712567364; cv=pass; d=google.com; s=arc-20160816; b=s+nIjoPJ4X0Kn5FCQzEA1N5oAf5szFMwoZa1j78gdwH/xq7O8JRnGgn9Nxu4Ison4J o/g7ui//gOzf33TP/u2m4/Z0RZxhapRWDgMLisx0kjp352WNjG7VPVVelaqU9kp9x6Tt 0V2Lg2BDUQYBGu4BW4ycKlrmVvdO1A2lYy12NPQ2Ocud0tOQFUW7izBqRpd4hE8YpL6U 4e52y65s79OsUW+zZxWgVxLdChCZh+ucanmtVk/O4LZoe7cEsV1Pc0KnqBdvxjpx19QQ ECyx0M/9u31+xWtEXSijBkLJMpZVtzZvtbW0E5bFzLEn6xDQhOXs/V7O88DwwC1eapHq OQJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=tk/FMXk9/BxJnMNCpZbjrtftVzviHOWK1p4pvZ7JEcs=; fh=pUgVbpxiU/FBeZTkw7BLAOBdKUV2mRTg/l8IYygUPFE=; b=SIDJGBcn6FJJjGq8WjNJAB5ImfvJpr+x1a5BdDpeTN0+72I048PvFASvJF2tiA8+Fx v0Uys8VEWBZcihDBGKb+VZo5fIpLUs/VMAwlDk3q8MOGrTZloy0xgX+no8ZFnt7uqI0c uzBj4oq0dQqWcX7Pud/9fZ5evEsC3ofQHau2K5/oyncd5JkBNM9y7U4nt1gX777JJTKy jCJHisfLYH+2TrjLlNzoQwcV0NH6QREWLwIVvZHVuOuFewQHQzXBVFReH6L0/DnN8prE EFHSCM3DQo7PYmuOlNwypOu5JHmYQG5w4rJsee+b46AAXCuxYtunuuqY3R+ruaBk/bXY E1MQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=neLQpJu1; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-135105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r2-20020a632b02000000b005dc15e82c4fsi6023746pgr.170.2024.04.08.02.09.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 02:09:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=neLQpJu1; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-135105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135105-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 38A6CB2315A for ; Mon, 8 Apr 2024 09:07:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BD7A4AEC2; Mon, 8 Apr 2024 09:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="neLQpJu1" Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E40D48792 for ; Mon, 8 Apr 2024 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712567258; cv=none; b=tjECqmRD4xak2eHYkHhop/vxaeu6gDwUPBpZH59ImiLQ5wfLwpp+bOegPC/yXVEF/Q0VEe9TCtHu2eiZZBW7Ol86JFT7BB5pmZrUmDP3heWRw8frNFP0QZBhwJTZjZwW0Ca5laARw9BFQAr4UAWM3qOUzzEc4HDYkOpFVr3mHHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712567258; c=relaxed/simple; bh=tk/FMXk9/BxJnMNCpZbjrtftVzviHOWK1p4pvZ7JEcs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=QZUmTvt+/pfbgyXokQqIag4T+xfINmsJbLPbseKo0zXAIIHKPdjbX3kW2eGpC0guwJFIsxBJpagN/clDDok2brZ7MTC8PJQ9oBiFYp+P1n/6H6sC32six0/4nlw5AN8cwoyeOESEzAwGmqo2hl6Oy5ZwDBqr35lbCd6EbldvPwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=neLQpJu1; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-61814e68cfcso4123607b3.0 for ; Mon, 08 Apr 2024 02:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712567256; x=1713172056; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tk/FMXk9/BxJnMNCpZbjrtftVzviHOWK1p4pvZ7JEcs=; b=neLQpJu1ltJQSpt2HIz2fVulRGgAM0rv/Q0y2eAlFnvd6rO6WuAcAiAq1qoFjVytH6 YRk1BHZZLviSVQZfWLa7hiw/7sccY+wlzeS83PuCTETaCgS1CV8nGCs3T9/LaGx+Wi8F d5VoEt7yZj3FvYQBkdJdC0bpBx4EVIqNPX3GmmW9oqOnassdlKHS6jqS5E/Kg+npaFLh AETBk+NaQdU32VqUM5AcpZ7CkRuw65XV5220NpEdLq1c+Y4Lm7uqD6gGSM9MVn57dcR1 q60kBGur4VgFBWzgLi3EGi7F0L7UjhXK+ijSIFppOxoqtq3+n54A7w5eeYdwgl9ChJub NKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712567256; x=1713172056; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tk/FMXk9/BxJnMNCpZbjrtftVzviHOWK1p4pvZ7JEcs=; b=dKBCfPFmu0LVhLod5oQkCMK4EyosLqmbd+3LBHHSH409LA1NMA6r3W/sRrfWS+pVb9 iLwMxMdjdIJO4y4rTd3CEFBsPmlpMt2JqiwXHg6bz4BqJjnKswsxDh1Lspnje9klP46r UXeURs9QJMNveuKwPLYmWWGnZYWjMgNn5puniKVaC4Cauv2cWBaGvOy3JCvhxL1HgW40 IZ64FYt8COZSsdocLgwlNnTe8pfl75BkAeR7J63mwAQKSN3m/gMPP+9RGXzYAI8ayffn DVCXNzb+krDNikA4UKdrq9tRH6I9RyOjO5lUyrq15zxnVj5ahS6qT49Hpj/aOp+O26hA wmWA== X-Gm-Message-State: AOJu0YzQc7tI90YJt1kitxkdyVHoEuLib8PtGIfSAWouiwbl5Cl4YrKY R/IaSL+Pec7AViXhuE6Rz0jfzoRbUwcsdFtbG4Xx4lLG9pJPLCXvJq/uoYKgepsEmEQtwaZ050r L03Udfo6hssX/pKP0M8K4gyD8uEVO/Zbrn+1+QUVrtp5buFKo X-Received: by 2002:a5b:b8f:0:b0:dc6:dd80:430e with SMTP id l15-20020a5b0b8f000000b00dc6dd80430emr6480600ybq.27.1712567256106; Mon, 08 Apr 2024 02:07:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240405115318.904143-1-jens.wiklander@linaro.org> <20240405115318.904143-3-jens.wiklander@linaro.org> In-Reply-To: <20240405115318.904143-3-jens.wiklander@linaro.org> From: Linus Walleij Date: Mon, 8 Apr 2024 11:07:25 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] mmc: block: register RPMB partition with the RPMB subsystem To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, op-tee@lists.trustedfirmware.org, Shyam Saini , Ulf Hansson , Jerome Forissier , Sumit Garg , Ilias Apalodimas , Bart Van Assche , Randy Dunlap , Ard Biesheuvel , Arnd Bergmann , Greg Kroah-Hartman , Tomas Winkler , Alexander Usyskin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jens, On Fri, Apr 5, 2024 at 1:53=E2=80=AFPM Jens Wiklander wrote: > +/** > + * struct rpmb_frame - rpmb frame as defined by specs As Tomas said maybe we can write the name of the spec or the number or something so users can find it? I would also write explicitly "the stuff bytes and big-endian properties ar= e modeled to fit to the spec". Yours, Linus Walleij