Received-SPF: pass (google.com: domain of linux-kernel+bounces-135110-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <bebf1a1a-e4ec-4ec0-9d01-57a51bcf14ca@intel.com>
Date: Mon, 8 Apr 2024 11:09:44 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Duyck <alexanderduyck@fb.com>, Yunsheng Lin
	<linyunsheng@huawei.com>, Jesper Dangaard Brouer <hawk@kernel.org>, "Ilias
 Apalodimas" <ilias.apalodimas@linaro.org>, Christoph Lameter <cl@linux.com>,
	Vlastimil Babka <vbabka@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <netdev@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20240404154402.3581254-1-aleksander.lobakin@intel.com>
 <20240404154402.3581254-8-aleksander.lobakin@intel.com>
 <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzB5T0hWQ1NwbUVBbXFVWXVuNnZVaG5XYzIxTHB4b1hWNGJ6YXRhOGJObWdh?=
 =?utf-8?B?Tm9rRVIrckN6TlA4UmxjLzBtUlFHeER0ZEt5dHVsdEdlK3RjWXhPOEhNa3ll?=
 =?utf-8?B?ZW5PS25jUms0LzZwYnJ5U0w0cmNhYWpiRUpVUmJ0c3lqUEVKYW5sMlpQNXRJ?=
 =?utf-8?B?SjlrZVFxRDIxZEZPcU5ESjZBOWhEOXZVZ0FtZlV2WmhObDBIak4zWUhDWWhj?=
 =?utf-8?B?WXZ6OUVZWHMxakVsNWFLYkVFRkkrMUdCUXdkYWhyOXVvOEFUZDExRXJPNGRM?=
 =?utf-8?B?dmtjRm0vMVcvOW1TaHV1WW1qd1hwWG5ZQ1dSUWVTSVVSUXN0T0pCQVFVelBx?=
 =?utf-8?B?UkdVRUVKdDNUTUh4VlZpZDBBV3dKNkpPTW95WkxBVXIwV1NYWEswNUcwSUEv?=
 =?utf-8?B?b09iWVh5WGdtK1VNU0ZDQVBOcHRtcEdOcDFhemhBWTNFNWdyaFJicHF1UXo1?=
 =?utf-8?B?RzUwc1lYVjlyMU54Wkl1V24wZ0MxSVp1MERqUW8rQnhhTWt4WTA3SUMrY29k?=
 =?utf-8?B?YnNnRE04NlZ4VDVYWWZXSnZmOHJNL09YWHEzVk95UzhqaFExY0xPVnBJd1pv?=
 =?utf-8?B?S0FZZXlrTHR0VUxvZnF3b1JWaGNjZk1uZm5LWU8zV1gwN1BNL1U4MlpmSHM4?=
 =?utf-8?B?dDR2OXM5aXVSUGJxd2lrUlczRElPMWI1cGQ0WW1ad00zdkZBWEljSW56S3VV?=
 =?utf-8?B?dVJTRVYzcDBiTTFvamNva0VwcGtnczkvRWdObFZTQ1NqYmxNeHM5ek5QRHIx?=
 =?utf-8?B?RnYxYlZCZjltOE1kUm91L053YVVFL0JLRFptQUxnYTQ1UHFOMEVBL0tqOWVm?=
 =?utf-8?B?N2JFSGlHMWhVYTl3a1dYSmpqQ0hkSUw5ZDA5a2JpZmRwTnhEcWFQZVVJaU1p?=
 =?utf-8?B?NWJ3NWErR3VtUjd6WDF2b0ZuOCtQQzJMejVXVTN0SjEwQkRuNW1vTnZlNzdm?=
 =?utf-8?B?RnBhbVJINitkMzMvUFk0VmhGV21SL2VHd2JGakxqbzNQZEs1TmNSM0xRTjZ0?=
 =?utf-8?B?NlhtendIckZRaWtvKzlJV2ErMWgxOFhyNmVtbDNnN2t1QTA4WW81OGREeHFo?=
 =?utf-8?B?eURhTi96aGtUek5jUFllNHhZblhQK2lncVlScUN4Ukx1ZUpTbWw4Wk9hdC93?=
 =?utf-8?B?SHFBU01zZ21aeVJWQXFMQ0tvQi9LNEtqY1ZtSmV6MFY1cXhGbFhLYUd0NmFB?=
 =?utf-8?B?Ym5uS3BBT1BjRDVpSGM0ZXFpRjJNSEh1ZVloOTdzTUVNVW1KaHlncHZ0V1RL?=
 =?utf-8?B?bDBmZ080dExwb0RGbkFWL2dFR0NYTzVOUm8rRXhSa244Wmdad1dHL2IyN3pL?=
 =?utf-8?B?dFJKdnJOQmZwZngyNDB6eXhIT2pYcHBRSjRwQmEzelUvenJqcW41dnM0MnpR?=
 =?utf-8?B?WVRQVTQrdjVDWFoxM3F0K1pQM1E2SUVwYnhVQnJ5c2RwZnJtTG55eDVnU1Nz?=
 =?utf-8?B?REN0VXM1aXBuYVh6SFFUVFg0WENSb05sSE1LRUlJczA2UldpVE5EZjcrdEpV?=
 =?utf-8?B?YXpzWDhtUjNIeE44MzVWaFNNM1JBU0w3U2dnaXdtbkdxSXUzUjNTb0RUTjBt?=
 =?utf-8?B?Wk5aaElBL3ppMTZ6clNhTUROdFBUaG12S1U1ZVlvRjRwTmZOeWxUMDVZWGtO?=
 =?utf-8?B?ekdyOFU1bm9vWXd0UldKK1JQV3p6ZWlzaEJuN212UHROWDhLcmkzRGVQWHBZ?=
 =?utf-8?B?V2hsSWxaSnNQVjIxUjdKTHBNVmdFN2Zub01tUmNwa21BVjZCZERQRzhoTFpF?=
 =?utf-8?B?YUtzSjdTZWFJOWJ4RnZ2dVFrRk5nYXR3cTBXYjVNdlU4b0Zxc01WM2Vqd05J?=
 =?utf-8?B?RThRWktDSWZQVzhZYldWU1FrYlpQSFh5RG1Wd0F6Ymd0d1ZSSm1qYVZJQkhy?=
 =?utf-8?B?RWZsaXFLbUhlT0FSa202KzJDdzZwMTF3ZnJwbkNYT1VaSlJ6UHQ5TU9zckMv?=
 =?utf-8?B?UFIzTGJ1K2tRQUFmT0c3UjVpYnZKUHRNTjVoYkh2RmxNZWJUU1dRY0kybnBI?=
 =?utf-8?B?a3hZSjhnei9hd2J1VkVFcERyWVZnUUR2V3U3cDUzWEVmMXZ6ZUxDOXpkSFBF?=
 =?utf-8?B?NXg0eWZnbFFLcFUyRE5mWVhDeHNMVHFDZFZ1SE96eGhlSFFTcXNKZnhjRHpH?=
 =?utf-8?B?ZERBZ0puWHBvbUhQakNWRUJST2xKZUptVlhsQmhDWWx5eDcreTRoZittNzRB?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 868098ad-fb3f-4e62-f966-08dc57abe401
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 09:11:35.7044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ocxv2x6ini8GqHzp8MquuDRldZ6GfJflq+nQxcMSOulxf6g/naOvAGErNCOv6dc926gUozRQXG10sZqe4hfwlhsK9VcP85O4YMCaMCgM3U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8321
X-OriginatorOrg: intel.com

From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: Fri, 5 Apr 2024 12:32:55 +0200

> On 4/4/24 17:44, Alexander Lobakin wrote:
>> Add a couple intuitive helpers to hide Rx buffer implementation details

[...]

>> +struct libeth_fqe {
>> +    struct page        *page;
>> +    u32            offset;
>> +    u32            truesize;
>> +} __aligned_largest;
>> +
>> +/**
>> + * struct libeth_fq - structure representing a buffer queue
>> + * @fp: hotpath part of the structure
>> + * @pp: &page_pool for buffer management
>> + * @fqes: array of Rx buffers
>> + * @truesize: size to allocate per buffer, w/overhead
>> + * @count: number of descriptors/buffers the queue has
>> + * @buf_len: HW-writeable length per each buffer
>> + * @nid: ID of the closest NUMA node with memory
>> + */
>> +struct libeth_fq {
>> +    struct_group_tagged(libeth_fq_fp, fp,
>> +        struct page_pool    *pp;
>> +        struct libeth_fqe    *fqes;
>> +
>> +        u32            truesize;
>> +        u32            count;
>> +    );
>> +
>> +    /* Cold fields */
>> +    u32            buf_len;
>> +    int            nid;
>> +};
> 
> [...]
> 
> Could you please unpack the meaning of `fq` and `fqe` acronyms here?

Rx:

RQ -- receive queue, on which you get Rx DMA complete descriptors
FQ -- fill queue, the one you fill with free buffers
  FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever

Tx:

SQ -- send queue, the one you fill with buffers to transmit
  SQE -- send queue element, i.e. "iavf_tx_buffer"
CQ -- completion queue, on which you get Tx DMA complete descriptors

XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk

I know that rxq, txq, bufq, complq is more common since it's been used
for years, but I like these "new" ones more :>

> 
> otherwise the whole series is very good for me, thank you very much!
> 

Thanks,
Olek