Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1225097lqe; Mon, 8 Apr 2024 02:34:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCLhY43M50YWBKvOdjVq89aNzPzKDyEZAL/1DSthL+FWh6IGHo02w5nX7SyL+Yipb0m+yjP10w0ZC+eTcHn6o0ojQa/ZC/hDsMQFVlGg== X-Google-Smtp-Source: AGHT+IFCLJypiqsNJLwhygKG57CefMOf+X9Dmbn55AOE05bvf2os5l0i6EcQ3i7BK4HeLfm4iYsR X-Received: by 2002:ac2:528f:0:b0:515:9d9e:7339 with SMTP id q15-20020ac2528f000000b005159d9e7339mr6752759lfm.20.1712568876871; Mon, 08 Apr 2024 02:34:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712568876; cv=pass; d=google.com; s=arc-20160816; b=s6KjXJLX7AX+0GG6jqPG8FIhcXAc4W3a0l5A4sh+gCmlRnlo0qbt0v7hkWsgneJnuU C6M399rqpje8lcH8DXGZdODFeJ2Gx+5lfb1ZyG+yO2I3m7enaLWZX6et9aqJUv/iEiJv Fq19k8eQCajD7f89MLeVK2QuigHQT1AMe0X3aE1qE7h6uhR9vHn+965okMC1nLViTYss 8nCmO0QGm+PFr9ljLx14na4O3mxUSQtXwZF/ENYOBh5z8SkxYUsK0O0e20tzpFkaTH8L DgeYpIW+PwNhVUdBHXRijC+lw1j/xCjBJL6LHDNIgQibb9jv5k7v4dcfmw5D7PKOpijU zUNg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=ccdZGemQtAOmH95htQ33GvCmGD7g1WiaWWMlzba2fiM=; fh=aGe5wZ5hBF7rhAs9l2TGmqlGAZuUkiUcgMU+DkbjZJw=; b=QvXq1X13nBTEyH/V29g1VHYRzHviEtOZAIOPguehwB7eyc0c1Q/G+30cQz+LMV49wM djnW+jgzUGjhYOM8I5izg4VNOlr7X/mbVO6A3RINSNuMPeP3Xx7z4bDExA5/fD7bRlbS DX6m7WkNYOueHcV0Gopi4KxEXDSKctaO/UAleSt6YgrvUFYg+5VKPjp91aXTpdvmuiS9 na5FFwMXjG5tuy81lc4XmkcYmlwlArnglCCiknWuper5R9MY+pDTOUCN/2rIAjmH2EGg Ozj9bNOMh4LZBNCwMH2yJI1Z0W1Q36zh/eS4W8bhLXoT8u7iyy16EScK32fSaJqy/0wS K+rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MJ2iZZN8; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-135157-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135157-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id dr19-20020a170907721300b00a4e8aaa9f04si3674633ejc.518.2024.04.08.02.34.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 02:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135157-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MJ2iZZN8; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-135157-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135157-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 85E211F230B9 for ; Mon, 8 Apr 2024 09:34:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1237481B1; Mon, 8 Apr 2024 09:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MJ2iZZN8" Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F3F4438F for ; Mon, 8 Apr 2024 09:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712568866; cv=none; b=LZnrUX9RL/LwNTr2S6x/bQZ8gNlcUiu9+lQA6zJyejpmnFMy6gdJIpZMTWhUssQDAq6KcQIXOxI1713xgLzcsoCn9WqXVhu/fXJAjRXmUlxe3Tmx3qj2gSowtuIe4usidNJwaXq6oMgQzzrZKApvy50K5c5oqie+KbeQ3CUc24c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712568866; c=relaxed/simple; bh=jVEBoWe0mok+ita+GP0jIRcLrJNCSnNIFQYdeB4TPlQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=kWY3JGVFzKpousU8HdbDvaWHzlaL8dpF+COOWHc6qMqqamzv9ecXRt9gSxyWIrw2RzUATS806uP3TOgghpTu6J1bnJf+mgepAyJDFdnO63bC8w5YcYqDROu1NiCER8FRyAlLB5m2isbxLbDYeVNi0Fx66iTeTgYKb1qAsyvLYvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MJ2iZZN8; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-614ec7ee902so43335097b3.2 for ; Mon, 08 Apr 2024 02:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712568864; x=1713173664; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ccdZGemQtAOmH95htQ33GvCmGD7g1WiaWWMlzba2fiM=; b=MJ2iZZN8HBc5vtcr3vfCg8JXmFZo4FWwVC+/up+QVypwah28G/aydLWDAmCmAt1Pd+ Cv0FQO0k/e66F48/83NCfRfmpr4G5sC2O4EP+qYKm5XapotU8E4Fw1C4mPYBlCGbjMru sjRV2HsbdZwfhfNEbHeLItY3/bQhiAmkMuAb4mWlBm12o5z7T7FjcHoYmUOhu23mVrXI SG4FMEjBapsR6aodwYnnHXBNPUoXc9HM0NcYplj752PRwOP1tVq9JRqE3+K2eDw7Z7YT YZ+1UuC5wPBEWZxAQ/kAgvJlj5YmMJbJS6BPKeA7Z3B4bFIEHoEyVsYTkrNGK6BYWsuu 33mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712568864; x=1713173664; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ccdZGemQtAOmH95htQ33GvCmGD7g1WiaWWMlzba2fiM=; b=F7SeQwDTX851il/vSDE/+wHzgvzdjMn6kBqi3BKegkYeVEYoz6RnYF0HsGy6YekCsh CAZIQgexNuhTWF+h1df7Kkq7tkdkCVlg+DBlbCgdjdmvJ0jf+00Aqxk5B1FzxsjjETvP hQ0J0jy63a8eZS8eqwDFCQN4IbqpAtC6moka0l7VbjjjI6fWtmMilfacmV6HpGOS6tue Gc2tTEZFVfYaNasymVdbyXVaNzQn5o41Bi6EXoF/BSaTtLk//Fmh2r/A7UEHfhn3eULE BuggEF5d1/Vn8sOpyRlK7BJvJm8+09SD6sRQz5O0fmT0IPV4+briMdZRO31dx5pzPkVe cJqw== X-Forwarded-Encrypted: i=1; AJvYcCXYf+ozCfVIWEuDo33CX87Ub9ptRREqTYYKybAZTwT55ft8baTzOVHaY+v7y20yFAfwRaz+4k6OlIs4B93wBGX4Cek09lLs2dwmqnme X-Gm-Message-State: AOJu0Yz/ybk1h9JKC2TTa5R+nd1/bPJYTV9165HAK2zkYwsoxN8z3PC1 a6HgUfO9eclkMyDHt8T0rOIMbyusoAI+VV9c6BkHwKLsENaj2jSvLBzqj72KuwWJlXMHdxWGdJv PjVQLXtCKSyAdV0LpBCCohnQc6dpfeUNBtPPz2w== X-Received: by 2002:a25:aea3:0:b0:dc6:d093:8622 with SMTP id b35-20020a25aea3000000b00dc6d0938622mr6172768ybj.15.1712568863856; Mon, 08 Apr 2024 02:34:23 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240408093023.506-1-johan+linaro@kernel.org> In-Reply-To: <20240408093023.506-1-johan+linaro@kernel.org> From: Dmitry Baryshkov Date: Mon, 8 Apr 2024 12:34:12 +0300 Message-ID: Subject: Re: [PATCH] phy: qcom: qmp-combo: fix VCO div offset on v5_5nm and v6 To: Johan Hovold Cc: Vinod Koul , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stephen Boyd , Abhinav Kumar Content-Type: text/plain; charset="UTF-8" On Mon, 8 Apr 2024 at 12:30, Johan Hovold wrote: > > Commit 5abed58a8bde ("phy: qcom: qmp-combo: Fix VCO div offset on v3") > fixed a regression introduced in 6.5 by making sure that the correct > offset is used for the DP_PHY_VCO_DIV register on v3 hardware. > > Unfortunately, that fix instead broke DisplayPort on v5_5nm and v6 > hardware as it failed to add the corresponding offsets also to those > register tables. > > Fixes: 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable") > Fixes: 5abed58a8bde ("phy: qcom: qmp-combo: Fix VCO div offset on v3") > Cc: stable@vger.kernel.org # 6.5: 5abed58a8bde > Cc: Stephen Boyd > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 ++ > drivers/phy/qualcomm/phy-qcom-qmp-dp-phy-v5.h | 1 + > drivers/phy/qualcomm/phy-qcom-qmp-dp-phy-v6.h | 1 + > 3 files changed, 4 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry