Received-SPF: pass (google.com: domain of linux-kernel+bounces-135199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] zonefs: Use str_plural() to fix Coccinelle warning
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <99a8d3ec-1028-44c5-9fcd-01598a40a014@kernel.org>
Date: Mon, 8 Apr 2024 12:04:36 +0200
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
 Johannes Thumshirn <jth@kernel.org>,
 linux-fsdevel@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9AAAD718-D1D7-416E-87A9-3CA2BA20C93B@toblux.com>
References: <20240402101715.226284-2-thorsten.blum@toblux.com>
 <99a8d3ec-1028-44c5-9fcd-01598a40a014@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>

On 8. Apr 2024, at 03:48, Damien Le Moal <dlemoal@kernel.org> wrote:
>=20
> Looking at this function definition:
>=20
> static inline const char *str_plural(size_t num)
> {
> return num =3D=3D 1 ? "" : "s";
> }
>=20
> It is wrong: num =3D=3D 0 should not imply plural. This function needs =
to be fixed.

I think the function is correct because in English it's:

0 files
1 file (every number but 1 is plural in English)
2 files
..

Best,
Thorsten=