Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1241278lqe; Mon, 8 Apr 2024 03:12:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUySenqMfic+pcNpWIUfd6oBxo6hShgeF7QUlesgHuZRoddyL4hz2qc93m5Zy9fQJiDsY8rMqa23TnS5LBgGnDoaLuxSfIm7OcLKjeOTw== X-Google-Smtp-Source: AGHT+IHLVGlV9C7Tew/mDud424ueZBl3E9zjHnJFE27qsYflztgUhjLd766o4aXg5jkgmDDbJ44o X-Received: by 2002:a05:6a20:748e:b0:1a7:8bdc:1869 with SMTP id p14-20020a056a20748e00b001a78bdc1869mr1032896pzd.11.1712571159316; Mon, 08 Apr 2024 03:12:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712571159; cv=pass; d=google.com; s=arc-20160816; b=bLSL9GCOiQgb3l9GHrMOnqt4fFLVx7v3nnUEbB3T/M7oKg2uT5/VFMbCg11Ty8fufv fC4LMoojtqLfdxziQjwdhZVJIjRUGKzICGQ674CE0lpkyzIMuaJEOWQnskiNQaAtgAni DuJRY6PUnb8TSZrkFQLMSpI44W+Zt8yRcnvCxQ6oWonXYnei+kfpEcTthMQGd1RIHkcX ni+E5a6ozpbYCRVAgCyC69LXgvaBsvw5v1DP6/7TyEr3nCAESxGKVLDU+d6N99Qwo9y2 6dZzIsZOr1htApagOSg3cW3KffFRFmTmTChnvVzZFmpO0PF79617/CL+NNfTa7wxhkDw TfYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=/huYobYq5KCE4csYMJA/WWSJl9IQXHyYAxE17DSw7c8=; fh=os6smxG/zPUoUEU1rjT/rBvi62ijoU+R6y+9sWyNyhM=; b=tnffT4WDsAt7TT/c3axBuym473+TZz446971aGZFEdrWlVI8qK3lT/bDDp7NMz7m9O baXYGvqrN/0COQ4D8jVLCExrv2vMyes0yeWJ0eWWBSZ4ylOt8fB8xV8+XXXultwPhBNe D/JCENvrxmQlK+Rxg9ZjoDTxwMkkiLz7J/TwDTdKNVYt7aNiyEu4wOAGAS0K0vDxTuyP YApI1q34Lxgk1DBPml5diGzXMSESMJ+sssnIUCg8SpNr3CYTNb8kCRtIIgNmOAZZKLh/ hsSQbkcJEV8oI6ZsxcZD3cDTXkyY0YNdtcFHrCqTP5HNCDe1EgF/SpzxoliMau62Dowk VwpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qlp4k2VD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135207-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id e15-20020aa7980f000000b006e8f71c6382si6053922pfl.361.2024.04.08.03.12.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 03:12:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qlp4k2VD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135207-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8A776B235FB for ; Mon, 8 Apr 2024 10:11:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A93D54277; Mon, 8 Apr 2024 10:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qlp4k2VD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754425338D; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712571027; cv=none; b=U7fWdaoXLNFdDmBG9UuvA13PhIthVc6SQVQ8KCtq6p1ay3rhB66JVNmnsUIYhrMuoGzuFDfNhS7+3MKyJBlY02MNhxato6V+ocf6bWK9W/p1OUMPy0ksHiHY5WDIvj1iTQxnZhD8axehoz2aHGVvn+SKEq9GuKhu1QW6JoTDuZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712571027; c=relaxed/simple; bh=x+XrOol6yWyCizxrCWOJ4+a0py0a9Q0xvIdnby2O6R0=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=Jc3aDZ6MKd4BkiQRvvkZmX44KXTyeveMk/PZ93Gmxd2UAX1IsuT7rC8D5Ges8SgbYSaCQ4Db5SJNdFYhbPSGr688XklmO3k1iv7WSeLt4Z7iCr6g7oZvjPBWc+u/wGffsmQb83wvo6kmFTEGoPgMaxh3RjEnfvhd2N/4A7yc4SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qlp4k2VD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 2BE3AC43394; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712571027; bh=x+XrOol6yWyCizxrCWOJ4+a0py0a9Q0xvIdnby2O6R0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qlp4k2VDn9EuhCEJk7K3FBy3HYyssjwc6Q8Z6TIDwXjvRWs8iEtjO8rtbGlclPSSW lyiHMiLP6hYzFvOL0oJ5QKSTNTWmnfH5dKpu+A9oAJcLIxzvVp/KZvMkLT9UvjnK6A ymVtTiu81lybfdx0DhYxq3h9orjun1qP1LgpD9VXlXo8whpqXOrI+54W/CDI0Zdu6y CClsuWCjtzn+dWR+HgM76Kvu1nplipakS2h8Y8Ypj2OUQaQj3lPWvpv1HCi8l/6jhI TG75Zya/QxSLXpW22pdQpxI0f7QVDu4lhouQz4GIL5Pl9q//g/u7plnfHKRaUztIJL 1ebsv50Ml6aBA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 212C4C54BD9; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next] ip_tunnel: harden copying IP tunnel params to userspace From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171257102713.30740.3149927029161291551.git-patchwork-notify@kernel.org> Date: Mon, 08 Apr 2024 10:10:27 +0000 References: <20240404160302.3585661-1-aleksander.lobakin@intel.com> In-Reply-To: <20240404160302.3585661-1-aleksander.lobakin@intel.com> To: Alexander Lobakin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dan.carpenter@linaro.org, dsahern@kernel.org, horms@kernel.org, nex.sw.ncis.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 4 Apr 2024 18:03:02 +0200 you wrote: > Structures which are about to be copied to userspace shouldn't have > uninitialized fields or paddings. > memset() the whole &ip_tunnel_parm in ip_tunnel_parm_to_user() before > filling it with the kernel data. The compilers will hopefully combine > writes to it. > > Fixes: 117aef12a7b1 ("ip_tunnel: use a separate struct to store tunnel params in the kernel") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/netdev/5f63dd25-de94-4ca3-84e6-14095953db13@moroto.mountain > Signed-off-by: Alexander Lobakin > > [...] Here is the summary with links: - [net-next] ip_tunnel: harden copying IP tunnel params to userspace https://git.kernel.org/netdev/net-next/c/5a66cda52d7d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html