Received-SPF: pass (google.com: domain of linux-kernel+bounces-135266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 8 Apr 2024 13:29:32 +0200
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tejun Heo <tj@kernel.org>, 
	Zefan Li <lizefan.x@bytedance.com>, Johannes Weiner <hannes@cmpxchg.org>, 
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Subject: Re: Re: [RFC PATCH v3 6/9] selftests: cgroup: Add basic tests for
 pids controller
Message-ID: <qweowkm4wlfzovp3qhtkzbybeampodtwmpbp2kbtiqcrhmjtdt@syk4itfkpmfr>
References: <20240405170548.15234-1-mkoutny@suse.com>
 <20240405170548.15234-7-mkoutny@suse.com>
 <a45c2ece-acb4-4cff-9d53-f5c007c9b905@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="u36r24juol4udy4e"
Content-Disposition: inline
In-Reply-To: <a45c2ece-acb4-4cff-9d53-f5c007c9b905@collabora.com>


--u36r24juol4udy4e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Apr 07, 2024 at 02:37:44AM +0500, Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> The
> 	ksft_print_header();
> 	ksft_set_plan(total_number_of_tests);
> are missing. Please use all of the ksft APIs to make the test TAP compliant.

Will do.

> > +	for (i = 0; i < ARRAY_SIZE(tests); i++) {
> > +		switch (tests[i].fn(root)) {
> > +		case KSFT_PASS:
> > +			ksft_test_result_pass("%s\n", tests[i].name);
> > +			break;
> > +		case KSFT_SKIP:
> > +			ksft_test_result_skip("%s\n", tests[i].name);
> > +			break;
> > +		default:
> > +			ret = EXIT_FAILURE;
> > +			ksft_test_result_fail("%s\n", tests[i].name);
> > +			break;
> Use ksft_test_result_report() instead of swith-case here.

Do you mean ksft_test_result()? That one cannot distinguish the
KSFT_SKIP case.
Or ksft_test_result_code(tests[i].fn(root), tests[i].name)?

Would the existing ksft_test_resul_*() calls inside switch-case still
TAP-work?

Thanks,
Michal

--u36r24juol4udy4e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZhPVGgAKCRAGvrMr/1gc
jkcRAQDfTQHi6illQsUgcXSAIodsO9Z2hcWZ0Oly6vYAN7OZXgEAn0NtUBk0wQBw
tQYzo52YpkylzKawaHv3c1ayxTXUwgc=
=hKE+
-----END PGP SIGNATURE-----

--u36r24juol4udy4e--