Received-SPF: pass (google.com: domain of linux-kernel+bounces-135302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: shawnguo@kernel.org,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	festevam@denx.de,
	festevam@gmail.com,
	alexander.stein@ew.tq-group.com,
	Frank.li@nxp.com,
	ming.qian@nxp.com
Cc: conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	mchehab@kernel.org,
	hverkuil@xs4all.nl,
	linux-media@vger.kernel.org,
	imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v6 1/2] media: dt-bindings: nxp,imx8-jpeg: Add clocks entries
Date: Mon,  8 Apr 2024 15:06:53 +0300
Message-Id: <20240408120654.1196880-1-mirela.rabulea@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qXUSYvbKEfaOZTTJRnqQoa9YW5wS+g+ZS5qxBFXC/zbGnFHMnemW85d7i3ae?=
 =?us-ascii?Q?VB6qin2h00L/SoIAMUeZvYSQItIMRmnRenMlFn1I4EgwvWbO/6n9ufkOCaFY?=
 =?us-ascii?Q?o/RmP1I6t6UuHYdS5NjByX5usfR2Ck1uB+6ulPFDL4otNbXzy5UxcT+AnFFb?=
 =?us-ascii?Q?ZdhabUop55TDq7MdAJcvnJ9pYOFuQUsoHhs/0LGceKlQuoaa/wuG8l64H4B0?=
 =?us-ascii?Q?NMMLuSQRxmAkzoGtLvDuWZaPe3NCBNgp5AqztManHZg2Y9/20vYR78zouwCO?=
 =?us-ascii?Q?BwLWIZHbE3TkbcCkk0VeivxwER2YaP0TLsFSw64AA8DvP58C/cQe5/ZFvSRk?=
 =?us-ascii?Q?oZlujJEkJp/VQlxROTKdosiDj+EBw9MdfcaDw7O2jPIxUoHOF7JFnNpenC7D?=
 =?us-ascii?Q?yTZ7/uZ+zgvp5YtYF4myCJYSPFokzHW1ZO+35bWma0jZJjlyc42BkJYWFwz5?=
 =?us-ascii?Q?vS2oBn8POpZO+Cz+Y5h0f4brbJWtvaVdEMYHKJki3Qre0yBdJA6LMCvvhlCD?=
 =?us-ascii?Q?/Qbt3XruM5FY6Q6e9r9fgEutM2APyzMeSEhUFdGbAEJ7LSgCa1lPzJWVmLFh?=
 =?us-ascii?Q?yYRyYf5xET5t6TA/tJzAYTUidleLrthEBmoOTGQEa28MGxppu+KskfF5B+ru?=
 =?us-ascii?Q?qDIKgP/VsrO+mWThBRqLLp7BlGX0yUbnk9kMWiEbvgsBDCjVUSSv0TQrSZ9f?=
 =?us-ascii?Q?98oqC4d4OYSg7r5wxhikXGxN48IbcNbY3XEDcjTlEezI7icq1+bmUBY3Ar1W?=
 =?us-ascii?Q?75QrY+qDP3Zpwm82DvSm+JvWj0ZGdcFXCDzp6w9n6S1BlHJFwPIgSFOBq/Ey?=
 =?us-ascii?Q?u+S9QOQzZBcwMFCpe/nO5rdVKtwRhxe0ThbHbixI43xvitT3O7ULEtjb3S9g?=
 =?us-ascii?Q?BpB5kJnICicuXkHysoGodr8wNhIcOdM2uSGEZKv7wM5+qm7KVUGDDreRtga3?=
 =?us-ascii?Q?iwWUbehIbpE1+7r/woTd0PtBNIMfS90q+4acmf03rrkf7x35ogvC2DGhgNJg?=
 =?us-ascii?Q?h1xTmRAlEKnluTG0YCVdYuk/TTXHEsa+Mi12dcz+N0BSR+Jz/8IjZFzLpyHa?=
 =?us-ascii?Q?StRwnkBUovt3myp6gDBG4/WChnIQjbAbYJY+btN+nSlJhgBXXVS1l0K09+ux?=
 =?us-ascii?Q?cLiL12+HxltusAszECJOyMf0AvHa2J0cOqnU/L58bfqEtXJf8WFS9DZlgcAi?=
 =?us-ascii?Q?m0T4jQsFCt+QpoLuGT1QWr/DdtU6R9MsgsN9gJ6c9V69M6ZyhZrC/4mxQCpx?=
 =?us-ascii?Q?OO4tg/6vM5DI/awsb3ENZ2HbDlfx8sfHvQ1ulAySWGpFEVffkhVQhGYTCb25?=
 =?us-ascii?Q?vpvsmnimh+MY8+IshnQYEvQZNViMoJDcPmKLWun8k42gBH5CWnpae5JCboyY?=
 =?us-ascii?Q?srTj/vVUyHtHzzgqtwJGTlUOndWox0y1aAJCfnhyx37skBa9/TUFSHTKN4WI?=
 =?us-ascii?Q?oxXIEZkPkGnJwfymdPC0wK9rmZ5NsvxI0Azm1VYs7OPfQUDW03gRo4O9gFHe?=
 =?us-ascii?Q?lCHDAPN5BMlH3o0ewMvLSesWA8Vi3nI7EIY0+PcwYgKxIZ0BtXtxEr6ESlh4?=
 =?us-ascii?Q?9tV52epwYklS2Xm8gGKuFApcELQLB/Um1SsUGCL2?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17d051b5-7bea-4b0e-6d6e-08dc57c46c24
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9231.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 12:07:12.0776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZBGaZ31hr1aa6+lAFO++Xu/nNbVflqVz8tLmUlpkFACwMt6m3uLnyNOSpkx1rDtWUNKXpV47svG270IpME4kqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10416

From: Fabio Estevam <festevam@denx.de>

The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.

This also fixes the following schema warning:

imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
Changes since v5:
- Remove one extra ":" from subject (thanks Fabio!)
- Use <festevam@denx.de> address for both Author and Signed-of (Fabio's feedback)

Changes since v4:
- Remove redundant description and update subject prefix (per Krzysztof's feddback)

Changes since v3:
- Add items for clocks (per Krzysztof's feddback)
- Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
- Add "media:" to the subject
- Add Mirela's signed-off
- For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?

Changes since v2:
- Remove clock-names. (Mirela)

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml      | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..2be30c5fdc83 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -31,6 +31,11 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
+      - description: IP bus clock for register access (ipg)
+
   interrupts:
     description: |
       There are 4 slots available in the IP, which the driver may use
@@ -49,6 +54,7 @@ properties:
 required:
   - compatible
   - reg
+  - clocks
   - interrupts
   - power-domains
 
@@ -56,12 +62,15 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx8-lpcg.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/firmware/imx/rsrc.h>
 
     jpegdec: jpegdec@58400000 {
         compatible = "nxp,imx8qxp-jpgdec";
         reg = <0x58400000 0x00050000 >;
+        clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
@@ -76,6 +85,8 @@ examples:
     jpegenc: jpegenc@58450000 {
         compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
         reg = <0x58450000 0x00050000 >;
+        clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg__lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.25.1