Received-SPF: pass (google.com: domain of linux-kernel+bounces-135307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Apr 2024 13:12:21 +0100
From: Mark Brown <broonie@kernel.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Dev Jain <dev.jain@arm.com>, shuah@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Anshuman.Khandual@arm.com, suzuki.poulose@arm.com,
	ryan.roberts@arm.com, rob.herring@arm.com, Catalin.Marinas@arm.com,
	will@kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH 2/4] selftests/arm: Add signal tests
Message-ID: <f673314c-3a22-4a62-a994-ce6262593914@sirena.org.uk>
References: <20240405084410.256788-1-dev.jain@arm.com>
 <20240405084410.256788-3-dev.jain@arm.com>
 <1ce0e9c7-0bd3-47c1-893c-3ea5aa95fef5@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qZP1wOhkGWh/mDjB"
Content-Disposition: inline
In-Reply-To: <1ce0e9c7-0bd3-47c1-893c-3ea5aa95fef5@collabora.com>


--qZP1wOhkGWh/mDjB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Apr 07, 2024 at 02:28:06AM +0500, Muhammad Usama Anjum wrote:
> On 4/5/24 1:44 PM, Dev Jain wrote:

> > +	ksft_print_msg("%s :: %s\n", current->name, current->descr);
> > +	if (test_setup(current) && test_init(current)) {
> > +		test_run(current);
> > +		test_cleanup(current);
> > +	}
> > +	test_result(current);
> > +
> > +	return current->result;
> > +}

> This test isn't TAP compliant. Please make this and all tests TAP
> compilant. The 1/4 patch has example of TAP usage.

It's based on the 64 bit version of these tests which are also not TAP
compliant.  TBH I'm not sure how worthwile it is to fix at all given
that they're all single test executables anyway, if it does get fixed
it'd be good to do the arm64 ones as well.

> > +	} else {
> > +		fprintf(stdout, "==>> completed. FAIL(0)\n");
> > +		td->result = KSFT_FAIL;
> > +	}
> > +
> > +	if (force_exit)
> > +		exit(td->result);
> > +}
> > +

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

--qZP1wOhkGWh/mDjB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYT3yQACgkQJNaLcl1U
h9DmvQf+LUmNX3wMgRZgOE8R5TMnKhRAImfgyCZZmViWqco8+Iqo5qlwkW+t3Rfv
xoKtvMzrLCdMKSu1w7tUCufvf+US2FnAicHbeZkvkssDbORrrWLRm25AH4K0ooCp
du0W9s6tJJQa9+cEnPtPQEdu3SbZ9WdPdUIEVBhboyGpLLkFCNFjppiP5x6MMnE4
QNDoEMXIqwD/ycfVpEMTHmV5yz/fJGyiIeLJ/++wRthcHhXihuAA0pz0WEIuqwtU
ZMfcjNQM2EZtduAefDtoQIW8SITEifs2eLkkpzRH2cKm3sSnurQO/4Ofl74lCEkD
JXVCD3PQpvxS1v37IxUn+vXbT3mztg==
=tYml
-----END PGP SIGNATURE-----

--qZP1wOhkGWh/mDjB--