Received-SPF: pass (google.com: domain of linux-kernel+bounces-135317-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Mon, 8 Apr 2024 05:27:06 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Lee Jones <lee@kernel.org>, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: bd9576: Drop "always-running" property
Message-ID: <9e5f6d58-b72f-43ba-8280-3cd8b9b974ef@roeck-us.net>
References: <ZhPAt76yaJMersXf@fedora>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhPAt76yaJMersXf@fedora>

On Mon, Apr 08, 2024 at 01:02:31PM +0300, Matti Vaittinen wrote:
> The always-running (from linux,wdt-gpio.yaml) is abused by the BD9576
> watchdog driver. It's defined meaning is "the watchdog is always running
> and can not be stopped". The BD9576 watchdog driver has implemented it
> as "start watchdog when loading the module and prevent it from being
> stopped".
> 
> Furthermore, the implementation does not set the WDOG_HW_RUNNING when
> enabling the watchdog due to the "always-running" at module loading.
> This will end up resulting a watchdog timeout if the device is not
> opened.
> 
> The culprit was pointed out by Guenter, discussion can be found from
> https://lore.kernel.org/lkml/4fa3a64b-60fb-4e5e-8785-0f14da37eea2@roeck-us.net/
> 
> Drop the invalid "always-running" handling.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: b237bcac557a ("wdt: Support wdt on ROHM BD9576MUF and BD9573MUF")

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Guenter