Received-SPF: pass (google.com: domain of linux-kernel+bounces-135320-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e0179895-5d06-4c47-98f2-635175a05cf7@oracle.com>
Date: Mon, 8 Apr 2024 13:30:07 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND] scsi: megaraid_sas: make module parameter
 scmd_timeout writable
To: Lei Chen <lei.chen@smartx.com>,
        Kashyap Desai
 <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
        Chandrakanth patil <chandrakanth.patil@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240408100505.1732370-1-lei.chen@smartx.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240408100505.1732370-1-lei.chen@smartx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NWtDcnNPMlJTNFAreWExaG43WllFNjZXMTRvWktocERucm9SQ0xBaWlmWERU?=
 =?utf-8?B?OGRBc28xMXpqc3VDUHlPbTZTeDNQSHp3bFBIbXlLTVJCb2tCbnJoR3pHajJZ?=
 =?utf-8?B?QldZZlNrQS9MaWo5YnFGQm5TS3dtZS9DaVJZMDdFdytrbEFLUTNtZkNoc2Nv?=
 =?utf-8?B?dS9JTTRianJPUG56OHJDT0RZZEk3NTluL2hLa3dTUEJ4NXVwUzh3NDJHc09a?=
 =?utf-8?B?TjZOWUhHQW5Nd3hnRG5zMjFYNHVKY3ZFRFYyZ3FkY3pPVklMVUtZdlBzWUY5?=
 =?utf-8?B?ZzBCb3l3bGFKTlJLcWVxV0dVWERnT0pUaExCbCtUejE0UmFsMzk4TVAzYWRV?=
 =?utf-8?B?Y3ZrSVUwKzQwbmNDVHgyMHk2Y013RGdidTIvYjFBWTYxd1pmdmNxeE1xVE5P?=
 =?utf-8?B?L2toK2hBMFNTS05DaXE4R2Z3djMzUXBaWXpWdHRpZmc4cXVDUEMwa3NIZTNM?=
 =?utf-8?B?ZUlKMm9vek1nb1F5THdtYkx6ZE5wc3FadE9IT1JUOVlveGN4aDFpN1hBUXBa?=
 =?utf-8?B?aDYzM1NkVURTa0JhckZpWXR2QTlJZVpscjdBVWxPbFBPOHBUZjlhTFVjaElC?=
 =?utf-8?B?VitWckhkYXFGYnFOODF1OENwaGxxSE1mVkluaWdGR3RQQzM1UWxyeSttUGJZ?=
 =?utf-8?B?bUdIaVMzMEFXVWhLVmc0MmhIU00yVGg1YWFoZEdPMkgrSkxESnJwaXlmYlpK?=
 =?utf-8?B?TDE5Y2NhaDIrQkZDMkxUOHduQks0MytJNjBrWjBJODZtT0Y0QmVvK25Ca2N2?=
 =?utf-8?B?ZDBYaStBRDN2Q0t2TFNLYlBubFVHTGZLZUtZMitHT09oc00ybDZOSjdJMHhk?=
 =?utf-8?B?T2NGdDVRWXZMZWV6cHhnbm5KV2xXQVl5NVRVQ0xHWjFMTGttZmNGalU5cWpK?=
 =?utf-8?B?M0lHRHpjMFBiOHhKZ1JyVVRBSlZUbGFWWjl4c3dlTnMvQm1OdGJlUWZYYzl5?=
 =?utf-8?B?NDlCUEdiUm15dm9qbDFQN1ZRME92ZVJwOXVJaDEzZnpPZjdjUVZselVkYzVr?=
 =?utf-8?B?MWFTR24xQmJ0WFlxbGlLWW9GZ3ZIU0NUUTJvalN1djY0ZXJST1VkYnFkVkc1?=
 =?utf-8?B?N05PclVMcTJqTUFMcHZWSlZPUW5iSzhwTjZvM2RuLzh1aWEySXFzcFNSY1NU?=
 =?utf-8?B?Y1pIdC8zUFZTT2xMRitjdTNUR0VQTWNQTEdObnFPWTdkSThYUjVwU2taZkdK?=
 =?utf-8?B?N1pLSXJaazBPdGhlUHJqeldnNU9GekRKcnZXdnpBVXF1d2tMbjJDcldEWHd6?=
 =?utf-8?B?dmtrMEUvNXREai9rTnB1OXlsbE1SZEhKVUFCY0dUaUYxYytWY0VnWEJMNEJ1?=
 =?utf-8?B?d2t3ZUdlVXRVeGhwU3hjQnczMUtyMnU5Vkp0Vm9haHA4VzZFYk80SGRzYWlX?=
 =?utf-8?B?TTVQVllraUNRaVZUeGhsVTVDbldvNGlBajRhWWcxT2tiR1VZbDNmMTBtcmZU?=
 =?utf-8?B?Y3pwTXBjNEdraEtvVnNKVmNmZlFkYVMvdndsbUNNUjNDRVJsbFQ1Y3hWMFRo?=
 =?utf-8?B?YWk5ekh0M1p4bzBaSkVsNVhCVzB1cTNNc1F4ZXZid1RrTmJyVTZJZHI4OE45?=
 =?utf-8?B?aHp0VllmLzlXS2N4TjhKcWF6RHVzMVQ2YldnWWJCUytBV3Bpekd3WDFMYTVs?=
 =?utf-8?B?aWdzMUpPcitaaERFZjEwdkZxMjFFc3NQM25jQkRaZ01TMzdsam43eUp5Slcx?=
 =?utf-8?B?UTRHRHRZdTZCNDZ5cll0VnI2Tzc5azBMcCt6MkRHQWs3MkRMWnN2QWR6bk9r?=
 =?utf-8?B?ZUw0YjhRMFJOeDBhY1FCUVc2ZmJjRTdqYkpwRGRUSGQ4NFdhRURXSnJjaTNw?=
 =?utf-8?B?TFZXTVREaENpeFFYSGU0Qng1ODQyNVVlWHhjK0k0di9QYzd0UUFzd0ZOTU1V?=
 =?utf-8?B?WHVNUll5TjdhUmtqVnBGbGw4NFRKSTEwaWRabmNrQkdtQXBNL1ppWi9tN1pi?=
 =?utf-8?B?ZnVlWFp4RHkwS01QQW80YVdibDBSeENEeWh2WnRKUUl4ZEJtckc3cnFKTlBI?=
 =?utf-8?B?TmFMZytLNG1VSXpZcktjbzc5TGFaaERBNXFaY3Jia1ZTbWpKQUJuS0lIclpP?=
 =?utf-8?B?WXpwM2JlMzRYQ1JtYzh0TXNMYzJaK0NIR2Rxd1ZrUzVEZ0p0ekNudmNMT041?=
 =?utf-8?Q?1WvYR5GP+VQpFdDZmeLFOWHzK?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	66kBS+shDMdQmLba4bXAr53JMDIeZ630wgyfxMWurxdDhUBaoMvfjBBTIl3Wmgz0MutfE7fAj5yb3jeIZskB7SlT10Sqi6WgEWpK2rrKz+3Jsti7fnAuR68NxR9jroYOD7//MbnqyrqiZINt7CzAYDEs0Tyd4WyNyKPYyvXb1wf2Y7vYiHFSopygGn35phsifEOjDr4c3sna3kzyfdAWVRIpS7cFO5MdtcLtULx+lKiTZBaFZLJprSUQXgIh87YInL+eKD+asOegnuvP50eEz3Sw5Ji8sCKfY6U9oQ/twcqKDvPPQ0iBsNZtApQEDHLz3aBrKFBYIRfbkGxcYRCFz9KO5hXoOKBB6gEGCEx5ikpuJvW6uby1fpmkyL3cOE1s+SBk5Abm2EKnQPFvSzwXnodjI0P0YsWAlm8Tr5Qvtsyj0t0MNuRkqLkiaEYxckgUma5WmT2eka1Jv0hmpL/BL+50upNc18Do26sLKVcqdJcJjG97m1R3n5avJALYy243HMRTAXzbQ1VlRo/H2un/UqkSJy1TIt27ayRH5e532zIcOg0r+HNNqV60QNvOn5wQIbt91ByZdqrn9TpUffqqvOEKddDS+9204ioGZ5V8KRg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e052df7f-0603-4f62-1092-08dc57c7a289
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 12:30:11.9598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i8Z/s4RGARhYobvc/ZNoigrg21BVPXF/ITj97e3gjWNNVk+pXgcENjkfNtplj+fGKLtmI9Fujq80FGIFqE8T/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4225
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-08_11,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404080095
X-Proofpoint-GUID: r_rWiY-f3QBVavXfY2akCBj2DG3XjWes
X-Proofpoint-ORIG-GUID: r_rWiY-f3QBVavXfY2akCBj2DG3XjWes

On 08/04/2024 11:05, Lei Chen wrote:
> When an scmd times out, block layer calls megasas_reset_timer to
> make further decisions. scmd_timeout indicates when an scmd is really
> timed-out.

What does really timed-out mean?

> If we want to make this process more fast, we can decrease
> this value. This patch allows users to change this value in run-time.
> 
> Signed-off-by: Lei Chen <lei.chen@smartx.com>
> ---
>   drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 3d4f13da1ae8..2a165e5dc7a3 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -91,7 +91,7 @@ module_param(dual_qdepth_disable, int, 0444);
>   MODULE_PARM_DESC(dual_qdepth_disable, "Disable dual queue depth feature. Default: 0");
>   
>   static unsigned int scmd_timeout = MEGASAS_DEFAULT_CMD_TIMEOUT;
> -module_param(scmd_timeout, int, 0444);
> +module_param(scmd_timeout, int, 0644);
>   MODULE_PARM_DESC(scmd_timeout, "scsi command timeout (10-90s), default 90s. See megasas_reset_timer.");
>   
>   int perf_mode = -1;

I don't know why megaraid_sas has special handling here (and bypasses 
SCSI midlayer).

If the host is overloaded and you get a time-out as a command simply 
could not be handled in time, can you alternatively try reducing the 
scsi device queue depth?