Received-SPF: pass (google.com: domain of linux-kernel+bounces-135382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 8 Apr 2024 16:00:24 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: Konstantin Taranov <kotaranov@linux.microsoft.com>,
	"sharmaajay@microsoft.com" <sharmaajay@microsoft.com>,
	Long Li <longli@microsoft.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH rdma-next v4 0/4] Define and use mana
 queues for CQs and WQs
Message-ID: <20240408130024.GG8764@unreal>
References: <1712567646-5247-1-git-send-email-kotaranov@linux.microsoft.com>
 <20240408112533.GF8764@unreal>
 <PAXPR83MB05570E9EE9853B2E6F66703DB4002@PAXPR83MB0557.EURPRD83.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PAXPR83MB05570E9EE9853B2E6F66703DB4002@PAXPR83MB0557.EURPRD83.prod.outlook.com>

On Mon, Apr 08, 2024 at 12:50:12PM +0000, Konstantin Taranov wrote:
> > From: Leon Romanovsky <leon@kernel.org>
> > On Mon, Apr 08, 2024 at 02:14:02AM -0700, Konstantin Taranov wrote:
> > > From: Konstantin Taranov <kotaranov@microsoft.com>
> > >
> > > This patch series aims to reduce code duplication by introducing a
> > > notion of mana ib queues and corresponding helpers to create and
> > > destroy them.
> > >
> > > v3->v4:
> > > * Removed debug prints in patches, as asked by Leon
> > >
> > > v2->v3:
> > > * [in 4/4] Do not define an additional struct for a raw qp
> > >
> > > v1->v2:
> > > * [in 1/4] Added a comment about the ignored return value
> > > * [in 2/4] Replaced RDMA:mana_ib to RDMA/mana_ib in the subject
> > > * [in 4/4] Renamed mana_ib_raw_qp to mana_ib_raw_sq
> > >
> > > Konstantin Taranov (4):
> > >   RDMA/mana_ib: Introduce helpers to create and destroy mana queues
> > >   RDMA/mana_ib: Use struct mana_ib_queue for CQs
> > >   RDMA/mana_ib: Use struct mana_ib_queue for WQs
> > >   RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs
> > >
> > >  drivers/infiniband/hw/mana/cq.c      | 52 +++-------------
> > >  drivers/infiniband/hw/mana/main.c    | 39 ++++++++++++
> > >  drivers/infiniband/hw/mana/mana_ib.h | 26 ++++----
> > >  drivers/infiniband/hw/mana/qp.c      | 93 +++++++++-------------------
> > >  drivers/infiniband/hw/mana/wq.c      | 33 ++--------
> > >  5 files changed, 96 insertions(+), 147 deletions(-)
> > 
> > It doesn't apply.
> > 
> 
> I guess there was some mis-synchronisation between us.
> I see that you have already applied the patch 6 days ago:
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/
> 
> I am sorry for sending a newer version after the patch has been applied.
> I have not checked this before sending.
> I can take care of useless debug prints in a future cleanup patch.

Please rebase your series, and resend.

Thanks