Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1357247lqe; Mon, 8 Apr 2024 06:53:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVAwNsipEkYEClE8bxPPyRZ5dpmAiof1kxYBMU0/gbOgHTObMjOjpciqDS86AD+2+Brqbt9wPlhy30YSqflO6cBsX3K871aGiPCd+SNmg== X-Google-Smtp-Source: AGHT+IGCPpBAHfMR7rnKsK/knlH78Yq2GKZo2frgzm8AnXsKCFtVkn1deAILWoDLkAd5+t3ek/rr X-Received: by 2002:a05:6358:7a2:b0:186:1d2a:a467 with SMTP id n34-20020a05635807a200b001861d2aa467mr4349676rwj.22.1712584389052; Mon, 08 Apr 2024 06:53:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712584388; cv=pass; d=google.com; s=arc-20160816; b=hzMmtRWtRns+UcjOGsD3NwY2gJwBOG8cQUKPxlGlEg+uekyM6AJjEjjXOVnLRfxKDS rrbh8IvS9mhlj75RpxRYDAWvqn2/EK5Kp1QGji3IaQx+IiEo3yzhyaNTo1nWZCCdDI9V LoJwOqMKW+HztMG0mU+3cTF5hS7wYP27pCQVZIHjj7yayiFvynN+m31VZjTVur47q2pM I/PXO1Nt0HnsELxCKLuwCh3MJv4jik67w60vqrbrXGKRK+4LEey+O0IP34PFd5V9o7+x t2PrLhhgO5O9lzMUiwDvcPuKf5bx+pOmIX2hKlFMXZevJZ7G0zSrv/EeZApvgqwjedcz iBjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=K7FDlgDFtv1z2zH4nhKjLAFv5il73kxo5OmsETPLf8g=; fh=938viA9k1ccK6J5qK5wK1J5SmYAIRtzf5Iyc8Ouj03s=; b=qi/a8E3NH1BJuBmkT4zJxbFSPPMAH/2xvzPp/e1w1ev3dXLlky/VFv+/D/BEbPk8GT nMROZY7fD5HiKImI9hrJBih4KqnuDqCcYGWFAnEFrIe+zpKzybaXaY/7CYfEDY9+7UIm uroza8a9ATAddvW/3OMDWkx1MGBptG9ZNKO/2RE2SFf6TlzoNF6OLwtt+e1WdLF92TZy QKvUwcvg97+b2ilderkOmVc35kI+Xn88lS9+kxQLDbcr1ELoMGkWVJxJJGw2cPWmQ8eh eBAgZhqJ/H+4h3PWf1p8Xhkixb5BUdTNOV/EdXy9notO9mCAuDTpYQulwhpPMXGynZsi xSRw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=Id7iXKTX; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-135428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135428-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m3-20020a63ed43000000b005f3e0556e31si6628999pgk.863.2024.04.08.06.53.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 06:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=Id7iXKTX; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-135428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135428-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 11EC9B28E31 for ; Mon, 8 Apr 2024 13:24:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DC0B86126; Mon, 8 Apr 2024 13:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="Id7iXKTX" Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1140C81751; Mon, 8 Apr 2024 13:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712582416; cv=none; b=u80iUl325B3IcBtIvB9cmCB8g1BkO7ZxEfVxY/r2wGe6u9qOT0RQpv/8PhKa/Jypqc3O+joJEG0wuHafXCmHQjuNV26kJpf9VN2nRRoftwL7+LSk2Ciz22Nl61dYusYixe468mIaGt1Kng/dQTE8nDrrvtL9zM8mhVtQb9zaHf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712582416; c=relaxed/simple; bh=74BQp+QZEt52EbEIHiebD1Hx7WP7XpuqHyEEfMZoggA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gfxurNQcGaDSxDETZdmM8HZK4+DTUwUyEd+/EW7tHRyulKD2czLnxuQgV3ttos3/IRCLxxtyKnbeFGyAqqZnEc5GW0OzsD53SN+IW37AW8Xp9B1gZTuJaEzzJuSdAp9A7xkX9AdjvzSNLJiIOAATEnuW77dAOHrxOt2U+IJuomI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=Id7iXKTX; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 8C328600A9; Mon, 8 Apr 2024 13:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1712581838; bh=74BQp+QZEt52EbEIHiebD1Hx7WP7XpuqHyEEfMZoggA=; h=From:To:Cc:Subject:Date:From; b=Id7iXKTXfwMFB8wguFS5+yCiChwgmKuJe4GqKSjloYg8oINLF/k7S40xH9N64xQ3r RS0jY7bxsCjUd5AFKhE0NcwXdfI4uARQ+/P7JQ1FgGW1IKOTNhkgT8mi51oUxr+cdA Day8I6efxwUC2JqC537nZ/gWO4EC/iFux7EJEezkfD54Tscy2WkAzH1dMQQ9xD+YCR wCdVnogKmFEe5g1eUE3E0oXfStpGN2tIYLlTv+m66WbywLP8zd2CxAiECePa/mVr6m QS5lhsELKBuL8YSQjW3w/xfv3VXH1ROsO5YM24shbFalicbPFgA/o4aSX+NVjIdJ7y IHg50Iyv9c8yQ== Received: by x201s (Postfix, from userid 1000) id 21A71201CE7; Mon, 08 Apr 2024 13:09:31 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Louis Peens , Taras Chornyi , Woojung Huh , UNGLinuxDriver@microchip.com Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yanguo Li , oss-drivers@corigine.com, Andrew Lunn , Florian Fainelli , Vladimir Oltean , Edward Cree , Jamal Hadi Salim , Cong Wang , Jiri Pirko Subject: [PATCH net-next 0/6] flower: validate control flags Date: Mon, 8 Apr 2024 13:09:18 +0000 Message-ID: <20240408130927.78594-1-ast@fiberby.net> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I have reviewed the flower control flags code. In all, but one (sfc), the flags field wasn't checked properly for unsupported flags. In this series I have only included a single example user for each helper function. Once the helpers are in, I will submit patches for all other drivers implementing flower. After which there will be: - 6 drivers using flow_rule_no_unsupp_control_flags - 8 drivers using flow_rule_no_control_flags - 11 drivers using flow_rule_match_no_control_flags Asbjørn Sloth Tønnesen (6): flow_offload: add flow_rule_no_unsupp_control_flags() nfp: flower: fix check for unsupported control flags flow_offload: add flow_rule_no_control_flags() net: prestera: flower: validate control flags flow_offload: add flow_rule_match_no_control_flags() net: dsa: microchip: ksz9477: flower: validate control flags drivers/net/dsa/microchip/ksz9477_tc_flower.c | 3 + .../marvell/prestera/prestera_flower.c | 4 ++ .../ethernet/netronome/nfp/flower/offload.c | 6 +- include/net/flow_offload.h | 55 +++++++++++++++++++ 4 files changed, 65 insertions(+), 3 deletions(-) -- 2.43.0