Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1359010lqe; Mon, 8 Apr 2024 06:56:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWIRuKy3uPDgfbeNfqErCfGYAApmanNv1nZ3ox8cLkl8lA7TPz21lbbEKBwfQlV4Tg3XdWWZArx23i/Oz21qs0wewNsy3HdIzgah3umEw== X-Google-Smtp-Source: AGHT+IETvWQYT8p95tMbiMz9PpFqqce63twmE6puir+ezT6Y1SRRwiCyv78nT78CcMrY3o0Ru/aU X-Received: by 2002:a50:9515:0:b0:56e:5735:db2b with SMTP id u21-20020a509515000000b0056e5735db2bmr2616580eda.29.1712584591282; Mon, 08 Apr 2024 06:56:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712584591; cv=pass; d=google.com; s=arc-20160816; b=0gvkZVgvQky+ZBehiw8c+KGjtFGYnp+7eNigba6KHX3rv9qZaI176IgaA+Ln9DoO6+ rbguoHflLPezzIXnJCAANApAJ2JyqGT6CEnoPOLu0DK0nBxb98yEQNXL+LvtFdR36EFp PqgKH9ZHjRGdgZROOJti2mv6XTGy3hdGd4YTsfx6+T3L72fnf/lYindigw9JzxPzA8Wm b7duN3bG4gNwk114F43qtlcfjGszypuoJReoFPnJAw6+ogLRSnvnNCnxVWEAX453EaEM UI1nxKrXfCp5PwKSiH1iWd2bMyYyuZ+sucd5xnlGR4U9OfqLNifrR1+iFPS3qEJK0A7+ AprQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Yaboxrr0xBrlFJeMMkN45wRMToD5DSmzhJ3EmTDqQe4=; fh=49GrrO/H3LiGmymuFnNd59pBYHHWBS2xk/6Ejg0rn8E=; b=PrAgwPA+iw6CbAO8iuysBqKx36Dggw2rEwQSoNIb8LNfRojBMXihReveBQKf4uc331 bC/d/5Dgus3zV5b6vOLv2CwwgAwvPnZ5RXyR8OLYsYuX4EMTijFgY04Srd4vWxTZl0Q5 kRLgB7p8Rtem8rHF/rJ5kFNvSS7Kkvg9MmViaNphCQ0tTOb4+IYXMzoqG67hXH0/WUTb AtWKwA5jM5fw4IfZWouk65zcFZEBl7vxry+XjZr4YOlE1BKF53fGEU+PlvneLAA7IZhs xNr+wtIEPNG+87xahvRerV9uepEeHwT/W4PMU6d5yNHgFCohmIbVI902AwtKgEvI0Xhs N7SQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6A9ytY1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135470-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m21-20020a50d7d5000000b0056dfbd9a57fsi3734687edj.116.2024.04.08.06.56.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 06:56:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6A9ytY1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135470-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 082601F238D0 for ; Mon, 8 Apr 2024 13:56:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 54E3F7C08B; Mon, 8 Apr 2024 13:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l6A9ytY1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B53D79955; Mon, 8 Apr 2024 13:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712584583; cv=none; b=fGXAPDkehakMsnRdB5mpf+H9FFzRiuLlQZihGF/3yw4n/AosHluodIBt1QWBCSAo39NY6I9mitn69Tfu6NILrGNNOBRIe1jp8CvNCnyfbDGWKk3u2FzPnBqkbIMuRuI9BJGo+ifC7YJkbtqQXShPdTv8X64NLZlb5h7u9eUSOhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712584583; c=relaxed/simple; bh=aLYcoDPwUFsUit2u1j/5yFGuRmxNoZ15e8nXxxHoW/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cCHKCCpvsTQ7e1RRkGW0nS//tcHOJ/cSvsDugVvS0ZUI8gDctvXUXj9EEYezunKXqlYk+uJIw4Jh3JP/xSPkBDZKM3Nq2ksM1zbzhJlHBMYObFMgqjyVim5Yf2dExnQilsN/17D2iEm99I7zI7ypHDMBojzu4L6eu7saeowtJtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l6A9ytY1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEFDAC43390; Mon, 8 Apr 2024 13:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712584583; bh=aLYcoDPwUFsUit2u1j/5yFGuRmxNoZ15e8nXxxHoW/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l6A9ytY1NmhMim7uIJdEIzkWs7DHtbd13oUu3zs5nbmfyBov9+e02zrZOrTgDrukp vXsttbjZUYCSXBxeqBNzEsA4GQW8gMUlOIaVO2FFopg1qVGAyFGHaOH6+77wKc1HDT 223KMONzV+w95f6nZbwmQm9TzpXO153FK5zBap3xbedphtY0H1NNEepROtSAS8QqfJ YRxN1fPzgoRh7FWdC02y966CaTv0OHP8w9eQplZEUd7iOXOdsrhuWYh3kib5QVhqnJ oL/a4vGIAkzUmCi1HOH7jnsNGlaqm8VjOk/KFe2Uycr+tR0QXSelf1qjWnLEoWiQ0d ykr9Qe0m9L83g== Date: Mon, 8 Apr 2024 10:56:22 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ian Rogers , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: Re: [PATCHSET 0/9] perf annotate: More memory footprint reduction Message-ID: References: <20240404175716.1225482-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404175716.1225482-1-namhyung@kernel.org> On Thu, Apr 04, 2024 at 10:57:07AM -0700, Namhyung Kim wrote: > Hello, > > This work is continuation of the previous work to reduce the memory > usage in symbol and annotation structures. Basically I moved some > fields in the annotation which consume spaces in the struct symbol > which is allocated regardless if the symbol has a sample or not when > annotation is enabled. > > With this change applied, the struct annotation only has two members - > annotated_source and annotated_branch. The next step would be to > remove the struct annotation and to have a hash table from symbol to > each annotated struct directly. > > No function changes intended. > > The code is available at perf/annotate-diet-v3 branch in > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, applied to perf-tools-next, - Arnaldo