Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1373848lqe; Mon, 8 Apr 2024 07:16:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWRi+/QQRJGc+PvJP85tsxhuJi5I2JEEuPlSPqPxkI8sVvn0V9eensUZPKtnJVvQ16oV9izacIReAilO9Q0NiZhI0nwGrHs49RDOS3eTA== X-Google-Smtp-Source: AGHT+IG3NPek1DQEwQaCQ99Ie/Um7iUTHoGR5ibzJiehWLWm7bCbm47AcGWlWBwIyeVPZGf0zuFU X-Received: by 2002:a05:6a00:3d0e:b0:6ed:416d:e9e with SMTP id lo14-20020a056a003d0e00b006ed416d0e9emr3777232pfb.16.1712585771533; Mon, 08 Apr 2024 07:16:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712585771; cv=pass; d=google.com; s=arc-20160816; b=v2/yjklQw35CroTtbWRsifnXQsRF1ZW767S40XEdNlrivwDcvmLQRsY6ukfYm7Mj0l ITbZCCStsrR8EdnZ991kcJUiFBRoNDGpzMH6jS+eaUf65OIwsJ5sJBzRII5tQqvdGEix 2QXMbYXkCbPX71WKZ+v2ha6+uJd5/6tcFmswlTEiJobR+Uv/G0Xw4bRXDFwFmzb/4HvR beYASsTgtrw5J6uv2vIXLd0k+N3s3CQveNJgvaKtAX9TFW8uxdLHuS6AnF+s8ymXCRGv eJtzrpBBV1GzXUIbBu8t+kqv428cdkiomlYLZnvtmWjoyPo0QAWvl7Gbypt5PNrEN0CC LnzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9l9Lj4Wu77sWORiCCRT7DqYxfPwrkBS5B7NipZG6hn0=; fh=QPHjG65RNQ4P0Lo50ADGdMc5jntiupTtyaImif19M7E=; b=q1/HQo3w3cAq6kYvV5XksK1ldJpP7juGBF4ShG+ARO6KA9PG5rEqZcOXP4HALsj2fP KryqQYT80bgV+7tXwLKu6lPQz90AffoIuvLWv0ciBWK2cp2OccllEtu+oFeVz4t78yFf fIKP8P8kh1q8pHGZWEsnNeDr8+pVxFtF/aPLCL4RZs+3JPE0I9LDJjSRHJ31K6grA5Tz Q8X87oTOJhX93fXFeZwe/yMTU4Kv9HVcCRWZiYv4vV/4KcwQr5xhW1qtU6hUhPBrDfJx AeAUqVCojFQ0wNjKVBQDb9eJn+kwVQGLbPmz/aatnqaVrZGg+cHsfGcJwPHL3nlEkEyq t20Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="agSuONB/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135491-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w3-20020aa78583000000b006eaa702b0dcsi6375824pfn.349.2024.04.08.07.16.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 07:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="agSuONB/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135491-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 09DED28512F for ; Mon, 8 Apr 2024 14:15:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F0FA85C44; Mon, 8 Apr 2024 14:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="agSuONB/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 556128564E; Mon, 8 Apr 2024 14:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585738; cv=none; b=aR/qyWSZfb2AWsPnnZn8NWs2crlV7jOyt61LVLq+LLNhrB1cgO3CwFYYBe6svYbkz4/+IovoHqGJafXbLqJsEK7wdpuEw3hCpCm4ohxy570kCrkD/i+9+QJ/zeThCMbzUO+fp1OnRVf9fEeDS+S+vM++xxfUvEcagWgocVtnI34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585738; c=relaxed/simple; bh=uGAyf8hbUzFZhn6hO+6/TbFvwKdd+ftBukqq+4D8pHY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pAENubTFajeuNniX+qZRiNisbbeKqQ91BcPc3I9DMZphulNBVnf1JhI0yvb6BRXLgxdiN72OckzTP3AhKTtdYe/t4FReZwretgF91KT1++PxlYSqYS/Cu+6tt4CED/Ir6PSNF1VqTeGFBBa28CcclyQdTFEdpTpKxbg50xIBNJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=agSuONB/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EE48C433F1; Mon, 8 Apr 2024 14:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712585738; bh=uGAyf8hbUzFZhn6hO+6/TbFvwKdd+ftBukqq+4D8pHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=agSuONB/gh4uhRRAvIAMCWT5aX0LpJfs7T7ty2R92xMfaMzyEHDq6Z7uPUOGMweOv xL+t/Gds9o+MDffDujhKtft/1wftFS5tf9FAriGJXHWyVXMckgSIUD1r2ruZ5/RfLj daD/VigkmJmPvtwsF2SvRVgpKy4hdFOADWBG4rcoJcB97qT6mhHTDUWz3kDeT1lsDP uEWq6PwJ7xi/CZlp/j/SD3X6Z1B/9Edz+aLiCCN7ZUsoe1OA/kmHRLCHZrU4JuwUpy fIiI0HstYvm+RlwvSKPdYNSLU2g0Uhjb9aqGfJ7tSB/nN32bH/hA3tvB+pGBKLI7Fx GXy1AxdpaTBjA== Date: Mon, 8 Apr 2024 11:15:34 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: Re: [PATCH 0/4] perf annotate-data: small random fixes and updates Message-ID: References: <20240405211800.1412920-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 05, 2024 at 05:02:20PM -0700, Ian Rogers wrote: > On Fri, Apr 5, 2024 at 2:18 PM Namhyung Kim wrote: > > I found some problems in the data type profiling with perf annotate. > > The patch 1 should go to perf-tools and others can go to perf-tools-next. > > Namhyung Kim (4): > > perf annotate: Make sure to call symbol__annotate2() in TUI > > perf annotate-data: Fix global variable lookup > > perf annotate-data: Do not delete non-asm lines > > perf annotate: Get rid of symbol__ensure_annotate() > > Reviewed-by: Ian Rogers Applied 2-4 to perf-tools-next, Thanks, - Arnaldo