Received-SPF: pass (google.com: domain of linux-kernel+bounces-135494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 8 Apr 2024 15:16:29 +0100
From: Mark Brown <broonie@kernel.org>
To: =?iso-8859-1?Q?Th=E9o?= Lebrun <theo.lebrun@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vaishnav Achath <vaishnav.a@ti.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh@kernel.org>, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v2 08/11] spi: cadence-qspi: add early busywait to
 cqspi_wait_for_bit()
Message-ID: <1f7087ad-824e-47fe-9953-ed5152c8f18f@sirena.org.uk>
References: <20240405-cdns-qspi-mbly-v2-0-956679866d6d@bootlin.com>
 <20240405-cdns-qspi-mbly-v2-8-956679866d6d@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M+xzRGuQWIs7ztiG"
Content-Disposition: inline
In-Reply-To: <20240405-cdns-qspi-mbly-v2-8-956679866d6d@bootlin.com>


--M+xzRGuQWIs7ztiG
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 05, 2024 at 05:02:18PM +0200, Th=E9o Lebrun wrote:

> If the CQSPI_BUSYWAIT_EARLY quirk flag is on, call
> readl_relaxed_poll_timeout() with no sleep at the start of
> cqspi_wait_for_bit(). If its short timeout expires, a sleeping
> readl_relaxed_poll_timeout() call takes the relay.
>=20
> Behavior is hidden behind a quirk flag to keep the previous behavior the
> same on all platforms.
>=20
> The reason is to avoid hrtimer interrupts on the system. All read
> operations take less than 100=B5s.

Why would this be platform specific, this seems like a very standard
optimisation technique?

--M+xzRGuQWIs7ztiG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYT/DwACgkQJNaLcl1U
h9ANxgf+Mzi0qALbTQtJ/4YLKSo7Rz0O7xI80u/4JR5cdbLhKIR9wyfq/zYpC1ou
GugX7jgji68/5rmgbPrXCgMFmfmy2h/EjN3t5sEUIMjtHum2Wxo7AMvAE3l4SPvw
MsrJvoxg975ApHEXE9CZlzKHaof5nQ7xK4j2tyqCK/1TkUh2zXKFhG0uB/AnIQJg
jqC0+lTHXviEqqjqx0CM5wcmuzkx19rxpVNsa6wgVy1z9Iy2BF+gR9c04CLiA438
Og1GynxgfKht138oDVWMEyx9YnMW4DcN8Z8VG82u52z/G/2fUFVGYuy77gNrt9f5
nbsZFB8X1UwZHCYA+oX1w5wz/xt4nQ==
=/C1O
-----END PGP SIGNATURE-----

--M+xzRGuQWIs7ztiG--