Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1376857lqe; Mon, 8 Apr 2024 07:20:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXdRKUmMYWcRGZDQYEXz1t/5l9kimklRqkBxMrdPDW5xkzorqhy8WcjM1BWP3D9zc6Q4f6QY3HyC8ynJN/7IsUzlYzsWPuBc0yiJ1hZxw== X-Google-Smtp-Source: AGHT+IFYSws39+xeEWGzjeLbW3fP4Nyn1kGdixc4g8uHQov6F1RbNgE31Hpkd6GLcmgv8iJpQztd X-Received: by 2002:a17:902:c405:b0:1e1:1791:3681 with SMTP id k5-20020a170902c40500b001e117913681mr9633334plk.61.1712586030568; Mon, 08 Apr 2024 07:20:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712586030; cv=pass; d=google.com; s=arc-20160816; b=Hg35EJEkC1ws09xMjgZxHCgGMfupUNLd6wW1FoLUD15+E5DlcOcREdZSQ4NJEBTAze 6RA/HgvFdtPNYZz2n/oGGGLJAqNg5wdrugRvKh703OUgquogy8VfrW0Ntpe+6Dg+8jug jrobCkJYOPjJmm8v4CQSoHvfpx6T+PiB2zzk+i9VsENlijgvsNv3xY8keSjMOcTNg0St 7FtUSMAtdSIx6qIZ6drAy0I0sx3T3XHBEnnfaNG997d7lZ7cnXq6iyUMTGqMX0nPxw7m q7xm7vrMtskEERSJbK3xnCMoKsetdJjO1z1k3sO0HcM+kcBJs1Tecv58E1tKUZr5EvoA mKiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Gm4DuGUpjq/QB7Sf104ryucHSpv0+jhK2qvKLuXC7P0=; fh=hHOy6RY6C7fo1A3lLEeiFy89TxxcBnrSAUObSV9A+ls=; b=AO8Kv/W+m1djDKo6hosX7++/YsLVCXabY+9W9aNCYvnG252oWuzjCe8YVDMAW0fFRn /xO1g9Ey4r6IuTXBkwU8J2BGsBaqFi1xhT6ESB5jNkxn1LpwIdyAhjLt9T5rEdz32QcJ 5bxve4olOmEaJ0ssaBGsZurf0FqHr7CvatBJpxYcNKC0bb1sTW17GGio3ZlRw27MtKXO ISzWFqzARTQFF7I9y7eI+6Iky9Q9/gaZMeeaWiYAVIcAwBrDYLZKfz82ohsKRY49BhM5 NqfJa2BNanhSF1yoLDuY5uvjnjKN3tVPL2mF4kj35q3lShBibjARjqPssfqHU0Xzy6mD OPFg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YuAljUOw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135505-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t12-20020a17090340cc00b001e3facb337bsi3012204pld.347.2024.04.08.07.20.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 07:20:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YuAljUOw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-135505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135505-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3854A2816FD for ; Mon, 8 Apr 2024 14:20:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73EDE12E1EE; Mon, 8 Apr 2024 14:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YuAljUOw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F54912BEA0; Mon, 8 Apr 2024 14:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585947; cv=none; b=TPgrV0ujlvEYoG3oqg+ZzPvE0WEAj/zSAq4eCTqCOXyCIL7HSbg9ICtRnK31/vF/SlTZJZllGkiYh5mrSUaNVbTNFDLXLbVMzMW6rVqa3ns2+vPzMGBAR/tRxky2KOFSR+bnIHNoej7VTB9Af8Xen70QFAix0WxWIZZSxw+L7Ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585947; c=relaxed/simple; bh=fCohwsfER8OLWfZl6LReGaQxXONj5RyinO1IgQBzs1s=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LeIP1ZqvXdyUa/hZ7Do6hmea6oYfk45uRxEGl2DzWCH6bE2/aoBcsZMqICV4PbPOIIt/zF1EcOvsAJBKL5iiDn3J2T7HweO4YOkW9Y4A03aTB3U+84vm2KXGM/Kw9GLPk1ZF9udv/SpoBV8LYikec5YsOxV2euXrkf2WKdVXLPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YuAljUOw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB69EC41606; Mon, 8 Apr 2024 14:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712585947; bh=fCohwsfER8OLWfZl6LReGaQxXONj5RyinO1IgQBzs1s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YuAljUOw0VGTL6reKBytSgl0plRNv+TSjZRfD3ZKuqxOSYkzoXC5WrRi5cw+S+B+M D4nwox90lYEDvOC2kltYpVUw1dnHyUlGf0Vz9gQ+VSZQ6UY2PlnOXYtJXUxFO+DpNk 45njopcwprSMB+gVFh0LkX6VN8kgR0mIB2295lbbV+KLETQgy8jgbddtYnqL+2OrFg vSHyTr4CwHU1Vo0rTAX5E99YyX7sNSwK1JC6glkOPrGKg9aBLjrx4igbUnczVMBXk5 xW34dqGA0uX7ktND0DNuPaGnARMfTcEH0+2d19P/OCslQK+OlaTFr1JQ1fC4J87VDd UWSr4GruMWPXA== Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3be110bbff9so30077b6e.1; Mon, 08 Apr 2024 07:19:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUWnu19PPY0u4kVmxIIQh3V/SM/BPfg0qTlHd1e4rM20PCoEN6dfWSHMDK8e2k4suvScCIAZ2gxzPYvL00HDQbYYniFMCi+YZzr5KKFTBRBzKr3m7itiKFRsotpYNLKXDVyDkcrMitWV3yS7MWyPxKMAT6ivqJgEqnY5RsSoEGzVdvj0BoSh37BKItReZWQnkC/AnFZnd0+eAZw7xASmwZnWtCH7WAvQebyD7Y/y9ASjzzIPlt/a9ipogHQXjuUVs+42A== X-Gm-Message-State: AOJu0Yy7ko1dqw+gs0xHuZ66keowJ/N5dPEWaommk6GVa95Bv3HM8fo3 feKxrZaqn9+YfMoJg740mOp+qLNWfnO9JlqRiUdqGqSJ4Nnamf4Vr/eVOiTfuC1vIpaeU+gM05A +hJolD3LO6W7d/ZTTa1YcsN0opoo= X-Received: by 2002:a05:6808:138e:b0:3c5:eab3:657 with SMTP id c14-20020a056808138e00b003c5eab30657mr5718403oiw.4.1712585945878; Mon, 08 Apr 2024 07:19:05 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org> In-Reply-To: <20240328-b4-module-owner-acpi-v2-0-1e5552c2c69f@linaro.org> From: "Rafael J. Wysocki" Date: Mon, 8 Apr 2024 16:18:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/19] ACPI: store owner from modules with acpi_bus_register_driver() To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Robert Moore , Dmitry Torokhov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Benson Leung , Tzung-Bi Shih , Corentin Chary , "Luke D. Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Thadeu Lima de Souza Cascardo , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Matan Ziv-Av , Mattia Dongili , Azael Avalos , Ajay Kaher , Alexey Makhalov , VMware PV-Drivers Reviewers , Richard Cochran , "Theodore Ts'o" , "Jason A. Donenfeld" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 28, 2024 at 8:49=E2=80=AFPM Krzysztof Kozlowski wrote: > > Changes in v2: > - Correct input and platform/chrome subjects. > - Add acks. > - Link to v1: https://lore.kernel.org/r/20240327-b4-module-owner-acpi-v1-= 0-725241a2d224@linaro.org > > Merging > =3D=3D=3D=3D=3D=3D=3D > All further patches depend on the first amba patch, therefore one way is > to ack and take it via one tree, e.g. ACPI. > > Description > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Modules registering driver with acpi_bus_register_driver() often forget t= o > set .owner field. > > Solve the problem by moving this task away from the drivers to the core > amba bus code, just like we did for platform_driver in commit > 9447057eaff8 ("platform_device: use a macro instead of > platform_driver_register"). > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (19): > ACPI: store owner from modules with acpi_bus_register_driver() > Input: atlas - drop owner assignment > net: fjes: drop owner assignment > platform/chrome: wilco_ec: drop owner assignment > platform: asus-laptop: drop owner assignment > platform: classmate-laptop: drop owner assignment > platform/x86/dell: drop owner assignment > platform/x86/eeepc: drop owner assignment > platform/x86/intel/rst: drop owner assignment > platform/x86/intel/smartconnect: drop owner assignment > platform/x86/lg-laptop: drop owner assignment > platform/x86/sony-laptop: drop owner assignment > platform/x86/toshiba_acpi: drop owner assignment > platform/x86/toshiba_bluetooth: drop owner assignment > platform/x86/toshiba_haps: drop owner assignment > platform/x86/wireless-hotkey: drop owner assignment > ptp: vmw: drop owner assignment > virt: vmgenid: drop owner assignment > ACPI: drop redundant owner from acpi_driver > > drivers/acpi/bus.c | 9 +++++---- > drivers/input/misc/atlas_btns.c | 1 - > drivers/net/fjes/fjes_main.c | 1 - > drivers/platform/chrome/wilco_ec/event.c | 1 - > drivers/platform/x86/asus-laptop.c | 1 - > drivers/platform/x86/classmate-laptop.c | 5 ----- > drivers/platform/x86/dell/dell-rbtn.c | 1 - > drivers/platform/x86/eeepc-laptop.c | 1 - > drivers/platform/x86/intel/rst.c | 1 - > drivers/platform/x86/intel/smartconnect.c | 1 - > drivers/platform/x86/lg-laptop.c | 1 - > drivers/platform/x86/sony-laptop.c | 2 -- > drivers/platform/x86/toshiba_acpi.c | 1 - > drivers/platform/x86/toshiba_bluetooth.c | 1 - > drivers/platform/x86/toshiba_haps.c | 1 - > drivers/platform/x86/wireless-hotkey.c | 1 - > drivers/ptp/ptp_vmw.c | 1 - > drivers/virt/vmgenid.c | 1 - > include/acpi/acpi_bus.h | 8 ++++++-- > 19 files changed, 11 insertions(+), 28 deletions(-) > --- Whole series applied as 6.10 material, thanks!