Received-SPF: pass (google.com: domain of linux-kernel+bounces-135511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 8 Apr 2024 16:22:32 +0200
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Jason J. Herne" <jjherne@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        pasic@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com,
        gor@linux.ibm.com, hca@linux.ibm.com,
        Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v4 4/5] s390/vfio-ap: Add write support to sysfs attr
 ap_config
Message-ID: <ZhP9qHs6tjPbh1/J@tuxmaker.boeblingen.de.ibm.com>
References: <20240326164706.29167-1-jjherne@linux.ibm.com>
 <20240326164706.29167-5-jjherne@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240326164706.29167-5-jjherne@linux.ibm.com>

On Tue, Mar 26, 2024 at 12:47:05PM -0400, Jason J. Herne wrote:

Hi Jason,

This series still has some issues.

> +	newbuf = rest = kstrndup(buf, AP_CONFIG_STRLEN, GFP_KERNEL);

This line triggers a checkpatch warning. Would it make sense
to turn it into below instead?

	newbuf = kstrndup(buf, AP_CONFIG_STRLEN, GFP_KERNEL);
> +	if (!newbuf)
> +		return -ENOMEM;
	rest = newbuf;

Also, please address other checkpatch suggestions.

> +	/* Save old state */
> +	/* The volatile cast here is to work around a gcc false positive
> +	 * Wstringop-overread-warning.
> +	 */
> +	ap_matrix_copy(&m_old, (*(struct ap_matrix * volatile *)(&matrix_mdev->matrix)));

Could you please come up with a different workaround? This issue has already
been resolved in the past in different ways. See commit 34186b48d29b ("ARM:
sharpsl_param: work around -Wstringop-overread warning") for example.

Thanks!