Received-SPF: pass (google.com: domain of linux-kernel+bounces-135578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 8 Apr 2024 11:11:11 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/5] PCI: dwc: Add common send PME_Turn_Off message
 method
Message-ID: <ZhQJD7GjRpDwa6jI@lizhi-Precision-Tower-5810>
References: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
 <20240319-pme_msg-v5-5-af9ffe57f432@nxp.com>
 <20240405062426.GB2953@thinkpad>
 <ZhALNGyNTAzN86GF@lizhi-Precision-Tower-5810>
 <20240406040131.GC2678@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240406040131.GC2678@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzRFVFRMQlVyc0RIQndwd0pHNlFQMlZyNE1oK00rdmhkcDVmSGplcjFFNmlR?=
 =?utf-8?B?MGRKWld3RlUzcC9lYVcrWlVYekpLOWc3b1ZoS0VvNE9YOGZrdVBhRFdoNUdF?=
 =?utf-8?B?UFVxV3hmS29GWW9tS29TM0U1a1RSbXBzTWh5Tm1uWTBVSmxIYy84b0xEWVJK?=
 =?utf-8?B?ZVVQaGRJblJkM05qWHJaNDNCNktRTTNleWExZmtrN2RsTi9ORThjL3lVOHFz?=
 =?utf-8?B?clcyd0RlMUQvQ00vQXAzdWxQWnl1NHBkcVBkT0N6aEFWelROakoyKzN1cUcz?=
 =?utf-8?B?bmFyTXpqRTJOVTRxMlgvSXdTei9qWFBEZHlGMWUrZ1RxWmV0U09nUjB3d29q?=
 =?utf-8?B?OXg2R2ZUdDJJTThOaXlsdGlIL3pjZWZuVEhoTzNYZ1ZjbEFzcmcvOVQ5MEti?=
 =?utf-8?B?WnA0SjBUWmJsUm9aK1pIaFVHRzRuK25uYmk0aFNZWGo1VmV4Nkl1OWxReWlm?=
 =?utf-8?B?YTJ3bVRqSlRSdmxiUWo3YWdlaFRSaGMvZjBYRXZCaEJJcGZ5aTVSN29OWnpQ?=
 =?utf-8?B?aGczaUJENFdJUHloYkhEVk5uNDEzVkxWQldPa2tSRUMrUVI0SENjV1ZDSDNl?=
 =?utf-8?B?NlBDM3dvbnp6UTRmeUxuRG5vL254SVFQTGVUQ0dkS2swejdZU3N0WTBqTU5O?=
 =?utf-8?B?Qld0ZDNrbndiRXVtcFd6TENxRVhkK3pTandPU3YwV1pCeU5kODFUTVFYM0I0?=
 =?utf-8?B?czRBR2hrd0djV2g2dXVaMWZqZ1lzOUlKSDE4NEttWUhCSDV2MEFRcWowb09r?=
 =?utf-8?B?SUVxTEpFbmx3R1NGWFNqOEJQV2ZLNDQyaWJKc0IrKzZKRVhrSUcwcGltUW1k?=
 =?utf-8?B?VzZra0JtQTJ1cVFwc1JsanRnQXZURDFPOFZGaXJYblBJZUVaRjZ0WHhtNHZF?=
 =?utf-8?B?dmdVNE12QWcySGdMdDRXaDYyTWNiZi9FWXE3d3R0RTZSblBBanRhd1NIclc5?=
 =?utf-8?B?cTJ5UHVFV2ttRDJWSEo3K0NTRWZsVkR3R1N1RzhRbjBlVnpMaGxON2VRSlNX?=
 =?utf-8?B?UjVFZklwSTJSdjVYMVhwVTFrSmlYcEQzSW4zeG5vU1hLWmpXMmcrVGwrM2Vi?=
 =?utf-8?B?d3BiWUU3UFhhTEN0cEdBcE5CM2I4c3Z5OFFuQ2tIakxleENYaTR2QlY1eGVD?=
 =?utf-8?B?VWN2UWJGajdJdm1PNUlvN254Mjc0aE5uRzd0VlF4MGFWUlRTQUlTZEhDTEtF?=
 =?utf-8?B?SWZkNngrU0ZDY0ZPZXVtL3luR1prMGdmTUdmd2VoV2tueWtPRi9BOXRxYnk3?=
 =?utf-8?B?elppeUJ5SEhCQStka0dpVHUvOXVmdTdkTmdhSE5OVEZTamdlSWVxZlVSNSta?=
 =?utf-8?B?QkZQN2JoMlVxaTRkQXVkNDJaWXBPSndBbklXdnlpM1pLazRxN2cyOHFLUGxo?=
 =?utf-8?B?UkVtUHlzQU43b0gzamdBQ0c4NVEyb1dnV1plWHlaUmhKd0Z2TkViQlJjQVhO?=
 =?utf-8?B?U0ZBOWRqa0JuZXI3S3FsVDAwZERUSE95S0JSdDFhdE92T25HU0d1VEtwNDl4?=
 =?utf-8?B?UXBocUc3MHpoT054SlRsUVBJV2t3WXB6bHArVkJ1TWVFditDZFk1bUpTV3l5?=
 =?utf-8?B?Y3dBY2p5Mi92cnBtelFWSWZHTzEwc1BuZ0dGeGxtYkpiOUVETXVoMXp0djRH?=
 =?utf-8?B?RE5oZTYzeCs0SXBrRGxYZUFDS0Q3QmZwcFlMRlpWbmJtUm5kbldlNW5sOWJH?=
 =?utf-8?B?WGlmYXlMdFBsSTlrYmZRcGNhRHdraFh2K1BidUN5RTY3WTdwNnZGVjE2ck1Z?=
 =?utf-8?B?NlNMQ3k3eVBEaXhxRUlzKzdJYWxZVTlZNW9iNGhlTFdsSXlpWFNzb0ZsbVNI?=
 =?utf-8?B?LzRETTZMZ0tyMS9sc2EwWFQ0VExEelBVSTBlLzFjNWVwak9nbXBrbWF1Lzlo?=
 =?utf-8?B?blFUb1FXMnYvak41RzZtbXQ1ejhPd04ybFdPVkliUUMvUGhscXlKcUJUWVpN?=
 =?utf-8?B?OHV4d3I2aWNEZC9FMjVaZFo0SHJaTVcrbXczYzBTWkt5UlpLc1U0UmloOEdE?=
 =?utf-8?B?QVU4L2FrSCsyR3Ntc0gxNzhXb1lDdTBlRDJ4T2NEY2VpT0NpTHRleUVoeDU3?=
 =?utf-8?B?cXVMZnR1ZGN6dXIxdmZkeklnZmxRZVpmTkhoZG5qVlN1Qkd4Vk1YQWxnSjd2?=
 =?utf-8?Q?TJ/c=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7eb2d8-c2f6-448b-409d-08dc57de2652
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 15:11:21.9256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y+/I5ByjGd87w/WTmUKm4z0hFeygCPY9zdKvtgmTULfF9ilSx/6DUnDe2fzkjggeCSPgiF+Poyb231rik6/A5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6806

On Sat, Apr 06, 2024 at 09:31:31AM +0530, Manivannan Sadhasivam wrote:
> On Fri, Apr 05, 2024 at 10:31:16AM -0400, Frank Li wrote:
> > On Fri, Apr 05, 2024 at 11:54:26AM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Mar 19, 2024 at 12:07:15PM -0400, Frank Li wrote:
> > > 
> > > PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off during system suspend
> > > 
> > > > Reserve space at end of first IORESOURCE_MEM window as message TLP MMIO
> > > > window. This space's size is 'region_align'.
> > > > 
> > > > Set outbound ATU map memory write to send PCI message. So one MMIO write
> > > > can trigger a PCI message, such as PME_Turn_Off.
> > > > 
> > > > Add common dwc_pme_turn_off() function.
> > > > 
> > > > Call dwc_pme_turn_off() to send out PME_Turn_Off message in general
> > > > dw_pcie_suspend_noirq() if there are not platform callback pme_turn_off()
> > > > exist.
> > > > 
> > > 
> > > How about:
> > > 
> > > "Instead of relying on the vendor specific implementations to send the
> > > PME_Turn_Off message, let's introduce a generic way of sending the message using
> > > the MSG TLP.
> > > 
> > > This is achieved by reserving a region for MSG TLP of size 'pci->region_align',
> > > at the end of the first IORESOURCE_MEM window of the host bridge. And then
> > > sending the PME_Turn_Off message during system suspend with the help of iATU.
> > > 
> > > It should be noted that this generic implementation is optional for the glue
> > > drivers and can be overridden by a custom 'pme_turn_off' callback."
> > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  drivers/pci/controller/dwc/pcie-designware-host.c | 94 ++++++++++++++++++++++-
> > > >  drivers/pci/controller/dwc/pcie-designware.h      |  3 +
> > > >  2 files changed, 93 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > index 267687ab33cbc..d5723fce7a894 100644
> > > > --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> > > > @@ -393,6 +393,31 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
> > > >  	return 0;
> > > >  }
> > > >  
> > > > +static void dw_pcie_host_request_msg_tlp_res(struct dw_pcie_rp *pp)
> > > > +{
> > > > +	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> > > > +	struct resource_entry *win;
> > > > +	struct resource *res;
> > > > +
> > > > +	win = resource_list_first_type(&pp->bridge->windows, IORESOURCE_MEM);
> > > > +	if (win) {
> > > > +		res = devm_kzalloc(pci->dev, sizeof(*res), GFP_KERNEL);
> > > > +		if (!res)
> > > > +			return;
> > > > +
> > > > +		/* Reserve last region_align block as message TLP space */
> > > > +		res->start = win->res->end - pci->region_align + 1;
> > > > +		res->end = win->res->end;
> > > 
> > > Don't you need to adjust the host bridge window size and end address?
> > 
> > Needn't. request_resource will reserve it from bridge window. Like malloc,
> > if you malloc to get a region of memory, which will never get by malloc
> > again utill you call free.
> > 
> 
> Hmm, will that modify the window->res->end address and size?

No. This windows already reported to pci system before this function. It is
not good to modify window-res-end. It just add child resource like below.

windows is root resource, which will create may child when call
request_resource.
          bridge -> windows
		child1 -> msg
		child2 -> pci ep1
		child3 -> pci_ep2.
		...

Although you see whole bridge window, 'msg' already used and put under root
resource,  new pci devices will never use 'msg' resource. 

If change windows->res->end here, I worry about it may broken resource
tree.

> 
> > > 
> > > > +		res->name = "msg";
> > > > +		res->flags = win->res->flags | IORESOURCE_BUSY;
> > > > +
> > > 
> > > Shouldn't this resource be added back to the host bridge?
> > 
> > No, this resource will reserver for msg only for whole bridge life cycle.
> > Genenally alloc resource only happen at PCI devices probe. All pci space
> > will be fixed after system probe.
> > 
> 
> I don't think so. This resource still belongs to the host bridge, so we should
> add it back.

When add back?  It was reserved at bridge probe. When bridge remove, all
resource will released. 

> 
> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்