Received-SPF: pass (google.com: domain of linux-kernel+bounces-135596-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <CANiq72meap5C9bkj5rNDE=0U5gb5OKwDrrTSrVRwJbkAPWgUsg@mail.gmail.com>
 <d912f0e0-19d5-4cde-a548-10db94da15a9@yahoo.de>
In-Reply-To: <d912f0e0-19d5-4cde-a548-10db94da15a9@yahoo.de>
From: =?UTF-8?Q?Sergio_Gonz=C3=A1lez_Collado?= <sergio.collado@gmail.com>
Date: Mon, 8 Apr 2024 17:22:49 +0200
Message-ID: <CAA76j92Sd-YN=UYET7jyMyBuzyhET+rwqF-Rxo-0S_60+TUX1Q@mail.gmail.com>
Subject: Re: [PATCH] x86/insn_decoder_test: allow longer symbol-names
To: Danilo Krummrich <danilokrummrich@yahoo.de>
Cc: miguel.ojeda.sandonis@gmail.com, tglx@linutronix.de, x86@kernel.org, 
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, 
	david@readahead.eu, davidgow@google.com, hpa@zytor.com, 
	john.m.baublitz@gmail.com, linux-kernel@vger.kernel.org, mhiramat@kernel.org, 
	mingo@kernel.org, rust-for-linux@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I was just waiting in case there was feedback from David Rheinsberg.

Cheers!

On Mon, 8 Apr 2024 at 14:52, Danilo Krummrich <danilokrummrich@yahoo.de> wr=
ote:
>
> On 2/20/24 18:07, Miguel Ojeda wrote:
> >
> > On Fri, Jan 27, 2023 at 11:39=E2=80=AFAM David Rheinsberg <david@readah=
ead.eu> wrote:
> >>
> >> The current workaround is to just disable CONFIG_X86_DECODER_SELFTEST,=
 which I thought is a sad state. I can gladly use `256 + KSYM_NAME_LEN` and=
 add a comment ala "room for insn-encoding and a symbol name". Would that b=
e acceptable? The alternative would be to try to dyn-alloc a buffer and inc=
rease it to the actual line-length?
> >
> > John independently hit this issue again. Could we fix this? Going for
> > the `256 + KSYM_NAME_LEN` sounds good enough for the moment since it
> > would be a clear improvement, though I agree this could be cleaned up
> > further.
>
> I hit this independently as well. Miguel pointed me on this mail thread
> when I sent another fix for this in [1].
>
> >
> > Sergio took the approach David suggested in a related patch [1], but
> > perhaps it is best to submit the fix on its own so that it is easier
> > to put it in. David, would you be so kind as to submit a v2 with that?
> > Hopefully x86 can pick it up, otherwise with an Acked-by I am happy to
> > take it too; and then Sergio can submit his patch on top again.
>
> Sergio, David: Do you intend to follow up on this? Otherwise, I can also
> pick this up and re-submit.
>
> - Danilo
>
> >
> > Thanks!
> >
> > (Cc'ing also Masami who wrote this originally)
> >
> > [1] https://lore.kernel.org/rust-for-linux/20231119180145.157455-1-serg=
io.collado@gmail.com/
> >
> > Cheers,
> > Miguel
>
> [1] https://lore.kernel.org/rust-for-linux/20240325174924.95899-2-dakr@re=
dhat.com/