Received-SPF: pass (google.com: domain of linux-kernel+bounces-135600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Apr 2024 11:29:26 -0400
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>, james.morse@arm.com, 
	fenghua.yu@intel.com, babu.moger@amd.com, bp@alien8.de, tglx@linutronix.de, 
	mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, 
	peternewman@google.com, x86@kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, 
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in
 limbo list
Message-ID: <20240408-stalwart-tomato-sloth-bddbae@lemur>
References: <20240319083039.223088-1-haifeng.xu@shopee.com>
 <4244b729-2eec-4999-9427-00b5c9f3e6fc@intel.com>
 <ca45f32d-b526-4bcd-b177-08698babaf3d@shopee.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ca45f32d-b526-4bcd-b177-08698babaf3d@shopee.com>

On Mon, Apr 08, 2024 at 03:44:00PM +0800, Haifeng Xu wrote:
> I can also reproduced it. After digging into it, I found that our DKIM signature header
> has 't' and 'x' flags. They are recommended as a means to help identify spam.
> 
> t= is the DKIM signature timestamp.
> x= is the DKIM signature expiration time.
> 
> The source code of DKIM Validation can be seen in dkim/__init__.py(line 351), I paste it
> here.
> 
>  343     if b'x' in sig:
>  344         if re.match(br"\d+$", sig[b'x']) is None:
>  345             raise ValidationError(
>  346               "x= value is not a decimal integer (%s)" % sig[b'x'])
>  347         x_sign = int(sig[b'x'])
>  348         now = int(time.time())
>  349         slop = 36000 # 10H leeway for mailers with inaccurate clocks
>  350         if x_sign < now - slop:
>  351             raise ValidationError(
>  352                 "x= value is past (%s)" % sig[b'x'])
>  353             if x_sign < t_sign:
>  354                 raise ValidationError(
>  355                     "x= value is less than t= value (x=%s t=%s)" %
>  356                     (sig[b'x'], sig[b't']))
> 
> The expiry time is less than the time point you download the patch, so the validation
> fails. If I comment out these lines, this series can be successfully downloaded.

FWIW, I've requested ability to ignore the x= flag when validating signatures:
https://bugs.launchpad.net/dkimpy/+bug/2047054

-K