Received-SPF: pass (google.com: domain of linux-kernel+bounces-135611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9183d3b1-4f12-4c5a-8210-71388935f08c@kontron.de>
Date: Mon, 8 Apr 2024 17:36:30 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on
 failure
To: Fabio Estevam <festevam@gmail.com>, gregkh@linuxfoundation.org
Cc: mka@chromium.org, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org, Fabio Estevam <festevam@denx.de>
References: <20240408151700.1761009-1-festevam@gmail.com>
Content-Language: en-US, de-DE
From: Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20240408151700.1761009-1-festevam@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OFVFZlNLRmEzR0lzYmc3c0hkVmlyY2Q3amkzZWNGejRxRTBWVHZhWnVIZVZx?=
 =?utf-8?B?M045dFNTR3g2cFlkWFc3Y0ZvbnphSkNLcEZoeDVJanBCM0dPSnZ0cWg3blZ0?=
 =?utf-8?B?K2ZHYVlwcXAyVDRnN3Zja0FqTTN6dlZFbDcxM3l2ZUt5R21lUVNtVGkyRzZl?=
 =?utf-8?B?QzQwa1NEUFRyanFLMk1pdXNpWHJhbFBaaUpYVk1TaS91Y3dQS1BVZy9pTHBv?=
 =?utf-8?B?RzBBeTFzYXdQa053RnVSVkxXdllXQjg4TlIreXQ0NkJYTWVzcEVZemZ0c3RZ?=
 =?utf-8?B?dUlQRlNGRVdqNXNJWEd6OWoxblFDb2J1bGdpRWJDYld4ajMxYit6a25CZU9y?=
 =?utf-8?B?R3JoVVFyNTUvNzJBQjkvQWZjdUdGRnN6aEk1TjZuTlJRN1hLTWdnZFVyTW1t?=
 =?utf-8?B?MWRIQVA0ZW13Z2o4L3paNnVpUzZ3Vk1UaXdIVEZHbUNjckd5ZzMxbk1USWdC?=
 =?utf-8?B?eG1iaVVJOC9qM1hvbHNJSnMxNUxodG56c3QySk1OVnc1UjltTS8zVjhobEZZ?=
 =?utf-8?B?RHJ1SFBBRERTRll5Qlk3NUtqTlBHS3I3STQwcTN5S2N4b3N0cHJJUDRxalFn?=
 =?utf-8?B?MHd3RmhCeEhMcE1jWGQ2WWNFSlNQV2FKZUppREhpM3BTTXNsVFN1NEhWZVFZ?=
 =?utf-8?B?MlY3RDVMTk9xakRrakROR3dXS2RYZjQ2N09ieDZWMFFGSGpSeEZwUDVjSVY3?=
 =?utf-8?B?Ui9ObmdoYWMyS1Yvd0hNWHVuQWI2RWhkOFhrdklvR2R0WVpISldRcWRzeHdZ?=
 =?utf-8?B?b096UzdpWVFjU3RFRHFsNEJlVTBpakhHOVFpaENrbWJzVUQ3ZVBhSFZyNmpL?=
 =?utf-8?B?b3RkdXFGYW9aUG5Idm5PU1RDbnY4RmpRYndpdDU3ZTZCd01mUm1SUEZPWVBW?=
 =?utf-8?B?U1dOL3hmdVI0alVKRUUzR3JjWHZrL1BVMWl2b1dBVlg2Q2dYWkJKZDU2TndG?=
 =?utf-8?B?SUY0ZUZNOHRkMWk2YUV4Z2VJYWZnRkppZEdlb1hwdUUwUTk1ZzdlVG1DamIw?=
 =?utf-8?B?RDBFMXhuM1NzbmVFVlN5bWlIU21OaWtQeUx3ODllZjNCajREY1VtZGtHRGgx?=
 =?utf-8?B?YVVBWFJqaVVIKzg5blIrb1h4T1hWWWRROWJ4b0hSdXRYelk2OGhNYkk1OFlL?=
 =?utf-8?B?azFEK3RjVXJMdHBtK0hJSEliWDNEZTlpOVZ6VzBzQWUzSzcwVkVQajJkeUdn?=
 =?utf-8?B?VFh0MXd6SU5CUDVkODRHL3BKSmpTd1FSSnNPRUtWRVQvOFJURTZkOVBzMURl?=
 =?utf-8?B?YnpmcFdIcWg3ZG5vR21Ybm85aW1zeS9QeXJ2aFMzOThGK2dxUkJKYnErbmZj?=
 =?utf-8?B?UFhDMks4b1pic3d4MDZ1dHgxRkN0b081NkIrdHJtNGZMZVV2MWVFRmhWUVFy?=
 =?utf-8?B?NlVnSlNkVTNTanZlTUZITys5ZmdLcU9NdVBwQVJPVmh5bXhkRFBrOU80MnZp?=
 =?utf-8?B?bzFxVjVFcVZjeTRoLzZOWkpyOGtyQ2dZVmVkSWF5d054SmZMcW5PVC83bktI?=
 =?utf-8?B?MjQxbERMa0kySUZ0RGtQY09kNStvZzU4amltNFF6Znc4cytmL2hkNDAzSHBJ?=
 =?utf-8?B?ZjBWMWo2cFdkZWxnQW9TKzRHci9yTTVDazVqS1QwblJiazc2YjZMbWR3SXRz?=
 =?utf-8?B?SVBNbnN0dStkSitjdE9ubVlNZVlNdVZmR0ViaE9RTVNsMWdLZHI1NTB2QkxS?=
 =?utf-8?B?SGFxNDhJUnUvbFRIZkp1aG1VVWVNRlE3WWhZRU56SVNJWUV1SGZsS3N2cmpy?=
 =?utf-8?B?NHVqNjVtRHJDbnQvL01JeWl6dWczNDVva3pnc0tsbk1FM0FScDg1b3JTMmpm?=
 =?utf-8?B?OHpjR2FHVkRSYWZOZWdwN3IwT0JRTlBTM0VUc0dVU0VhL3NQd05iRnFmNnpE?=
 =?utf-8?B?NTZHWEN6R1pSQllXOXVFYW54dms2K0ExYUpsSzdvYmpMT29KbTE2SXhVQUNY?=
 =?utf-8?B?UzcySjVuSXp1d1Q5SDdkMUE5ejJxOWtrTzFwNC9ydXkveDkrbk82cVhQN24w?=
 =?utf-8?B?bktCcTN4S3hUT0xqdjBod3BIa1Yvemt6MEdIemI4QlJYZVg0WENoSVBKUWs2?=
 =?utf-8?B?UWlaOXR5aGFJN21TRWtxYmdzeWF2TnNNMnlpNEZGYk1taWlqamhqOUs3WnJT?=
 =?utf-8?B?blZvZ0FrMnBrTjdkZW9vd0lTU0pxMXNKbXpMV25VUkl5RFZieHNPRWFSYWxG?=
 =?utf-8?B?U0E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 356aefb4-7031-4271-84b3-08dc57e1aa36
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 15:36:31.7895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6EoI6YuYTh2Dppa1uGKSuklHMl9EribNQF8meQG2oTy1lA0b2pIVvudahZib3wNVXhHFAQ2UzcPg+TAWh7s+/cxiEsxobdMpXi9RmnA1OX8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6436

On 08.04.24 17:17, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> In case regulator_bulk_enable() fails, the previously enabled USB hub
> clock should be disabled.
> 
> Fix it accordingly.
> 
> Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock input")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Oops, sorry. I totally missed that when I was porting the patch from a
downstream tree that didn't have the regulator code path.

Thanks for fixing!

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

> ---
>  drivers/usb/misc/onboard_usb_dev.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
> index 648ea933bdad..f2bcc1a8b95f 100644
> --- a/drivers/usb/misc/onboard_usb_dev.c
> +++ b/drivers/usb/misc/onboard_usb_dev.c
> @@ -93,7 +93,7 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev)
>  	if (err) {
>  		dev_err(onboard_dev->dev, "failed to enable supplies: %pe\n",
>  			ERR_PTR(err));
> -		return err;
> +		goto disable_clk;
>  	}
>  
>  	fsleep(onboard_dev->pdata->reset_us);
> @@ -102,6 +102,10 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev)
>  	onboard_dev->is_powered_on = true;
>  
>  	return 0;
> +
> +disable_clk:
> +	clk_disable_unprepare(onboard_dev->clk);
> +	return err;
>  }
>  
>  static int onboard_dev_power_off(struct onboard_dev *onboard_dev)