Received-SPF: pass (google.com: domain of linux-kernel+bounces-135620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240407063341.3710801-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <ZhQE9dU-VIcWI6au@smile.fi.intel.com>
In-Reply-To: <ZhQE9dU-VIcWI6au@smile.fi.intel.com>
Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Date: Mon, 8 Apr 2024 08:42:48 -0700
Message-ID: <CAC41dw-Df3L7B=Tq2QkQHDT2Yf3MzHgy8-czPAkZhdPf0Tea4Q@mail.gmail.com>
Subject: Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024 at 7:53=E2=80=AFAM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sat, Apr 06, 2024 at 11:33:41PM -0700, Kuppuswamy Sathyanarayanan wrot=
e:
> > The function acpi_blacklisted() is defined only when CONFIG_X86 is
> > enabled. So to keep it consistent, protect its declaration with
> > CONFIG_X86.
>
> ...
>
> >  extern char acpi_video_backlight_string[];
> >  extern long acpi_is_video_device(acpi_handle handle);
> > +#ifdef CONFIG_X86
> >  extern int acpi_blacklisted(void);
> > +#endif
> >  extern void acpi_osi_setup(char *str);
> >  extern bool acpi_osi_is_win8(void);
>
> IIRC there is already similar ifdeffery, can we just move the declaration
> there?

There is none for CONFIG_X86. We only have some combinations or
derived config checks like below:

#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
#ifdef CONFIG_X86_IO_APIC

>
> --
> With Best Regards,
> Andy Shevchenko
>
>