Received-SPF: pass (google.com: domain of linux-kernel+bounces-135627-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i36794607:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-368-gc733b1d8df-fm-20240402.001-gc733b1d8
Precedence: bulk
MIME-Version: 1.0
Message-Id: <a78fae4c-6ab4-4ac1-ae72-c68b24ebb640@app.fastmail.com>
In-Reply-To: <6251fc72-21ca-aba6-c70a-eefdbc046951@linux.intel.com>
References: <20240405152924.252598-1-schnelle@linux.ibm.com>
 <20240405152924.252598-2-schnelle@linux.ibm.com>
 <1a14ac6e-30e9-048e-50cc-c1c3aacc2118@linux.intel.com>
 <a98fdeca857f4eb1e3513a8658ef55f89ac45e8b.camel@linux.ibm.com>
 <6251fc72-21ca-aba6-c70a-eefdbc046951@linux.intel.com>
Date: Mon, 08 Apr 2024 17:50:11 +0200
From: "Arnd Bergmann" <arnd@kernel.org>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 "Niklas Schnelle" <schnelle@linux.ibm.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
 "Jiri Slaby" <jirislaby@kernel.org>,
 linux-serial <linux-serial@vger.kernel.org>,
 "Heiko Carstens" <hca@linux.ibm.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tty: serial: handle HAS_IOPORT dependencies
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024, at 17:41, Ilpo J=C3=A4rvinen wrote:
> On Mon, 8 Apr 2024, Niklas Schnelle wrote:
>> On Mon, 2024-04-08 at 12:54 +0300, Ilpo J=C3=A4rvinen wrote:
>> > On Fri, 5 Apr 2024, Niklas Schnelle wrote:
>> ---8<---
>> > > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial=
/8250/Kconfig
>> > > index 47ff50763c04..54bf98869abf 100644
>> > > --- a/drivers/tty/serial/8250/Kconfig
>> > > +++ b/drivers/tty/serial/8250/Kconfig
>> > > @@ -6,7 +6,6 @@
>> > > =20
>> > >  config SERIAL_8250
>> > >  	tristate "8250/16550 and compatible serial support"
>> > > -	depends on !S390
>> >=20
>> > Why? Your changelogs gives zero insight on this change.
>>=20
>> I used this for compile testing since I build on s390 natively and th=
is
>> would have hidden the missing HAS_IOPORT dependencies I'm pretty sure
>> it was added because of the I/O port problem too. I'll either add to
>> the commit description that it is no longer needed or drop this. Any
>> preference?
>
> Okay, we might never know the reason for sure if that's old enough.
> I think the best approach would be to put it into own patch so this=20
> guessimation is limited to a single liner patch instead of it being=20
> hidden among the other clearer cases.

From the description in commit 1598e38c0770 ("serial: forbid
8250 on s390") I would just leave the dependency there.

     Arnd