Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1437843lqe; Mon, 8 Apr 2024 08:54:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDu6nkrFV21Xiorsh4LCki7THz6jdnXWO569C/iJD23CAaKBGlU0wjOsZ8MLbypvgHQ3ie4ylAmIByiHfVftCHYapTVABe8t5goltsWA== X-Google-Smtp-Source: AGHT+IEQ/Jxp2BgmLrsFSiCkPw+xkI9TEFOcXNs4LTY6tN8dxWkUC1ynprDSj4A+AMLeky1af2Ah X-Received: by 2002:a19:e018:0:b0:516:be66:4d0 with SMTP id x24-20020a19e018000000b00516be6604d0mr5534223lfg.56.1712591664593; Mon, 08 Apr 2024 08:54:24 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a19-20020a170906191300b00a51def60f1bsi583673eje.851.2024.04.08.08.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 08:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135633-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=drrUGeTW; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-135633-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135633-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E503D1F2196D for ; Mon, 8 Apr 2024 15:54:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0366142E67; Mon, 8 Apr 2024 15:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="drrUGeTW" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C19C14265A; Mon, 8 Apr 2024 15:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712591601; cv=none; b=rrAxEG1poWde8lshxzAr+8WIqmpBERs4I/sYXFxJpPZFHgErN1sQdPTFhTAxAR5vFOd95cLS2ry+4go6dIJI8O8T1kG8gOFqTG840onvi/MWNS1ONzf1dwlq9XuQ3oXW5qedtZChkSt5dgBDPA+vfiNfTSB6DfkW+nW49t22shA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712591601; c=relaxed/simple; bh=Ayz7Pk1l7/zi8DRIp+xNrMxlwSWlL1f67lgps6EFpgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PtHzf6jwVYvf72fkkaTczBE7AwQeFbW5ZGGsgbC2/v94AC649w6tWXVuDuGrUynGBgcr2DoGlet//2L31RMJsP8a5srPvzWYxu6uNpZzavWCoddCmNQyC4caxTPvtt+jLuSpkU/SkJMu2hxPCebIMcDq8jLruZPqEiclvsh9kTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=drrUGeTW; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712591599; x=1744127599; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Ayz7Pk1l7/zi8DRIp+xNrMxlwSWlL1f67lgps6EFpgc=; b=drrUGeTWb/RYNQwm1wu8S8CWkHFVY51C3OHaWLETEXQ8qymgD10m/TTj UEmeYGGNlu09qudh18clqQYXEuikUoEEQsPan7LCNT/VQHPGR1Tt0hIQc XA2zRBYG1g93mLZz8ls6yJzzoYP5Vz68+paFCBwIkvmbuR04pf/sV/hVB nbqU46n7Xaa9W2k5/N8chQNGDSfhN8WNQOhcep8zHnLo2AbnxAl0uq5eR gEtw8EvWhX/DtbaYnm/kG7vGDeEI7Vpr8Qab0gGOJaw7lO3dNzrvPCYfQ uBRyuKT5XfBJjZPzceWr/+SKn2XfW0IYu8hq2yadEO9JgxnhhWDer98IU w==; X-CSE-ConnectionGUID: 21Rfsuo3RZuos7YudC5kVA== X-CSE-MsgGUID: jeAbz/UJQjKf2egUneo5aA== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="10850176" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="10850176" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 08:53:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="915369182" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="915369182" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 08:53:17 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rtrJ4-00000002ZJF-3Z42; Mon, 08 Apr 2024 18:53:14 +0300 Date: Mon, 8 Apr 2024 18:53:14 +0300 From: Andy Shevchenko To: Kuppuswamy Sathyanarayanan Cc: "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Subject: Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled Message-ID: References: <20240407063341.3710801-1-sathyanarayanan.kuppuswamy@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 08, 2024 at 08:42:48AM -0700, Kuppuswamy Sathyanarayanan wrote: > On Mon, Apr 8, 2024 at 7:53 AM Andy Shevchenko > wrote: > > On Sat, Apr 06, 2024 at 11:33:41PM -0700, Kuppuswamy Sathyanarayanan wrote: .. > > > extern char acpi_video_backlight_string[]; > > > extern long acpi_is_video_device(acpi_handle handle); > > > +#ifdef CONFIG_X86 > > > extern int acpi_blacklisted(void); > > > +#endif > > > extern void acpi_osi_setup(char *str); > > > extern bool acpi_osi_is_win8(void); > > > > IIRC there is already similar ifdeffery, can we just move the declaration > > there? > > There is none for CONFIG_X86. We only have some combinations or > derived config checks like below: > > #if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH) > #ifdef CONFIG_X86_IO_APIC Okay, it seems I mixed this with acpi_bus.h. -- With Best Regards, Andy Shevchenko