Received-SPF: pass (google.com: domain of linux-kernel+bounces-135645-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b51dd1db-12a7-4618-a660-85f70c7ccd5d@intel.com>
Date: Mon, 8 Apr 2024 08:58:50 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/2] x86/resctrl: Track llc_occupancy of RMIDs in limbo
 list
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>, Haifeng Xu
	<haifeng.xu@shopee.com>
CC: <james.morse@arm.com>, <fenghua.yu@intel.com>, <babu.moger@amd.com>,
	<bp@alien8.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>, <peternewman@google.com>,
	<x86@kernel.org>, <linux-kernel@vger.kernel.org>, <corbet@lwn.net>,
	<linux-doc@vger.kernel.org>
References: <20240319083039.223088-1-haifeng.xu@shopee.com>
 <4244b729-2eec-4999-9427-00b5c9f3e6fc@intel.com>
 <ca45f32d-b526-4bcd-b177-08698babaf3d@shopee.com>
 <20240408-stalwart-tomato-sloth-bddbae@lemur>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240408-stalwart-tomato-sloth-bddbae@lemur>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXp0eUx6VFlqUmxBMGFTcjJDdGRvb0p4SjY0SXpWOVpnMXc0Znkxa2tmYWpy?=
 =?utf-8?B?cmFzNzR3R1c4ZGRtWUlTS2ZPei80b3RBQ2w5YnhRL2xMTU9vRGhoSkk4LzQz?=
 =?utf-8?B?aGZ2bFBoSWNUYllUOHFjVlJyOFZ2TWxzWk1LVno2d2lvYXFLbDlTS2FnQUxm?=
 =?utf-8?B?MXNjRWtuVFoyaUtleG1RYmRJV1FuWWpjN2VZUm9iR3hBZlR4REV0ZWU1S2M5?=
 =?utf-8?B?ZWVvZStvYkp0Yk9heFc4NVpLa0NQYTVyay82anQ2L3JjSGdMaHVvSmNieXdm?=
 =?utf-8?B?MHhTS2pKeGIwSWtFVFVzRE9QV2YzOHZZbTlQeHBxeWdyc3RtQU8rcys1eVAz?=
 =?utf-8?B?dGJ1QlRmRkovVFF4Si9XOTJCTlNyb2hBYitNUy9RYzJqNElpREVIeVBtQnpD?=
 =?utf-8?B?dUpSZXRJckFrWHdSYVFhRG5SZ0xlTWYyZkJibVJ5Uk52L3ZZc0lwVmxXcXdR?=
 =?utf-8?B?cm5FNlZUNkNlK01oNG5iRW1QWE12cWZuNVpKT0crNUs0dWxrZWJyY3NQMDVG?=
 =?utf-8?B?WFBzRnpSei8yV2NQUHZKTWtTNE4vUWoxck80ci9ydGRKdjBGbGVoL3lBajhi?=
 =?utf-8?B?R1IxVUpDK2dFYW94Wi91M3hkYmlCdVJIQTAyM1Foc3dzZkd5U2xraXJYU1dG?=
 =?utf-8?B?ZTYvd2hvNjVIa1BzZSsvV2hlMzhjcTFDTjJmNDIxL1ltM3VNRFN0dGh1Wlp5?=
 =?utf-8?B?K3lYQkU1ckE4OGVOOWw0cDJDRXhVVjVkM1NhNW9ya3RFNFNTL29LN1lXMDVm?=
 =?utf-8?B?VUZaVDVLd21jS0R5WXFNQjEwcE53eEdQVU1TWnk2NzMzYnRrcWs0Ykh4Vk5F?=
 =?utf-8?B?TUpvN1d3WlJ5N0VZTERWV010NjJCVStROTI2bFpHS1I1TFE3Q2g2d21KcEVu?=
 =?utf-8?B?ZmhyeUk4cldEdDVtVXAySHAvK3RRdkhXTDQ5dWRxZnJSeGh1YnMyd2tyMkVt?=
 =?utf-8?B?dWVjSGFnM3ZjZ0ZrU00xb0R2MnpHOWRsSUR0S0J6QlZnblJyZEJ6SHN4RWtD?=
 =?utf-8?B?MTNPWVlwT0dXSEVYVklnbldUTGZVRk54VElydkU3c0FqQ1J0SS9wd2ZLQ0xn?=
 =?utf-8?B?WjFIM1FNb3BrOURyNzkwaW14ZWllWnlKaC9qTUNsM2xpd0FIMXBjSFp1S0tL?=
 =?utf-8?B?MTJSYnVxWUhweUlCME1CRDFZQk1qczVXM0tsaTFHT1VGa3A5cEc0UGRQMk9a?=
 =?utf-8?B?UHZIYVA0eldTWjNLRWIwQkkzVmV4WUVtbnZBY3YrMytwRHMxQWV2Um82VTRZ?=
 =?utf-8?B?bGYyNENrZUdRdm9yMUJIbU15UGhtZEJXV0RhUHRBTEJEY0pQcWpZMWRpQkZu?=
 =?utf-8?B?ZmZUTEFPS3FDTE5GN21JdXk3Y2VxVzBrRGNRUzRGOG9mLzYrZjZhSjZ1N25p?=
 =?utf-8?B?M2t1bmIvbDJNeEJPZlN4QkRNSERnUmpjbWkxNzRXdnZmTUpxdk1TckxTYWdp?=
 =?utf-8?B?Y1g2WTNCUnRRWCtZSHNPa0Fmd2Y5emgyYTFXNDgwZTEwMExXZDhMTkl6K29y?=
 =?utf-8?B?L09mL1M0L1FMUkRTVk1HSUxuZktlS1hvUTA5Y0RUWlZoSWw1azhTQkc5L0JY?=
 =?utf-8?B?MU5kTU14S2ptcFdzTXVNZUtIR1lKdjNDbzlFK2UvaWR4NnlJL3g0Q2M0YURF?=
 =?utf-8?B?WnVJbnJKaTkyY2diQ3pBR2VOajVDNk9wcXF0ZUFsVXhTYUxHUFlsSm1zTits?=
 =?utf-8?B?UW0zMFpJU1Y3cStmMENtVlpRaHpIeFdUVkRFcmdjTlAzVDBFQXZPT2pCeWtD?=
 =?utf-8?B?UVVDSk5lS1QrVm50TGFSUWNZTlVIWElldDR4R2U1WHUwMU45MWpacXk3TDZo?=
 =?utf-8?B?NTZUNlpkZ2EzVjA4NElIbG1hMGJuY0syWFdSZkphejcvN1RMQWtCWk96R3Bu?=
 =?utf-8?B?NDdYS2JGYXdZcjdXd2VWRFZyb01jVENDVDlmU2dYaWc0bXIydEVVNTYrTisy?=
 =?utf-8?B?bzFmejI3SERuS2p1dHEyUTdiRStnQytLU2pyMGg1RUJ6OVRBa2Jrd1k2aHpj?=
 =?utf-8?B?WWNNb3JJMVZJUWhHK1g2cWJPWC9UbkhQZjFoM2FNOEZUTURnb09iVlYyYm0r?=
 =?utf-8?B?MmV4L3FSL3JiUjF2YVprTGZsRUZMcVZZZVYyOUYwNVBlVWFjY21oV05GUGVU?=
 =?utf-8?B?cTdycHV2TndkVmpZNGhVTjhVaWxjR2JValI1UE83UWQ3TkYzNVEySlNNYzBo?=
 =?utf-8?B?OEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 88015e80-6b23-4920-574f-08dc57e4c9ba
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 15:58:52.9585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mRrf5yGyKdbDLNGckgwlzJQbYE2rYq9l6//yf4AJINlQIhglrp5TiR78wE+tntYEOuK3o5uKIt5XM/52cmnqPWA5RVBwB+U+J3eyg348xUs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6446
X-OriginatorOrg: intel.com


On 4/8/2024 8:29 AM, Konstantin Ryabitsev wrote:
> On Mon, Apr 08, 2024 at 03:44:00PM +0800, Haifeng Xu wrote:
>> I can also reproduced it. After digging into it, I found that our DKIM signature header
>> has 't' and 'x' flags. They are recommended as a means to help identify spam.
>>
>> t= is the DKIM signature timestamp.
>> x= is the DKIM signature expiration time.
>>
>> The source code of DKIM Validation can be seen in dkim/__init__.py(line 351), I paste it
>> here.
>>
>>  343     if b'x' in sig:
>>  344         if re.match(br"\d+$", sig[b'x']) is None:
>>  345             raise ValidationError(
>>  346               "x= value is not a decimal integer (%s)" % sig[b'x'])
>>  347         x_sign = int(sig[b'x'])
>>  348         now = int(time.time())
>>  349         slop = 36000 # 10H leeway for mailers with inaccurate clocks
>>  350         if x_sign < now - slop:
>>  351             raise ValidationError(
>>  352                 "x= value is past (%s)" % sig[b'x'])
>>  353             if x_sign < t_sign:
>>  354                 raise ValidationError(
>>  355                     "x= value is less than t= value (x=%s t=%s)" %
>>  356                     (sig[b'x'], sig[b't']))
>>
>> The expiry time is less than the time point you download the patch, so the validation
>> fails. If I comment out these lines, this series can be successfully downloaded.
> 
> FWIW, I've requested ability to ignore the x= flag when validating signatures:
> https://bugs.launchpad.net/dkimpy/+bug/2047054

Thank you very much Haifeng and Konstantin.

Reinette