Received-SPF: pass (google.com: domain of linux-kernel+bounces-135668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Apr 2024 18:25:05 +0200
From: Borislav Petkov <bp@alien8.de>
To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, x86@kernel.org, kai.huang@intel.com
Subject: Re: [PATCH 1/4] x86/cpu: Add and use new CPUID region helper
Message-ID: <20240408162505.GAZhQaYYJ7wrPpaPjj@fat_crate.local>
References: <20240403153508.7328E749@davehans-spike.ostc.intel.com>
 <20240403153510.F327603D@davehans-spike.ostc.intel.com>
 <bab18bb7-ef6d-477a-845a-de9b52dd9591@suse.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bab18bb7-ef6d-477a-845a-de9b52dd9591@suse.com>
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 04, 2024 at 11:04:49AM +0200, J=C3=BCrgen Gro=C3=9F wrote:
> Aren't you missing "width &=3D 0xff;" here? get_cpuid_region_leaf() doe=
sn't
> truncate the returned value, which has the linear address width at bits=
 8-15.

Yeah.

Other than that, the intention looks ok as it documents what that code
magic was.

Thx.

--=20
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette