Received-SPF: pass (google.com: domain of linux-kernel+bounces-135616-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 8 Apr 2024 18:41:24 +0300 (EEST)
To: Niklas Schnelle <schnelle@linux.ibm.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Jiri Slaby <jirislaby@kernel.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    Arnd Bergmann <arnd@kernel.org>, Heiko Carstens <hca@linux.ibm.com>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tty: serial: handle HAS_IOPORT dependencies
In-Reply-To: <a98fdeca857f4eb1e3513a8658ef55f89ac45e8b.camel@linux.ibm.com>
Message-ID: <6251fc72-21ca-aba6-c70a-eefdbc046951@linux.intel.com>
References: <20240405152924.252598-1-schnelle@linux.ibm.com>  <20240405152924.252598-2-schnelle@linux.ibm.com>  <1a14ac6e-30e9-048e-50cc-c1c3aacc2118@linux.intel.com> <a98fdeca857f4eb1e3513a8658ef55f89ac45e8b.camel@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-270381069-1712590779=:14302"
Content-ID: <4b597578-0a35-f46c-87f0-dea8ba894f82@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-270381069-1712590779=:14302
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <933d7f4f-41e8-a08b-e3ae-4e09ab1be8f6@linux.intel.com>

On Mon, 8 Apr 2024, Niklas Schnelle wrote:

> On Mon, 2024-04-08 at 12:54 +0300, Ilpo J=E4rvinen wrote:
> > On Fri, 5 Apr 2024, Niklas Schnelle wrote:
> >=20
> > > In a future patch HAS_IOPORT=3Dn will disable inb()/outb() and friend=
s at
> > > compile time. We thus need to add HAS_IOPORT as dependency for those
> > > drivers using them unconditionally. For 8250 based drivers some suppo=
rt
> > > MMIO only use so fence only the parts requiring I/O ports.
> > >=20
> > > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > > Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > > ---
> > > Note: This patch does not depend any not-yet-mainline HAS_IOPORT chan=
ges
> > > and may be merged via subsystem specific trees at your earliest
> > > convenience.
> > >=20
> > > Note 2: This was previously acked here:
> > > https://lore.kernel.org/all/2023053050-prodigal-shine-4d1c@gregkh/
> > > Given this was almost a year ago and didn't apply then I didn't
> > > carry the Ack over though.
> > >=20
> > >=20
> ---8<---
> > > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/825=
0/Kconfig
> > > index 47ff50763c04..54bf98869abf 100644
> > > --- a/drivers/tty/serial/8250/Kconfig
> > > +++ b/drivers/tty/serial/8250/Kconfig
> > > @@ -6,7 +6,6 @@
> > > =20
> > >  config SERIAL_8250
> > >  =09tristate "8250/16550 and compatible serial support"
> > > -=09depends on !S390
> >=20
> > Why? Your changelogs gives zero insight on this change.
>=20
> I used this for compile testing since I build on s390 natively and this
> would have hidden the missing HAS_IOPORT dependencies I'm pretty sure
> it was added because of the I/O port problem too. I'll either add to
> the commit description that it is no longer needed or drop this. Any
> preference?

Okay, we might never know the reason for sure if that's old enough.
I think the best approach would be to put it into own patch so this=20
guessimation is limited to a single liner patch instead of it being=20
hidden among the other clearer cases.

--=20
 i.
--8323328-270381069-1712590779=:14302--