Received-SPF: pass (google.com: domain of linux-kernel+bounces-135712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 8 Apr 2024 09:54:47 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: <ppwaskie@kernel.org>, Dan Williams <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-pci@vger.kernel.org>
CC: <linux-kernel@vger.kernel.org>, PJ Waskiewicz <ppwaskie@kernel.org>
Subject: RE: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup
 failure
Message-ID: <661421574048c_2583ad294d0@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240407210526.8500-1-ppwaskie@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240407210526.8500-1-ppwaskie@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DkR3hscpPUwUtOH9sXqiCgE2cH9CA5E6QcxmG+0gFBRAHffRvb7/7o3uLEJi?=
 =?us-ascii?Q?0z1jlhKa8cCzvDxHmdcL6D76KyE0V9WbUw+s7UsS2yRqwi7NZ5wxwRoBM9j/?=
 =?us-ascii?Q?sHPd3I6MySuPzWFfjfh1X4DBmkAX9YsFtiI83Ox8lixg4d3SOCIzVdyd2mNt?=
 =?us-ascii?Q?qmbJMXSq4LMewzXp3gc+IdNN1pZqVqgDXl+zjys+2D9Uy3RUX1AqzaHYk+T3?=
 =?us-ascii?Q?vqDHWTm4FYNMJhI5j1vVwryI+pWL+bGs1sfRhj3VFgjbmDPhyqO+LAE+UwVf?=
 =?us-ascii?Q?7Ht9Ha/I3zWhQyUconwkh0zg36Q9/5TLHdIcXzL+j+FpHZR6swgOLSfwEWQE?=
 =?us-ascii?Q?LIyMTYdprYssrKFz+pz5ufQe4LN2TRTv4Bh+cXAQoxSEdEIdrMrPW1a0LCoE?=
 =?us-ascii?Q?kM7qD4mCCwAl8jTa7lUay6SdncDENnMz2eLsE2X/G6s6O5yjBAl7pOmcS/Zr?=
 =?us-ascii?Q?XTqC7myzdsnoW77Bbm0+eSu57c5U0/hVa375dfc4TA7Hvf/dyXA6XXivgP5v?=
 =?us-ascii?Q?qoWttiwlBLaIBDB/p8KLDa9jio+789EUOCsgTLrLVPylyE1sIz8b15jFuQjS?=
 =?us-ascii?Q?VCoqD1WHIX+4TwU1iNN3ri3/+qYlaG2urScQSWmxjE4lU+We3h37CMixTi1f?=
 =?us-ascii?Q?HaUHEwrWC1mHwys4G57r0TVzixI4Z16RVXYbauP/1PF73mHcAbgUHKsGK09I?=
 =?us-ascii?Q?Xc69uc4kR9phufPGRBV95X/av4ESwriQXtDqVl35ALgOHntcQLKo/wOkDv6y?=
 =?us-ascii?Q?WUHMYz+O5wRkbGkJGG+xaNMfdHi+ODYb0AGgM4ibSOTmi4Quth0svzDjFHF8?=
 =?us-ascii?Q?g9lFzmSqAXe5rTRphvVWiaTKMM82kGRDkRhXuIMhckLe921czWmuOrJS1KSq?=
 =?us-ascii?Q?xyXkComKbTaxqnrIA1ejlSBcFnDK9IrECruQvjuQpOsFi7L7MPyj1adfu9C+?=
 =?us-ascii?Q?4OMaNnPGKoLOYTgrr6Jgc2PqqtsPP4f5qIt76SvqOUMrAkqbWc+HvICJsf/V?=
 =?us-ascii?Q?5BOnB5X+bxeLmfUeDKVjeo+csYNNAcpRpv0FpT7QyP23nL+eeSEVdEeXl0gU?=
 =?us-ascii?Q?7+TukJBvMUdS7Q8Asb6MgSYlG6E7l1m3iCvz31ut2FIINcv8tEe2InEI2plZ?=
 =?us-ascii?Q?4o6GfJ/shkhLV8dhlQCKvgRz59Hgsoi7UEmWfOPppTx1P0c0hnmJFqEnENYG?=
 =?us-ascii?Q?LMQHVS4iNvnmPRz6II2W3HwYwDMIeCTQ0yM4zxLIw3XJNgivCKJAzoBp7bQo?=
 =?us-ascii?Q?Xh2fCRBwsUeYk5EMOx7haaQEKgvjFO2qaXBaCEZWO0zKIXYaH7z/A/VrWWyT?=
 =?us-ascii?Q?YlWXaFjx1fMyjCPId8OHWHhEBzJY9NxThgGduSD1MOn96ore22fwoPd9FWuu?=
 =?us-ascii?Q?UaibUYkGyBKjo9r3QF8Tfi64PJ/82ezoJ3un+Qx8OymVicR0HIAeKX1vMeRP?=
 =?us-ascii?Q?Bf1SENGVsDavXm7lgWH/pl3pMmhdJfasUd0ICXgNk/1WoCUaB7nt0242T8nV?=
 =?us-ascii?Q?Gc925iyZrCFZYpLZn9NX8gj2aVYhDBxh+1xPwZRiyKX8IhWqF61tHR7z9bmx?=
 =?us-ascii?Q?xxSwrzqKpnae1BwPQWWstpWqXAS5HT+UcRbwc5//Z397hH/OlH/q/6MvCkOU?=
 =?us-ascii?Q?iQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd16d068-babb-49fe-4aff-08dc57ec9a47
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 16:54:49.3123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zaYSvhPV6tOumBAjG8/eI6qKDSiAK8dPBV0R/bjEoImVu5GcZtJWbAU3QvM5fmMzYLYNOLo4OWWIBkhLeqqfgwy+olDtMsJB496BNosLxck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8156
X-OriginatorOrg: intel.com

ppwaskie@ wrote:
> From: PJ Waskiewicz <ppwaskie@kernel.org>
> 
> Currently, Type 3 CXL devices (CXL.mem) can train using host CXL
> drivers on Emerald Rapids systems.  However, on some production
> systems from some vendors, a buggy BIOS exists that improperly
> populates the ACPI => PCI mappings.  This leads to the cxl_acpi
> driver to fail probe when it cannot find the root port's _UID, in
> order to look up the device's CXL attributes in the CEDT.
> 
> Add a bit more of a descriptive message that the lookup failure
> could be a bad BIOS, rather than just "failed."

Makes sense, but is the goal here to name and shame the BIOS, or find a
potential quirk workaround? Presumably we could fall back to parsing
_UID instead of a string and then get some guidance from said BIOS about
how to lookup the corresponding ACPI0016 device from that identifier.

In other words, I see this patch as a warning shot of, "hey,
$platform_vendor if you
don't want folks to RMA these platforms please tell us how to do the
association Linux expects per the spec". Otherwise, this can escalate to
a loud WARN_TAINT(TAINT_FIRMWARE_WORKAROUND...), but I first want more
details from this platform like an acpidump and the exact error code
acpi_evaluate_integer() is returning.