Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1490747lqe; Mon, 8 Apr 2024 10:14:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3PckAoF8piZ6Dr4bo5D54FPNFCpiThY/kdtmvb4K33ZVn3p9GjgCmUJmKBvd4X0AvBIBoTYvXNB18mdA2bLizBSmjI3MIaz2P4k1mDw== X-Google-Smtp-Source: AGHT+IFMSR16MZMOyK5GC8Dh0lzpcV7mMdPrmywV4Ocuebr50GxZ/r9AqNDC5d5fkhrTUblz+PH1 X-Received: by 2002:a50:9e48:0:b0:56e:2464:7c4b with SMTP id z66-20020a509e48000000b0056e24647c4bmr6167786ede.10.1712596497009; Mon, 08 Apr 2024 10:14:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712596496; cv=pass; d=google.com; s=arc-20160816; b=ykCHcsd/YyS3QfMdil2ERz6BJW1da1HCgBc4sCfrIV8XVGbVLcQLHKDgx9WlnF4eEH 6lGM9ztJi7A+yZmQGV6EJp60i9bGSk0rcq8y8c8TxofqlWwgbF/NE4hjzaw/l+fEjVI+ 2S1Z22NsAt6MfkwJupNQN5MegoaR3dkxQaQJPLE0UzGX/2eq2BIzdG/ddPYy/RwTALbO 1BLqjm+j8HfYq4EuvwkigDqwNA7U7gAVQLlbxncleANukQt5m7zK2WoOhNeZ1JmDgvtM vNGWmR5FviVCpy4Qjldyow7zA9MwihqDFqnDO5fanMzAbf7746MloNwznI3128/Oeb1T 4ugg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=MMK6LDRIXHQaIEX/xSO/ytOm4Z0nzdBmVfF6/7CVjLs=; fh=qr8BMYNRhDggzCEpZhsq/6+EHFb1Je9j7SBymWUhjiM=; b=AHiZUWZVu68zxm6aLy9m9F5hlMWpIq9zXlbkPK0Rbo60LoiMiruGy7PoPIat11D4tC A4YibH0pnZdAb7kGUC6occTPRC8NPuWJxVaIMBrbMNuDps9u88WgYq2rR5fOcwx8+K2Q GHlqbdxPNFKDeGgkOi6ECD2A3qWK0Yd4T4xODyPd02SZKVEz8qqFdtR0iz4wMZWNHAH8 ofEQ7SBbhIfUHWDGAgqLTxvhr/xGmnpX3rxjWp5HPn7KKjPfogUs+8/vzciwfgRanZCW 4DJ5UntMsHszhYOc1ulOErZhDHNmOA/QTcgole0/Tarb5YPvjUjFHQ+BTkZUkxh2mEJi UoCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TR2e+Ocw; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-135732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135732-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e30-20020a50d4de000000b0056e0ddc1796si3773942edj.29.2024.04.08.10.14.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 10:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-135732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TR2e+Ocw; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-135732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-135732-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D74311F21BFC for ; Mon, 8 Apr 2024 17:13:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5563014388F; Mon, 8 Apr 2024 17:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TR2e+Ocw" Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6CB142906 for ; Mon, 8 Apr 2024 17:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712596374; cv=none; b=a7C9+xQm8xBPg3VUV0AR+reDNAHRUpesxGRK2kerahJ+3la1JEUN1Bi/h8OoflaOimC/kFCC1D5D9Tt6mbHj8PyjrW3+TbaJjyr6O+EfrTTWvXbCBryTchcsLsi9hYSseMrd1z/u1n+JQdYJ6Mwk5h0b1UryS1ki/s5FAZP9tTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712596374; c=relaxed/simple; bh=MMK6LDRIXHQaIEX/xSO/ytOm4Z0nzdBmVfF6/7CVjLs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=HCsbP7iuaCco32XKxMkFxZYZPB876MgyuHRLHVlgNg3HWa1cvMmMUwaA4+PgiKHyJvIBnjQ8dr1kzAYvOalvNu8tO2hafSM6EnCaVZ1Mu1re6EoJwDZF4GNh2mFXvsoZOoOGitehpSr+sAlIQ1AACQi5yCN/7pYNR9uJ3iiQu+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=TR2e+Ocw; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a51ddc783e3so132696766b.0 for ; Mon, 08 Apr 2024 10:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712596371; x=1713201171; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MMK6LDRIXHQaIEX/xSO/ytOm4Z0nzdBmVfF6/7CVjLs=; b=TR2e+Ocw6lPng4KXMXumyQkqTmEiCkd2zreUEAei16Ih6w7kiVLQVgWipF2wOTVD71 fQ7T/DhGv9GcykbvAi7jsLl9kn5ZUeH1Xn+3fef9kjRpXLUwIO091HoxRDZP/o69uYD2 S3WOph1iYmm6nZcXapoVTVrof0NQrMJnRGLeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712596371; x=1713201171; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MMK6LDRIXHQaIEX/xSO/ytOm4Z0nzdBmVfF6/7CVjLs=; b=wJL2wR3PnF5YiEHJKqTX+8lB45lLG5dixktntEbZY3ftQltfMtQgda0joQSjFuuPDA nbF9Vk6vhrS9rTG++X+K+nkUEGF3BMpgFgGktYijNADf0pR4dKVdV0W3PG/oa+K8X8MM dqW7k3UrgordI2vhUJjJSsUHEqNuwTRJTbeyXD3HKsGFSUSlkIRVD8i3At8Q9AdZ7Gd3 NCMCXXLj07R4zHVutoQ7NaZCAL30naKtU+vnyF0JQF3GwYGt3UXQLXAyTr0nvEelIK4j s+wNPAzZpmPYvkSOFs4doVRdRnZ4Sf35rNN/zH44J0HQ7VMKWx1EFWjuNq0V+IZXBjhP OAUw== X-Forwarded-Encrypted: i=1; AJvYcCXxuOfZ1qhegLnx08E9rylZmF/57L3ES5rfQQ3F0kUHES8UNazLElPUusmneJ7J4MSJd96EGMcF5QyRQj0mlfYT8H26kCzq3IW1c+Jr X-Gm-Message-State: AOJu0YwGI/B2Vo6AfYj5TRvc4v4CxJC480ERj8SILq/JUrIcwvGLynz4 y7KAM6ffWl0eGJbXzaqqUvjwpRSv5DLb4c8x1GP/3YW/1ad1CPAQIPkmPNAiNPqJr9vXcEY6zYN HEg== X-Received: by 2002:a17:907:7288:b0:a51:cbbf:5214 with SMTP id dt8-20020a170907728800b00a51cbbf5214mr3410732ejc.33.1712596370967; Mon, 08 Apr 2024 10:12:50 -0700 (PDT) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com. [209.85.128.54]) by smtp.gmail.com with ESMTPSA id hj13-20020a170906874d00b00a51c1b325e0sm2965972ejb.211.2024.04.08.10.12.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 10:12:50 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41550858cabso31556765e9.2 for ; Mon, 08 Apr 2024 10:12:50 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXbyhXxuuEaHFhGhjycZcb9xglGftksmoW6gkICLSxvZvVpkXiVl0RdHkv2BhTDzXcpJr/DzlTz1dOvNv4SzW93WZ9yzQH5heMebPXX X-Received: by 2002:a05:6000:1566:b0:345:fa50:ba8e with SMTP id 6-20020a056000156600b00345fa50ba8emr1333371wrz.37.1712596369615; Mon, 08 Apr 2024 10:12:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240408151700.1761009-1-festevam@gmail.com> In-Reply-To: <20240408151700.1761009-1-festevam@gmail.com> From: Matthias Kaehlcke Date: Mon, 8 Apr 2024 10:12:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on failure To: Fabio Estevam Cc: gregkh@linuxfoundation.org, frieder.schrempf@kontron.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 8, 2024 at 8:17=E2=80=AFAM Fabio Estevam w= rote: > > From: Fabio Estevam > > In case regulator_bulk_enable() fails, the previously enabled USB hub > clock should be disabled. > > Fix it accordingly. > > Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock i= nput") > Signed-off-by: Fabio Estevam Acked-by: Matthias Kaehlcke