Received-SPF: pass (google.com: domain of linux-kernel+bounces-135814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Mon, 8 Apr 2024 20:27:49 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, linux-tip-commits@vger.kernel.org,
	Julian Stecklina <julian.stecklina@cyberus-technology.de>,
	Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/boot] x86/boot: Move kernel cmdline setup earlier in
 the boot process (again)
Message-ID: <ZhQ3JSXT05Kv/RpM@gmail.com>
References: <171169867308.10875.15117897441999380027.tip-bot2@tip-bot2>
 <20240408181732.GCZhQ0vGSfP3Gf8tDW@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240408181732.GCZhQ0vGSfP3Gf8tDW@fat_crate.local>


* Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Mar 29, 2024 at 07:51:13AM -0000, tip-bot2 for Julian Stecklina wrote:
> > The following commit has been merged into the x86/boot branch of tip:
> > 
> > Commit-ID:     4faa0e5d6d79fc4c6e1943e8b62a65744d8439a0
> > Gitweb:        https://git.kernel.org/tip/4faa0e5d6d79fc4c6e1943e8b62a65744d8439a0
> > Author:        Julian Stecklina <julian.stecklina@cyberus-technology.de>
> > AuthorDate:    Thu, 28 Mar 2024 16:42:12 +01:00
> > Committer:     Ingo Molnar <mingo@kernel.org>
> > CommitterDate: Fri, 29 Mar 2024 08:19:12 +01:00
> > 
> > x86/boot: Move kernel cmdline setup earlier in the boot process (again)
> 
> ...
> 
> > The order is now:
> > 
> > 	setup_arch():
> > 	  -> Assemble final command line:
> > 	     boot_command_line = builtin_cmdline + boot_cmdline
> > 
> > 	  -> early_cpu_init()
> > 	    -> early_identify_cpu()
> > 	      -> sld_setup()
> > 		-> sld_state_setup()
> > 		  -> Looks for split_lock_detect in boot_command_line
> > 
> > 	  -> e820__memory_setup()
> > 
> > 	  -> parse_early_param()
> 
> So that thing. Should we do something like the silly thing below so that 
> it catches potential issues with parsing builtin cmdline stuff too early?

Yep, that's a good idea.

Acked-by: Ingo Molnar <mingo@kernel.org>

	Ingo