Received-SPF: pass (google.com: domain of linux-kernel+bounces-135884-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0c903e3b-093e-461a-aa70-c2d58fc6d82d@amd.com>
Date: Mon, 8 Apr 2024 14:47:52 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA
To: "Luck, Tony" <tony.luck@intel.com>, Yazen Ghannam <yazen.ghannam@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>,
 "Avadhut.Naik@amd.com" <Avadhut.Naik@amd.com>,
 "John.Allen@amd.com" <John.Allen@amd.com>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-17-yazen.ghannam@amd.com>
 <SJ1PR11MB6083683CAEA79F935BFA1B31FC032@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <SJ1PR11MB6083683CAEA79F935BFA1B31FC032@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUF1VWkyc0swRytGS3gwZCtoakN6VUNaY2dFRjI2L1FMcnZ0U2laMWRZUk1M?=
 =?utf-8?B?YytCYndzenhGeHNIVnJOOTNrZ3h4M2J2ak93SjJtV1pGQ05pbk9xTmVWQkI1?=
 =?utf-8?B?U0NpVHRPMWpQWExDRml5a0U5WUIwdG9ZS01VaGU5bVJzU3NUcXpuWU9xcDF2?=
 =?utf-8?B?VVl2UXdrbmhhRUhXLzF4Rk1FY1o4cExhSjU3SDRFMnZjendmRWZMUDZxZThp?=
 =?utf-8?B?TVRaK09UbHlGd1ZNQmZleTQxUEZlb3RKd1dhM29ZL3o0OEpzWVVTdFJBQ0F1?=
 =?utf-8?B?Y1NYZDhwOFhtL1ljUW8vTXJqSVl2TGFIaXdqMmdIdlE0SkFYQmUwOVZSVWVB?=
 =?utf-8?B?amNkSDlqdWN5dk9uTDF2VTJsaTVQS3k4NlNpTFBhM2o0bC9DOHAxNFM2WEJz?=
 =?utf-8?B?cFZ4T0o0REtYRVhUc0h1eHZMRGdoYVl5K3p4T0VJcDRjekx1UFh4TnA3aGNS?=
 =?utf-8?B?YkpsQ0VLSnNwTFZOVGY1WkVPNzVtalB6aXF6MlovNmV0NEk4RnVWMjExSTlI?=
 =?utf-8?B?N0dzZnp4Y0E2UTF2R2lSZHVYUkVITTREaE9XRlMvWVltVDdLVTFZSzFYNUkz?=
 =?utf-8?B?dndpSm5FVGNCOGYyejNzZ2E2UmtxSUJNbkh1Ny80cG0zZWV1Nitla3ZSOHMw?=
 =?utf-8?B?RSs5K3R2V01mWUJIZ1FjSER4STFZV0tiaEh0RTYzUGRwWTFUcnNZUW42Vytw?=
 =?utf-8?B?SUZyaVZxLzErNW5PRzMrblZsbEJPNzArL1hjcFhlS1BVUnJJK0hWQVJIcm55?=
 =?utf-8?B?NCtJZ0dxZjB3WkJHcnNNeXpQZG94Q1hUQm52MmQwWGcwM1lIcFFjWldnR3ps?=
 =?utf-8?B?QXBLV0J2bGJnOEZ6ZzVBeUh5eGRxYjBRODkwM1pMWXFsY2FDTDRLNTgwQjJz?=
 =?utf-8?B?L0dFcHdqVTYyVk5SUnYxVGdaUEdXTXpjWGV0blpzUmtJT0VuZjdKSHlUdktn?=
 =?utf-8?B?R0dPdXNvYlR0QnFOWFVKRCtDTFhiZjNDdVY0YU84OFcyZGNUa0lRZ2k0azB4?=
 =?utf-8?B?MWJqb2UxR2k0YWtTMWNZYmpTNDl3Mms4VllyQnNaVzlWQnFmVldDcVdLZU8z?=
 =?utf-8?B?QWhxc25lN0I5aThaVi9IQmJ6bkVXQm9EbVA0MHZDdXZOd2x3RXJqRkxaTE1F?=
 =?utf-8?B?N0lQUThJdVRKK2JjWktGVDZtUUhPWTNHenljTnNyVUFwZEVqYmd3ZEFXajFQ?=
 =?utf-8?B?SzFKV0N6cS8vbm4wWEZMNlZYV0lOR0lzM2wxUkVuS0U0Z0Zhemkzc25qc2I1?=
 =?utf-8?B?b1B4K2ZSN25JZlFXOUZMNllLOVlSTHUvMGt0R2laUGErWm9RNUJGejR0L2Zm?=
 =?utf-8?B?RkJxc1NhZUxYenFpMElDbEZwR3c3T0FoZS9sL0tUb2k5Q241UVNNS0pMRC9p?=
 =?utf-8?B?U0w4aExjVHQySjJlY1J6ODN1RmpJTWg3WHJJMTVidUgrUDlnS0R3SFhCeTd2?=
 =?utf-8?B?cE9ZczVSR01MVkkvM1ZvOHJtOVVHQkFUZUZBbmtzMGkvU3JJNWFvTXl1RDhT?=
 =?utf-8?B?cllubUFSMTNIU2NJcEtnT05ZZHZTakVPS0x3Sk5PZzJuWHhXZWJmZzZ2R2ds?=
 =?utf-8?B?Z0tWcWU1aHBwdEFxWjRwdG50c0g2VlVjcVZ4djNmVjZ4T3Z5T0JZaDVTZkI1?=
 =?utf-8?B?cmUrWjdKUElCQ3ZuMFA2TmlBcGdZZ0wvTC93LzhlNHU5cWt1SHloYVIyaE5m?=
 =?utf-8?B?WlhUZzZLRklqakE5c1FGWXYxbktpOERnVGlnK1pXb1lKZmp1WUFBZzVjUVlq?=
 =?utf-8?B?VDYvek5iWjdwUTV6Nzh3Wk54VW9Hbmw4djE2bldvQU1uRXdxTkp4ZG5COUhn?=
 =?utf-8?B?RU5qTHBselpBU1IyUkFzbVh1Tjh4NXVtdUhuZkVsb2F4eDhyVVM4N3RFaCs4?=
 =?utf-8?B?QUhrUHNTS0xVa1hFV1p0V2NiT01tMEZmUkZNdG95WnVHNDBlNmI3U1JOZkpN?=
 =?utf-8?B?ZXBjbmtBVm5MdFFoVU1Kc1U2Z2xaclJyeEhwWml4VVB4QTJZa1pUOTVrNVRt?=
 =?utf-8?B?eG1rcWg2WUthVkdKRGt4REdXcFRSQjFzZmhkc1FIUk5LUEFpRDhOZWhBU0N1?=
 =?utf-8?B?ZDBac2krTzNJMHpKRUpuSnlEOEJvdW1rT0NSTXJLdldSc0ExTzdnRDJiaTdH?=
 =?utf-8?Q?godRMJPCw8N8V7MkMvaW4R5Xw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7784ecbc-79dd-415d-2df4-08dc5804c8c6
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 19:47:55.3023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v3JICGSwoSAjXDZ0MRxhPwqGk9wk8nGAoSqlhM22YxsH2N8OiWbKpAS5SkOPoXouJRIYYgX1hYWHNyJjnC21AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9157


On 4/5/2024 11:06, Luck, Tony wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index aa27729f7899..a4d09dda5fae 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err)
>>                       pr_cont("SYND2 %llx ", err->vi.amd.synd2);
>>               if (m->ipid)
>>                       pr_cont("IPID %llx ", m->ipid);
>> +             if (err->vi.amd.config)
> 
> This is in common code. If other vendors start adding their own stuff to the
> "vi" union you might incorrectly print this.  Add a vendor check before looking
> at values inside "m->vi".
>

Do we really need an explicit vendor check in this particular instance?

Below is a snippet from __print_mce() after applying this series:

    if (mce_flags.smca) {
        if (m->synd)
            pr_cont("SYND %llx ", m->synd);
        if (err->vi.amd.synd1)
            pr_cont("SYND1 %llx ", err->vi.amd.synd1);
        if (err->vi.amd.synd2)
            pr_cont("SYND2 %llx ", err->vi.amd.synd2);
        if (m->ipid)
            pr_cont("IPID %llx ", m->ipid);
        if (err->vi.amd.config)
            pr_cont("CONFIG %llx ", err->vi.amd.config);
    }

    pr_cont("\n");

All of the above registers including the newly added config MSR will only
be logged if the smca flag is set in mce_flags.
Doesn't that already serve as a vendor check of sorts?
Something that I am missing here?

-- 
Thanks,
Avadhut Naik