Received-SPF: pass (google.com: domain of linux-kernel+bounces-135890-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240328140512.4148825-1-arnd@kernel.org> <20240328140512.4148825-6-arnd@kernel.org>
 <u7hc4tkkwr5eua2p4bdetox2lqtawzb6dwimuipejhoiitbzhh@yu3e4sljhgxg> <8b771062-7ce9-4b00-a488-91b231a1476e@app.fastmail.com>
In-Reply-To: <8b771062-7ce9-4b00-a488-91b231a1476e@app.fastmail.com>
From: Justin Stitt <justinstitt@google.com>
Date: Mon, 8 Apr 2024 12:53:04 -0700
Message-ID: <CAFhGd8r02jSj5jxny-6Jpr5et75MQzkG1FeLZC4ftu9V7KAn3g@mail.gmail.com>
Subject: Re: [PATCH 05/11] test_hexdump: avoid string truncation warning
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>, linux-kernel@vger.kernel.org, 
	Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Apr 8, 2024 at 8:38=E2=80=AFAM Arnd Bergmann <arnd@arndb.de> wrote:
>
> You are correct. I do understand the nuances between strncpy()
> and strscpy(), but I failed to read this file properly.

Arnd, I know you understand these differences. I did not intend to
patronize, so sorry about that. My intention was to provide ample
context for future travelers/reviewers. These replacements can be
tricky sometimes.

>
> I'm still not entirely sure, but from my current reading, I think
> we can just use memcpy() to replace the strncpy() here, as both
> the input string data_b[] and the output real[TEST_HEXDUMP_BUF_SIZE]
> are sized to cover every possible 'len' value. This also follows
> what Linus did for the other original strncpy in b1286ed7158e
> ("test_hexdump: use memcpy instead of strncpy()").
>
> I've reworked the patch based on that assumption now and rewritten
> the changelog text accordingly.

Great! This helps towards https://github.com/KSPP/linux/issues/90

>
>      Arnd

Thanks
Justin