Received-SPF: pass (google.com: domain of linux-kernel+bounces-135905-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 8 Apr 2024 13:27:04 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Zhaoyu Liu <liuzhaoyu.zackary@bytedance.com>
Cc: ryncsn@gmail.com, nphamcs@gmail.com, ying.huang@intel.com,
 songmuchun@bytedance.com, david@redhat.com, chrisl@kernel.org,
 guo.ziliang@zte.com.cn, yosryahmed@google.com,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: swap: prejudgement swap_has_cache to avoid page
 allocation
Message-Id: <20240408132704.f966adc8d3928df4d3b8c0a9@linux-foundation.org>
In-Reply-To: <20240408121439.GA252652@bytedance>
References: <20240408121439.GA252652@bytedance>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 8 Apr 2024 20:14:39 +0800 Zhaoyu Liu <liuzhaoyu.zackary@bytedance.com> wrote:

> Based on qemu arm64 - latest kernel + 100M memory + 1024M swapfile.
> Create 1G anon mmap and set it to shared, and has two processes
> randomly access the shared memory. When they are racing on swap cache,
> on average, each "alloc_pages_mpol + swapcache_prepare + folio_put"
> took about 1475 us.

And what effect does this patch have upon the measured time?  ANd upon
overall runtime?

> So skip page allocation if SWAP_HAS_CACHE was set, just
> schedule_timeout_uninterruptible and continue to acquire page
> via filemap_get_folio() from swap cache, to speedup
> __read_swap_cache_async.