Received-SPF: pass (google.com: domain of linux-kernel+bounces-135925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Andreas Dilger <adilger@dilger.ca>
Message-Id: <4E5BC096-0EEC-467E-8C6B-276CF5BED332@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_63F7C3C4-1B33-4AA2-B964-892D266A9523";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: =?utf-8?Q?Re=3A_=5BPATCH=5D_ext4=3A_block=5Fvalidity=3A_Remove_un?=
 =?utf-8?Q?necessary_=E2=80=98NULL=E2=80=99_values_from_new=5Fnode?=
Date: Mon, 8 Apr 2024 14:54:27 -0600
In-Reply-To: <20240402022300.25858-1-zeming@nfschina.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
 Ext4 Developers List <linux-ext4@vger.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
To: Li zeming <zeming@nfschina.com>
References: <20240402022300.25858-1-zeming@nfschina.com>


--Apple-Mail=_63F7C3C4-1B33-4AA2-B964-892D266A9523
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 1, 2024, at 8:23 PM, Li zeming <zeming@nfschina.com> wrote:
>=20
> new_node is assigned first, so it does not need to initialize the
> assignment.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> fs/ext4/block_validity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
> index 6fe3c941b5651..87ee3a17bd29c 100644
> --- a/fs/ext4/block_validity.c
> +++ b/fs/ext4/block_validity.c
> @@ -72,7 +72,7 @@ static int add_system_zone(struct ext4_system_blocks =
*system_blks,
> {
> 	struct ext4_system_zone *new_entry, *entry;
> 	struct rb_node **n =3D &system_blks->root.rb_node, *node;
> -	struct rb_node *parent =3D NULL, *new_node =3D NULL;
> +	struct rb_node *parent =3D NULL, *new_node;

This one is more compact and doesn't have the issue with
the "cleanup" label at the end.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

Cheers, Andreas


--Apple-Mail=_63F7C3C4-1B33-4AA2-B964-892D266A9523
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmYUWYMACgkQcqXauRfM
H+COAQ//fd/+Y1hjlh0ZAn9FQop1SO9vmwog5pcjqcyg+JKlMJOu0Fi1UkgsHknj
K27qtRDzkX9BeqjKmzAykyVKNUrORnycZeSAz3vx3xTJN+NLjRkggeXX7EvqeZH9
J82FO2IA2TQSY0d87hXyfXPEqNlIqw11jLL2QV76vF68THRgDiZ5pt29qYOdPvx0
CJDtxEqh7xfspPy1clj7JbHjcJdVy9CQnUW+3sxm/SXV5N5jMopl6UcUPMhdQCTr
sCOgngYhBw5KNDBH/hui+0KruqGW6+rwVxvKs08E7NMMc6dNXGF0LxUhpAF7CXGm
HyJimemGhsw0dLzUzEQgQlv8/uFPs8dzRRCBgUxvYNPFkZA6Y8zCHne6dObcR1oR
oWVgGbh183tZRoREFQek1leCiAiA5e4sW/xxEUFDsVE0WCLQiSRiHRPJPwerkATn
WiB9NFOopFETY4FtKPq5OxOv0ovzmDezZLaSl7/o3kWdy7kQMz8xNrN+4X+i2W+P
uUs8oVsd3PH5Vt6ypRIKJVzszMeg6qrbXHgqMUZSzbpPiGoV+0aJ68O1xijG8WOZ
+1abvJjvyH/NxDmoOgae+Mv+fYXThSS8EqMths0y89wfCobGUO2FttusRwSicq1p
WyG+xYGVZPyBU0k8cVsvXzLuEuwgCR9iN+eWkStVK4YZ7cnSvCo=
=kjFk
-----END PGP SIGNATURE-----

--Apple-Mail=_63F7C3C4-1B33-4AA2-B964-892D266A9523--