Received-SPF: pass (google.com: domain of linux-kernel+bounces-135928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <17264fcc-5db9-41c8-b57c-9bd62ef544ce@intel.com>
Date: Mon, 8 Apr 2024 13:59:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/6] x86/resctrl: Move __resctrl_sched_in() out-of-line
To: Peter Newman <peternewman@google.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, James Morse <james.morse@arm.com>,
	Stephane Eranian <eranian@google.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Dave Hansen
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, "H. Peter Anvin"
	<hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, Juri Lelli
	<juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt
	<rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman
	<mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, "Valentin
 Schneider" <vschneid@redhat.com>, Uros Bizjak <ubizjak@gmail.com>, "Mike
 Rapoport" <rppt@kernel.org>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, Rick Edgecombe
	<rick.p.edgecombe@intel.com>, Xin Li <xin3.li@intel.com>, Babu Moger
	<babu.moger@amd.com>, Shaopeng Tan <tan.shaopeng@fujitsu.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@intel.com>, Jens Axboe
	<axboe@kernel.dk>, Christian Brauner <brauner@kernel.org>, Oleg Nesterov
	<oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Tycho Andersen
	<tandersen@netflix.com>, Nicholas Piggin <npiggin@gmail.com>, Beau Belgrave
	<beaub@linux.microsoft.com>, "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	<linux-kernel@vger.kernel.org>
References: <20240325172707.73966-1-peternewman@google.com>
 <20240325172707.73966-2-peternewman@google.com>
 <e2c479b6-43f0-4e2c-9ccd-2e5f322d1974@intel.com>
 <CALPaoCjWDKM9VYXexDt2+zh2srTotuaErFHXkWzH1w0c_KWDjw@mail.gmail.com>
 <d3ef1a5a-a7ee-477c-8697-d64b91726d91@intel.com>
 <CALPaoCieXQfgEL-7CK2pB5xgrRzTTWBkbic7OXxdKbh-ipWTpw@mail.gmail.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoCieXQfgEL-7CK2pB5xgrRzTTWBkbic7OXxdKbh-ipWTpw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anBHS1BhSkNKQVZjQll5NEtGUEVGNDk2UzJZN1hoaVNXSEtReE5FMmdERXJS?=
 =?utf-8?B?WjMrdEt6d3hYa3RJSTZMbE9TWEo5bEY0NG1RdjEvWHVsUk5wM1ZYdUljemxl?=
 =?utf-8?B?TVlxYWszcDJBN2htYVNjRnZHakxxZGVES1R5TjFHWHBxdWVNYjYyNGVXelhP?=
 =?utf-8?B?bUtWVkdMVTdYR0Q4SWw1bDJVanMrMkEycVIyQUF3c1J5d3dKWmVVOW5scEJs?=
 =?utf-8?B?VXdwTlFrQjIxM1BsSUtGOHBBM1VjamRjZlYrajYrT0t4VnB0NC8xdlNMOXJZ?=
 =?utf-8?B?bXhhSTUvaW5SRmJFL0lWV1hlbEpIZHVvOC9KQjBjTmRta25kL0lhMHpxdmU4?=
 =?utf-8?B?cW0yMjdDdUVETnlXRFFnR3JISGc2KzdrVXJMT2ZhU01RV2NubWt6S1JWaDUz?=
 =?utf-8?B?RVhPd1BQNjFaeWh3T3VhWnFaLzZON0o5Z3YvTktoOW5zZ3lXUUxpNUp4TGRR?=
 =?utf-8?B?c0FPS05GbFdURjlPS2dsU1dlOTdRNnJ0RURmQkgwM0VHYzFyZHY3clk5cE5z?=
 =?utf-8?B?T3U5eVdrS25BYWhGeEdoRlp3SjR3OEZWajA1RSs2Sk8xQUhzdnQ2WU81dm42?=
 =?utf-8?B?WlBYTUQzcmlSTHZ4QmUyZVpUaW5tRnlGZGxPNDdaZWx0cW1TUTE0WmpTbU50?=
 =?utf-8?B?Rmp5d2xvS0p5SkdYaTZOTGdLKys3ckxwMzRSUjVsYWJJLy8yMVlvL3ZFUGR1?=
 =?utf-8?B?TE0rck51OVhJM0MzUUFGcjZ0c2tqRzhwMnpkOWU3SmhsNUczazFvelBTK3NN?=
 =?utf-8?B?TlJ1K1A3ZXhzS2dzM0tNc055RE9PeHluVmV4YXg2TWVSZlhQTHozMDR1M09G?=
 =?utf-8?B?dnRXVGFLRVlwVk1YSnVlNFY3UkdjQ25ENVd0WGxGWCtHNnpsYUxMWFp6TzJN?=
 =?utf-8?B?d2RVNG0vNnpWRWZJNXo1dHg4Q0JWMllDdndxZTZheVhwMEovb2ZTRHJlZ09V?=
 =?utf-8?B?SGxhNWFQWVBsY1BIbE8zc3FoQUg0RG9LOHpuTktzSHFpSFhQYUVDNGI4UVp0?=
 =?utf-8?B?UjMwNDhXZXI5MVpWZWJnZVp2czFieWI1YkR2RGxkYzBNSXdsd2ZnTzFrL2lE?=
 =?utf-8?B?aW13d1hMZ3diUE53ZjYzSmtyWm9LaWk4djdGcE00cW84a1hNcExUaEZOYm5M?=
 =?utf-8?B?Rzk2bks1ZTdnam0xd2drcUZvUjl0TjkyM3FSVDNQS2M4QlRXMVJyL0srZEs2?=
 =?utf-8?B?ZFpya0RZaERiRmxDY0ZHKzdHUy9MODQ1ZFB2OVF1M3BaYURvejRwaTdCdnpU?=
 =?utf-8?B?cnBoNkFPYjl1TkJhRk9vaWlnRFM0ZWxUM2RNUElkNjBBc2Iydy9vaFFWeFZT?=
 =?utf-8?B?RmZBYkgwS1dGSEx1eUhQeUl0cE10Z05QcFdqRHdLQkdZTjUvYlhYVnFWWFZ5?=
 =?utf-8?B?NCtaenNDV0Fsa2ptY3EyZWswTDdJZlpPVndGbmtOSnNXaVF6TEJUQ2p2Sllk?=
 =?utf-8?B?UXJGU1NMM3VVNG9PTFJjTGdYZ1VVbHozdnVBZjdvYTkyZXMvRWV0a3FUcExB?=
 =?utf-8?B?RmFXUDJGZlZwMzcxQVhYeDlFMGN3OGtPcE92dUtVSTJCak51WDc4dmJjLzd4?=
 =?utf-8?B?VG03cGVXem1FNmNwZzB6Vkt6Um9WaFhOWmc3YTFIZjdveXRUT2QvT0pOVHpi?=
 =?utf-8?B?MlU5MmdtcVVUaVJJU2JPSS93UU1GYXF6OEZVeDlhcUQ3bzNZWnBKSTFtL3pN?=
 =?utf-8?B?UWV3TkR5QlI5Z1hTN0s5WHgvMGNGN0h3ckl0RytJcVJmbVZVaGZvY0h1WUlZ?=
 =?utf-8?B?VGdzQldrR3ZjRmpkR3cveVR3M256UG9yUGFrU0x1NkowSWQ3VFRaRDdHWDlG?=
 =?utf-8?B?cmJNbmcvUnZLZVorN1RLR0s1M3EvdVBsNkJkOVZUckg0dENMZTl2TlhsVXJI?=
 =?utf-8?B?SWpyaXpsNFpzdXN6MTR0WlRaTGZPUzdoYmdmdmRUWUJDWEVodnE3V0padUk3?=
 =?utf-8?B?TWNXSCswVE0xNFdMYXd4Q0ZRa284NHJGYmRVMTBLYVdCeEFlc3FJSTh5bkNq?=
 =?utf-8?B?SzRZL2NUcC9Hb2lmK2J3QjdJOGVvaXVTQzlmR1VuN0RpUlRTUkpIeFhaTGNC?=
 =?utf-8?B?OFdyQUtmZlZ5elFJQkxXb1BvTkk1RStYbnQ5T0NLTEJNUGNOV0Z6SHQ4ajkz?=
 =?utf-8?B?bTNnTFZ6MGVXU1p5dDhOK1psd1ZIZExRQjBmaFRnTDRON29lMVlMR1ZLOFZi?=
 =?utf-8?B?TkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f335732-c3bd-4424-73cf-08dc580ec6b2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 20:59:26.8069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pG83n1jRhZKrctHBMNkreblJY1DIn2FQ9t3ExJ5OU9EBJUxx8bzo5ghC81RtSGO9acT1BDbcRq8OaSpUF0rJApk2e57PusYQSRCW7AhTO+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7686
X-OriginatorOrg: intel.com

Hi Peter,

On 4/8/2024 12:05 PM, Peter Newman wrote:
> Hi Reinette,
> 
> On Sun, Apr 7, 2024 at 12:21 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>>
>> I think this needs more thought. rdt_enable_key is x86 specific now and should not
>> be in the fs code. Every architecture will have its own task switch code, with
>> __resctrl_sched_in() belonging to x86 and thus not something to be directly called
>> from the fs code.
> 
> I think we will need to discuss whether __resctrl_sched_in() is really
> arch or FS code following the changes in this series. This series
> removes the explicit MSR access and James has already provided inline

Indeed, I missed how resctrl_arch_update_cpu() introduced in
"x86/resctrl: Abstract PQR_ASSOC from generic code" results in
__resctrl_sched_in() being architecture agnostic.

(sidenotes ...  it is not obvious to me why resctrl_arch_update_cpu()
is not consistently used, for example, in clear_closid_rmid(),
and it also seems a better candidate to be inline within
arch/x86/include/asm/resctrl.h)

> wrappers for the mon and alloc enable keys[1], so I can only assume
> they are architecture-independent in concept.

The wrappers are intended to be architecture-independent, but the keys
are architecture dependent. Quoting the commit you linked to:
"This means other architectures don't have to mirror the static keys"

Reinette
 
> https://lore.kernel.org/r/20240213184438.16675-18-james.morse@arm.com