Received-SPF: pass (google.com: domain of linux-kernel+bounces-135937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240408075052.3304511-1-arnd@kernel.org> <20240408143623.t4uj4dbewl4hyoar@quack3>
In-Reply-To: <20240408143623.t4uj4dbewl4hyoar@quack3>
From: Justin Stitt <justinstitt@google.com>
Date: Mon, 8 Apr 2024 14:21:10 -0700
Message-ID: <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access
To: Jan Kara <jack@suse.cz>
Cc: Arnd Bergmann <arnd@kernel.org>, linux-fsdevel@vger.kernel.org, 
	Mike Marshall <hubcap@omnibond.com>, Arnd Bergmann <arnd@arndb.de>, 
	Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, 
	Martin Brandenburg <martin@omnibond.com>, devel@lists.orangefs.org, 
	Vlastimil Babka <vbabka@suse.cz>, Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024 at 7:36=E2=80=AFAM Jan Kara <jack@suse.cz> wrote:
> Frankly, this initializer is hard to understand for me. Why not simple:
>
>         buf->f_fsid[0] =3D ORANGEFS_SB(sb)->fs_id;
>         buf->f_fsid[1] =3D ORANGEFS_SB(sb)->id;
>

+1 for this idea, seems easier to read for me.

>                                                                 Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR