Received-SPF: pass (google.com: domain of linux-kernel+bounces-135978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7a21c0de-ba59-4e76-8d67-70957f9db581@intel.com>
Date: Tue, 9 Apr 2024 10:37:10 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 12/14] x86/sgx: Turn on per-cgroup EPC reclamation
To: Haitao Huang <haitao.huang@linux.intel.com>, "hpa@zytor.com"
	<hpa@zytor.com>, "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
	"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>, "x86@kernel.org"
	<x86@kernel.org>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "jarkko@kernel.org" <jarkko@kernel.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mkoutny@suse.com" <mkoutny@suse.com>, "tglx@linutronix.de"
	<tglx@linutronix.de>, "Mehta, Sohil" <sohil.mehta@intel.com>, "tj@kernel.org"
	<tj@kernel.org>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>
CC: "mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
	"seanjc@google.com" <seanjc@google.com>, "anakrish@microsoft.com"
	<anakrish@microsoft.com>, "Zhang, Bo" <zhanb@microsoft.com>,
	"kristen@linux.intel.com" <kristen@linux.intel.com>, "yangjie@microsoft.com"
	<yangjie@microsoft.com>, "Li, Zhiquan1" <zhiquan1.li@intel.com>,
	"chrisyan@microsoft.com" <chrisyan@microsoft.com>
References: <20240328002229.30264-1-haitao.huang@linux.intel.com>
 <20240328002229.30264-13-haitao.huang@linux.intel.com>
 <d25dbe76d48a0b6c74fa09b06f1ca3fdf234a190.camel@intel.com>
 <op.2lw8gfg2wjvjmi@hhuan26-mobl.amr.corp.intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <op.2lw8gfg2wjvjmi@hhuan26-mobl.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1N0NURDYmViS0RqajQ2aHp1cGZwcmZ4aEduTnFjb0g3THdzOGxxZVlURE9k?=
 =?utf-8?B?TGNwcmNjV3p1MmVVbGEwcVdtY1Q5SmxSR1hickpHOW51bkZwdUIraTd1MlFS?=
 =?utf-8?B?L2VuQldoWXExSnVmTEhoTWlvSHdkZ00rS0grY1Z4dmZyZ1QvVUxONlFDZlBs?=
 =?utf-8?B?NzVoVjhpWkFUK0prc2hOY2xFV1ozZnNQZ0QrUXloTjF3OVFEeHlQMnhmdk94?=
 =?utf-8?B?Qlhmb1lINURxWGZxK3g0MkxXUDZWR2ZpU3BDQStmclM3SHVLU1kzTmtsVXZk?=
 =?utf-8?B?S3hiRkNMNFlsaytzMlZtMlRSc1d3UWtRYnVKK0F5UUorTnRqQ1gzSDhlREp0?=
 =?utf-8?B?ckJoZ1VPRXR5R0pyTWN6M1Fweng2ZkF2cVFENGRHZG04dWFwdTJlL3FxdDEy?=
 =?utf-8?B?OWQ3bkxIaU55bVBzUENiNklXNzMwZm13UlJMV3ErdFVPWitVZHp0aklVM1FN?=
 =?utf-8?B?d05velhCQWY0MnBLVmxiM2hGd1FHKzB6NFdMZk9vQmVueHlLY0VadU1lZzlm?=
 =?utf-8?B?aFg2M3lCbisxUjdMVlhVZ1ZoRVBPbktScUxQUEJvZkVhSlIrY3Q3NWZtQTZY?=
 =?utf-8?B?SmxHc3VMTTgvMTNvWFRYMDNIY2hmbDBmRFNoUmhkVk1SZ1hqNnBITnNCc1My?=
 =?utf-8?B?aWRiM0V3ZTVRajFMT0RxRjZyWkVvbXlzR0VpYUtydDIxdGV3TmxlSXlzU0FL?=
 =?utf-8?B?Z1BTdWNUdHU3a2JPRUM1dXlOVnhJTS8zZCtVb3lHaTc2dDVteFZESy9KNW1C?=
 =?utf-8?B?Q0tWN1NlM3lRajZlY2ErandqL3l1WWFzb0dtUU9JZnQxU214VDNKZi84aFR4?=
 =?utf-8?B?ZXRoa3V1QWx2WUJGNXl2Y04ydGNEdnphSlVxT3ozallUWkZQY2QxRjRGMld4?=
 =?utf-8?B?UzROWEMvSVY4L3lvYW1ia0dxaS9uVVVrZDRUbDUrR3VKdlB0bWVhZHhSMm9h?=
 =?utf-8?B?SXl4eC9SVGdROWNJOUZ1YWRuMTBJU2I0ckhJSTZnTkRFZU84ZzdpTDd6U3RD?=
 =?utf-8?B?VEJ6bDZtUnMxcWdhQnUvc2UyL1hidFljaEJUeUZOZGVoeUtVTVVxSjdnOUE1?=
 =?utf-8?B?Zms2RG9ETUkwdUxrMytlUG9ZQ0RBQlUwaDZ6RXZSazNod1BFS2JwcXhXTU1C?=
 =?utf-8?B?a2VqZ3ZZSnpNL3F4VEl1QStYZExROTdXSFhZZmlZVnBUZTZLTVM3RDRIeWJL?=
 =?utf-8?B?U1VNYldvUjk0cjM0cDFmcGtRalZvMUhxM1pvWWhVeWU5OWxMUysvdFVhVkJZ?=
 =?utf-8?B?TUlwRzhwbVNjd1dWemhKcnp0YlA1b2Y3eW5JaWFuRGVjRHVNY2p1aTZnNEVO?=
 =?utf-8?B?SitGc0JXQ20zaHFIVTlUNkJHTjBUN1FvOFpuVXh1UlF6WUp2SEZKYkdWcUFz?=
 =?utf-8?B?ZEZwQll0K0pxcFdLN0kvS3Fsd2dGcGZRY3FjUmQxQ1hzaS9nZEdzOTc2YzVa?=
 =?utf-8?B?SXp4K2JwMzhrSFo0V3Exd2hiaFV1cnpxVThoWmpWZHh2WUJXZDJuWmd4OHdm?=
 =?utf-8?B?cVJTNFVtMUlQQUszNUlDczNQbnNORGhlSFpTRkpKOStiWHg4ZjBCZERBcU9s?=
 =?utf-8?B?U1Z2SmloQ2ZGYkZDM1VUVVpTWVFkQTF3VFdmU2hDalo3NEFBaFdjbHo0VHJN?=
 =?utf-8?B?ZUQwM3FYZE5yVDdYZytOeWRvam0vclZFN0ZzS0ZMRHNwbHl6UHp0Yk1jZkdW?=
 =?utf-8?B?Q1RzL0VqMUR5aHFhSUZSeFFmR21Lc1VORkFHZjFPOWdObGFGM09iYVExU1Vh?=
 =?utf-8?B?MGVicHhtMUs3UEVtMGhlei9iRmdaTHkwYlU3WWJzYXNDZWJHbjdHMEo1aWdt?=
 =?utf-8?B?Rllxc3VZUXRNKzVmb0RFMTgrUUNUNllMa1IvU1duRGVuaUtzcDFMOXZINjNq?=
 =?utf-8?B?N0JRSWkrTnBRa2J2QmZTU1h0Q0FLcVFFa2hicGYxYld5b1dnVHUvK0lUTGs1?=
 =?utf-8?B?bGc3TVA0WVpSVldMMXF6QTMyZmovNnZhb1FpR2drdFd5NUwrbVdFMkI3MUxC?=
 =?utf-8?B?aUtiZzNReTBqeHlCb2hxMU5lSXVyYytlMUFUR0F0VUlTTGpGWXg0bHRQWTdX?=
 =?utf-8?B?OTdLdDZWaUVFbDMxZys5cFZseTZEbnRYWFBCcVEvWFJwVExXbDBUUEU1NkVM?=
 =?utf-8?Q?lWzzcJYi+6Vh0bMWL6OBiCVBN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 572f6410-a821-4958-94be-08dc581c7612
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 22:37:24.4924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bukAWrsmjQLh4phC02ACvzzDvvmMjFN4KW7WEUjbxq4+KDaCauLdDFSd+S2rbC4Xxo2uardzIIlxIqszbmyv0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8548
X-OriginatorOrg: intel.com


On 9/04/2024 6:03 am, Haitao Huang wrote:
>>>
> 
> The misc root cgroup is a static similar to sgx_cg_root. So 
> misc_cg_root()  won't be NULL
> However, based on how css_misc() was check NULL, I suppose 
> sgx_get_current_cg() may be NULL when cgroup is disabled (again not 100% 
> sure but we handle it anyway)

Could you help to check?  Sorry I am busy on something else thus won't 
be able to do any actual check.