Received-SPF: pass (google.com: domain of linux-kernel+bounces-136001-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 8 Apr 2024 16:14:06 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: Robert Richter <rrichter@amd.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Xingtao Yao
 (Fujitsu)" <yaoxt.fnst@fujitsu.com>
Subject: Re: [Problem ?] cxl list show nothing after reboot Re: [PATCH v2]
 cxl/pci: Fix disabling memory if DVSEC CXL Range does not match a CFMWS
 window
Message-ID: <66147a3e5c55f_2583ad29433@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240216160113.407141-1-rrichter@amd.com>
 <b0f5e2ce-d39e-4a8e-8f2f-ffa67b604e02@fujitsu.com>
 <24b8b11d-a7ec-42ce-9fa6-8a24701cfe46@fujitsu.com>
 <20240405175711.000032c4@Huawei.com>
 <df850be7-a9d1-4737-bc64-3fb682cd5691@fujitsu.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <df850be7-a9d1-4737-bc64-3fb682cd5691@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rms/2UuPmotwlHofeZACdSMUNpHMXx5PTomKn6rnYCXfNiWyD5O7W80QTYfq?=
 =?us-ascii?Q?ZJwnkF95QqIlRtYrvevhZM3OvbU7U55iWPTx41AzEmgYn4Z1QQ/6Wx9IzjOa?=
 =?us-ascii?Q?zZK5XEsnGcd4KNExHI23artZf/H0EITwhh+b4I3VcEVV3itays0GiBGiSWhS?=
 =?us-ascii?Q?PNyPnDMpO+YiQX5K1kmeeF6rMuzHOL+JFfS9Sjqc+h47xqRs5OpoMP3nOyyO?=
 =?us-ascii?Q?BBBUlfCstdy4TDkJq/h7EIo0LnWgnXLF+Bjof4dj7HFNH1BQMp+vZRt1prMg?=
 =?us-ascii?Q?Ikpx236lheCge6ue0f2xyLKdDyKM/OxVstQoAEQQwng9wNDcHhvtc/pIK6i/?=
 =?us-ascii?Q?JgSG89gpkYL4yPq9GmA0JwwwZ+EGQQ9S5pkdyTktO2JvR0VMmLOhGg1UkJ6a?=
 =?us-ascii?Q?O5+9F1FCBZUBu4Tr48+Iu53flNgw2TPrW/r3w83Bp47Tau5wwHHyj4JfPiKB?=
 =?us-ascii?Q?687MgqFmPGWAUmZ4WgbbFc4atoegt+8uw2N5uvfpJEd4ivL/rrnuU9lvfHCK?=
 =?us-ascii?Q?2bYmgGuklaNWLO5AL2SnEnuIM7pBrDrv2MeNc98B5nSaogWE5Rh0Ntw912tn?=
 =?us-ascii?Q?1Ms/pgkAf9idnTCfU5fPZXXLvFcn6Jtn+zlamGiFJxItebeHrImORFyeA6ri?=
 =?us-ascii?Q?StCyuWNp060luwlZVBAcdWu5VYIz+Nc2g+chP65nbRWrBQJAxjMfsaVk4qJQ?=
 =?us-ascii?Q?tTk18656o1ok6Ilfphy/2sLjFJpQfhD3aa2Z8yMdOqn8lf6hb0ztzpRBoCYE?=
 =?us-ascii?Q?vEC8BTXqfwW5qjhAcTUbN0AbNfK/V8Xp8rjRlHXsfs5dUxQA5DGYUnbgRqfu?=
 =?us-ascii?Q?XX7R84gEdNv/XuPliEnHlbYubldS71ybVW5U16JMCi8nSM9JCV2d6IxtDX44?=
 =?us-ascii?Q?PV03doar+Z5K6L+5wQwafRZpVcHGm+YmwKMs3DuUh0CCyC3i8fdinhcBQ93g?=
 =?us-ascii?Q?APRhiGvZkR7LU8tt+L7H0C0G1KBCvG/97Skfr254TbHuRgDwrpkbk+QWWQ7T?=
 =?us-ascii?Q?UlOhs+720yQcTmEa63jatX30wYecYuszdXLsDfKPmgxu9lp9+NX3dM2qnWoG?=
 =?us-ascii?Q?RZEfDUn3TVrvesqD84/aetFYNQj76TGcG/vIIwjLB4PKue7Kyr6UOeAlofuf?=
 =?us-ascii?Q?eYNQpZwi3anYbgfxttRb9vSonF12Ju5jFYicxY3f2RsHZ2Koebi66f/Sfldt?=
 =?us-ascii?Q?Ztd2QksbiPgvgnZfg/tCeeloQ/H3gSLxATAbZQ+9I9KSJuLyQVKFVxkkQBbZ?=
 =?us-ascii?Q?g0/S9O9pawj2jFm1/dIHDzOvmUYNcwUabh1p/zXtQvvddeXrzP+67UFOCE+J?=
 =?us-ascii?Q?MS/let2yfYqpCvJAtMH2mGRJvNXPc3+T+GMcEkvngjloxjuTLZITejqJczY1?=
 =?us-ascii?Q?sFqXH4Upmvojmpr0x97TgoTeu173BFn3YNb/H6QN6cT5wpUiqKPq/v47Vorf?=
 =?us-ascii?Q?OSUKv+5cmD+OPliQtRzVp6zEbnRpfWKEYTj8vX9ggaX2zdiPgcr48UBX8WTf?=
 =?us-ascii?Q?kgIPLOwS8Idl71vcAkmV6JcVdhuI9nRjvJn7Ki0Yhj4VJ7Lf/wJQvpWkA3kB?=
 =?us-ascii?Q?6zkNsa+Kd03Sy9oYQL87aUxo8G8NeixSQ+JIuSqr78dAaT3byFfYiUTi62AV?=
 =?us-ascii?Q?IA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b42b1e0-1646-4f30-b126-08dc58219804
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 23:14:08.8937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kbZq6bNfUyKQgegK9Wp9jEWM+8y96gPbsnQDFTQvzJ5gbKiyw2TD+ylzxpVJb/uYqhWL6KUkDsw/EB2Q/X+rXOS9/TRksqrNF1euWMwolT4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8444
X-OriginatorOrg: intel.com

Zhijian Li (Fujitsu) wrote:
> 
> 
> On 06/04/2024 00:57, Jonathan Cameron wrote:
> > On Tue, 26 Mar 2024 08:26:21 +0000
> > "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com> wrote:
> > 
> >> All guys,
> >>
> >> In order to make the CXL memdev work again, i have to modify the QEMU side
> >> where it resets the "DVSEC CXL Control" during reboot. A draft changes is as below:
> >>
> >> Per 8.1.3.2 DVSEC CXL Control (Offset 0Ch), Default value of BIT(2) is 0. So is it reasonable
> >> to have a reset dvsecs in QEMU during reboot?
> >>
> >> Any comments @Janathan
> > 
> > Hi,
> > 
> > Sorry it took me so long to get to this.
> > 
> > What are you attempting to do? Use an OS reboot on QEMU to check that the flows
> > meant for BIOS configuration work - 
> 
> 
> There is no doubt that *the OS rebuilds the state correctly* is the OS's responsibility.
> Providing the consistent device state is the *Device*'s responsibility.
> 
> So on reboot, the device should have a consistent device state with a fresh boot.
> My changes intended to let *Device* emulated by QEMU provide a consistent
> device state.

Why? Typically the QEMU CXL enabling is for basic checkout not for
real-world fidelity. If QEMU reboots do not result in restoring the same
device configuration as a re-launching QEMU, why is that worth fixing?
Just document it as a quirk. Now, if it is a simple fix, great, but it
seems low priority given the enabling is really only useful for kernel
development and relaunching QEMU is expected.