Received-SPF: pass (google.com: domain of linux-kernel+bounces-136015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 8 Apr 2024 16:21:05 -0700
In-Reply-To: <ecaf87b40d6da2ca39a5eaf94d2efded2ae3368c.camel@infradead.org>
Precedence: bulk
Mime-Version: 1.0
References: <20240320001542.3203871-1-seanjc@google.com> <ecaf87b40d6da2ca39a5eaf94d2efded2ae3368c.camel@infradead.org>
Message-ID: <ZhR74WgWxO4MQcbl@google.com>
Subject: Re: [PATCH 0/3] KVM: Fix for a mostly benign gpc WARN
From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	syzbot+106a4f72b0474e1d1b33@syzkaller.appspotmail.com, 
	Paul Durrant <paul@xen.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024, David Woodhouse wrote:
> On Tue, 2024-03-19 at 17:15 -0700, Sean Christopherson wrote:
> > Fix a bug found by syzkaller, thanks to a new WARN sanity check, where =
KVM
> > marks a gfn_to_pfn_cache as active without actually setting gpc->gpa or=
 any
> > other metadata.=C2=A0 On top, harden against _directly_ setting gpc->gp=
a to KVM's
> > magic INVALID_GPA, which would also fail the sanity check.
> >=20
> > Sean Christopherson (3):
> > =C2=A0 KVM: Add helpers to consolidate gfn_to_pfn_cache's page split ch=
eck
> > =C2=A0 KVM: Check validity of offset+length of gfn_to_pfn_cache prior t=
o
> > =C2=A0=C2=A0=C2=A0 activation
> > =C2=A0 KVM: Explicitly disallow activatating a gfn_to_pfn_cache with
> > =C2=A0=C2=A0=C2=A0 INVALID_GPA
>=20
> It looks like these conflict with
> https://lore.kernel.org/kvm/20240227115648.3104-9-dwmw2@infradead.org/
>=20
> Want to arrange them to come after it?

Very belated, yes.  Though by the time you read this, they should be in
kvm-x86/next.