Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1667828lqe; Mon, 8 Apr 2024 16:55:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWZvmYFAkrmv45Ie7BlieoJCNzY7LQPKL6lGDJhy0nOQi8tLeOteuUwaQZqEiCkDFGOsDC3bSRVQVg5z9n2FmJbGEueD/h6NE2StKmmlw== X-Google-Smtp-Source: AGHT+IE6lLGJft2M+joa6KZ6WKodXzSumN8HUAXU8fBTRklo89q/7zeSjEzkXAh1MYQxAINzN4lh X-Received: by 2002:a05:6359:5146:b0:183:9ea4:74ab with SMTP id oc6-20020a056359514600b001839ea474abmr11698698rwb.31.1712620516930; Mon, 08 Apr 2024 16:55:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712620516; cv=pass; d=google.com; s=arc-20160816; b=OLvnfi1nAIm+Z6TedUPyj1CS3ndQE59WjQe0GCDuSDWR/xjBwqWVO73TXce4/Jz8rs BdC3SPOpl4+fJYbaGE9nvgGNGuOnCSnSpIeqsa39nTuWpuYbv3f0sjO1Mzcqw8l7wX1G kGP5ZIyhKyrLil6yfcg/z9cdBML4oFVa+J/GgDF6CxFeuoOzEZLGd6Nfl4uhUSexUvAC FDjPGrTQSFwZHnEC/FC2XGEu8RCHN3C0fnX8SdsWY6XNU+GYdf+MblBxR9q1G3LXgwkQ f4NEGLhX8YRdDQHoMzRhEc1KQ/raZM7sXGCKH9parWRJgWRQr3+OTIYGaAQ9jfO+j9tF ieuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tDqBPkxmd7B14/uRg9vwFvYaFbd8qXypV891MvbNPAs=; fh=PvIetY9TNwL7r+U9iHoz7bxg6Y5NetUdCy+yLycdvRw=; b=zrpf1ovM/0sBdgWPZ7EPZ4grw4M9XqiGLBsJH8Sju+XvKWTJj6mxa33cvYKJQ7yXo7 ykObsvezINLO1s5nNFZUyi6BOEX4aLnK7XjpFw+PLvYZ4Xsu+jLk3fIb8NJUpLL163wa fK7XOn2IqZpKg9g9PCoxeTINyS9dNTQ6CmsTA6xxHCyJKWpXYuWYZNTL+juGVcGtfwNy sjvp1zauEx4z9AugO13kS5CaJHnGNW7lzJUFhyby31uLTLolmSA1NerVENyFK1I4Tc1h 9krgfnCUwcvu5BtLeTvBq3gEaQ+PXL0OxMFx+GcxqRcVJaGepqh2ZjDJ5xQbjGx0pICO heog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dDvWjcTW; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-136027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136027-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x28-20020a63485c000000b005f056662e50si7218777pgk.505.2024.04.08.16.55.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 16:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dDvWjcTW; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-136027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136027-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 859B0B22B6A for ; Mon, 8 Apr 2024 23:53:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1DC4D14A084; Mon, 8 Apr 2024 23:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="dDvWjcTW" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7BBE17745; Mon, 8 Apr 2024 23:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712620415; cv=none; b=eDZSx3admhByTii1RGsiIJAYvEAgAP92dCnNfmqT9LcH1BzJjUYWCMZ3aF3rpdMPTToSC5AGF3e7YYVhcv/z6i3RTP4+IiMRvG1k+pFPBfnF38VSFik3+mpp386LKyY62biCO1mB2MjcP9kHE0pt5dHzlLQP5xkzpfp90bU+tmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712620415; c=relaxed/simple; bh=WSCtpelLx1Ea3b5e2lFmBqD4BR4bFylzkoiMqtckb08=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BkxhgXD/tpDfziQm3a6QEP3kr/rSt+Uf0N0onl59npBv7lpibK2NXuX+ubd31gL7dUgc0Ltk76VmT3iUeO65v6ON0y2EJdRfUy38hSqhO9M0Essyrd3oBCU+MaGX9bUx2sQMKhPU/mNOP0blt4JwgkBDHOBPSBjfaSeYb5ht6bY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=dDvWjcTW; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=tDqBPkxmd7B14/uRg9vwFvYaFbd8qXypV891MvbNPAs=; b=dDvWjcTWxDQAzb9q2qqJSivqth kAHO9AoI9LD1RS0sc+1J6TjBQgGvU61Bs/6GtQhBEpmUGzenC2/znPDOEtpb3SAv9ZhfazTBrd8Mk ldSkF4YxZ5g/4VQByc83BBhjdZXc0gi6aJlX8qGVw6BwWgFAyViPHlZSGYrd53uOxnK8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rtynh-00CWf1-9L; Tue, 09 Apr 2024 01:53:21 +0200 Date: Tue, 9 Apr 2024 01:53:21 +0200 From: Andrew Lunn To: Danielle Ratson Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "corbet@lwn.net" , "linux@armlinux.org.uk" , "sdf@google.com" , "kory.maincent@bootlin.com" , "maxime.chevallier@bootlin.com" , "vladimir.oltean@nxp.com" , "przemyslaw.kitszel@intel.com" , "ahmed.zaki@intel.com" , "richardcochran@gmail.com" , "shayagr@amazon.com" , "paul.greenwalt@intel.com" , "jiri@resnulli.us" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , mlxsw , Petr Machata , Ido Schimmel Subject: Re: [RFC PATCH net-next 9/9] ethtool: Add ability to flash transceiver modules' firmware Message-ID: <649f6db7-d0ef-41da-b2bb-e91fd0c21c7a@lunn.ch> References: <20240122084530.32451-1-danieller@nvidia.com> <20240122084530.32451-10-danieller@nvidia.com> <5bf6b526-02c4-4940-b8ec-bf858f9d4a58@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Thanks again for your feedback. > I thought again about you comment, and this patchset adds support for flashing CMIS compliant modules only. > Later on, if it will be expanded to more modules, it will be more reasonable to add support like you have suggested to fit the new supported standard. > So, currently I think it is better to not add it to this specific patchset. O.K. It should not be a big change, and i doubt it has any major performance impacts. I2C is not very fast, so we can probably get it off the disk faster than it can be written to the device. Andrew