Received-SPF: pass (google.com: domain of linux-kernel+bounces-136108-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Khalid Aziz <khalid@gonehiking.org>,
        "James E . J . Bottomley"
 <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: FlashPoint: remove redundant assignment to
 pointer currTar_Info
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240406155029.2593439-1-colin.i.king@gmail.com> (Colin Ian
	King's message of "Sat, 6 Apr 2024 16:50:29 +0100")
Organization: Oracle Corporation
Message-ID: <yq1v84rnvs2.fsf@ca-mkp.ca.oracle.com>
References: <20240406155029.2593439-1-colin.i.king@gmail.com>
Date: Mon, 08 Apr 2024 21:56:53 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?rPb2dfZJwFwmAjwB/SbtO+Xahwa+eKcoao/ifoE+Y8UMb8QKJsLfZriegWic?=
 =?us-ascii?Q?73n4juGUYIpEs0gEIWFsNkhFnFkZaA7JWZKABvIiXvmjNfANo7Widg6GlqCb?=
 =?us-ascii?Q?MDCfAwc5ipSVwl6iJ2UzoZFHdD+l+EwuBRvyKdM/cOA2ZfvSbUkQKUoJBS15?=
 =?us-ascii?Q?bUNJTmGlfOcobJcqAQSb86pXOaiI+S9avuJ25kMKrGw644CtYppE6Wane2s4?=
 =?us-ascii?Q?CsjOQL/UTv9+ApixaGdaIGyn3U7zzBjgx37cUJc6JpyXJ55Mop46gUOK5YzM?=
 =?us-ascii?Q?VG2RLaVfNgLdteJN3n9QKkB4yqdINmQT6TwuEdDeEL1O2Cb7gKLYfMr9IwPo?=
 =?us-ascii?Q?+1ZPvUU8Rc2k7sdaSSCBWcg9Eit1jehQYgRC61JiKl+UmwnMbmvuUSqbKFGM?=
 =?us-ascii?Q?VSKYtYdYWL6lGbV6w6QK2WT3/yRhhGtyrES6z31DHXrAyx/gVDhWbEj3xZ6C?=
 =?us-ascii?Q?yU6hq2sg7DWU+VV5R9zNpKvW65ZBQ+HIvCj+69Q4aT7t6yVbw8NWP42eH6r5?=
 =?us-ascii?Q?z8Bu7rnPYVagksQ5L8jvBwq2xkaVgn7chgzkIjqFip47rxnWGwBsQH2xathD?=
 =?us-ascii?Q?WBpq1iAGyIMJNJF27sgRU8zKNVrk9wg9ssWSKVjzod9PYuMe44Q2GbfjVHr3?=
 =?us-ascii?Q?F+xWruI7SAWDzXSSOE1xWtf1F1PWXXBEMttGut2v6V4xifcShAhDHDTv1ZCY?=
 =?us-ascii?Q?peIVCNdXOoxvh72ItMIkbaumCvI0mBXnx+WlGaxJ5smTbqarrPGXUwtHI1mz?=
 =?us-ascii?Q?ZSygjCShNk+TiNh7KHTxZmmGtUMpevUkIWcvf0z97e3DU09IzBB/uNdT5Tvj?=
 =?us-ascii?Q?jYJ2rEjglo8c5JWmkyq4P3BqGwReklYevLEb2MEgESOQOerFULFNCTm1/p8M?=
 =?us-ascii?Q?98vKBfwfMvLcVIdqu1FOVuxwQEElp7kZNU+hepTixI2xdc9Z18Zd9VKPwinV?=
 =?us-ascii?Q?U4UiOdLHy3NCv2eY7ULGOlvdxrjWVlzA6ke/l44seUqdBF0KuOi1djTkcLTz?=
 =?us-ascii?Q?2kMAoWyfGknR6LdSMPhYtZGLd96mmcVhhdm8XebiSHgbNskVzeit2SMbHzcw?=
 =?us-ascii?Q?T7bazhJ5SO2SPQ202cJ0A50uie6oy+vioGNBaR9jwqGv4ZFcUSZo16t0hOIp?=
 =?us-ascii?Q?vnRTgGr5BnFujxvbJ9bdlYWFPs8NMKe/qAYjHkfLgM8WkuwtqUpNtKLO83So?=
 =?us-ascii?Q?Gok8F8bemqNhlS0Q8D7HleDcWVHI2q0Wy584QshwfCPkAWlBQpPd1+WRCOoT?=
 =?us-ascii?Q?5erTNQ5neMCB0Xy13ziKYiNs7RfMed6slA7n+/EfNSHHM5KwUqRm2WHvtrh9?=
 =?us-ascii?Q?EkXphIEFaX+fYX6HjflWJxVrF5wOXfo1+ptGMF7IRKuYQX2JpU31wtrAfpbU?=
 =?us-ascii?Q?XTT2NHb/P5tcNtGQm5q0HwtHEsn+CjG17js0L7+t3fwmt5Dr6ZTFSF8QYTHD?=
 =?us-ascii?Q?+/qO4AGgw9z92a1fcStTCcy3UNbvD+NOHT/iJb4YzP0DQDF6d+In3I+9pxX2?=
 =?us-ascii?Q?2IoUWHNH1TEDS00n0ev75uG6Vrl9nA2UlWt4fBnX4j1Kiw6tGcpFauZ9ddhd?=
 =?us-ascii?Q?6ChDNKiGP+27kn+bopz76abNCQWQjqJ1nKeehkJmNhY2Gl+LVJUGWWauMgd6?=
 =?us-ascii?Q?rQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	NOcCwE3yMWL+KizsKFg7MSjQS488wWW2r+jMtek3f0PL65GjOyIWYeL3kR+XP4MmP71m/+SHpgicvRypPUr1Vp1CuYUcslmiS6hcpS+x8ha8PHpgtGfSJUdS1xeElRXUCBb1UadLxCEr6pbqCbbbL22fVW0fDpuiYUTZhg6JTV1Z0h2gGFDxuievwv5Erwiko6POucauL/nNrnPcJOHrhEyUFVGJ4ZJB8F+20lXgv2Jkx4idMH5JwMHztwwg88hkvbxN5x4EavebhAaF5bSe7WbfAhw1HPkMKanv2ANbFcluJFW6SDouSdfjlhrxlvl12T2z/KepMWNekaP42mjdSJwz+8iSMH1podPPxjYkYSP5H1H6B/2gZ/CzG+nd4WjtXeezr3OEMPmxxxTw5PVsO2JxYWLDenagftD8INTblDcDYGvrHmd/H6CtW3JRp8CL71DRBP+u+kqF4V6Wa379wjygk4fQoA+J/V8AQpqFVwaxCF9jerhuNLb+9SjUJVxXEKfO1ulS2WGo+pzTG1OJDI0DI4bxRRmmB4MaS2Crp70jIpzFvYdwN2tf/OYiZzeq6e3AsysZ7DVlhCCQ7vpQiKrYsnwg7X3qyUbFoXJ1phA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3789651a-08de-4ade-6a1e-08dc58385681
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 01:56:57.4339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c//ioqf3MTwRy6ppyuZ1VfsqI8GQ5KTtC8v8mYNdTRqcrTUh+aLmsPWZAlu9nmBD4wE9QpkuyV32yOsPgnF5UKAXVHvyw+drPm/OYqLnNFc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5711
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-08_19,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404090009
X-Proofpoint-GUID: SjMFgn7tOoITT279chNHxto4VNFzGS1R
X-Proofpoint-ORIG-GUID: SjMFgn7tOoITT279chNHxto4VNFzGS1R


Colin,

> Pointer currTar_Info is being assigned a value that is never read, it
> is being re-assigned a few lines later in the start of a following
> do-while loop. The assignment is redundant and can be removed.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering